DaniWeb Forum Index > Web Development > PHP

Making tutorials - your wishlist

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

« First

Last »

•

Join Date: Jun 2007

Posts: 1,227

Reputation: kkeith29 has a spectacular aura about

Solved Threads: 167

kkeith29

Offline

Nearly a Posting Virtuoso

#81

Oct 15th, 2009

Both players are ok. The default.html one has that flvplayer image in the upper right hand corner which is annoying.

As for the content of the tutorial, I have noticed some errors.

The entire tutorial is suppose to be about a blog, not a blog commenting system. Blogs don't allow anyone to add their own post. There should be an admin area where the blog owner updates and adds blog entries. You just have shown how to add comments.

HTML:

You didn't declare a doctype.
You are missing the <html></html> tags.
Your form tag is missing the action attribute which is required.
Your textarea is missing the cols and rows attributes which are required.
You are using inline styling which isn't good.
Indent your html so its easier to read.

PHP:
The method of post separation you used doesn't make sense to me. You are adding unnecessary data to the file.

Your code doesn't allow for line breaks. They are forgotten when the post is submitted. If you replace those with nl2br() and then store the posts with a new line between them you can just use file() to get the data.

You need to show how to open up files with fopen,fread,fclose because not all of the viewers will have php5 for the file_get_contents.

The alternating colors could be handled differently. Why not use the % operator?

Checking if $_POST is set will always return true. I wouldn't use that. You should check to see that the submit button name is in the post array.

There were some other things that didn't quite make sense to me. I will look through it again to see if I understand what you were trying to do.

Last edited by kkeith29; Oct 15th, 2009 at 8:02 am.

Google is your friend.

Use [code] tags.

If you have found a solution to your problem, please mark the thread as SOLVED.

•

Join Date: Sep 2007

Posts: 1,473

Reputation: cwarn23 has a spectacular aura about

Solved Threads: 136

cwarn23

Offline

Nearly a Posting Virtuoso

#82

Oct 15th, 2009

I shall fix all of that in the next version of the tutorial and the only part of kkeith29's comment that I would disagree with is the following:

•

Your textarea is missing the cols and rows attributes which are required.

Well what I did there was I used css to set the box size instead of using cols and rows. So css took over that job making it more efficient. So I as I said, thanks for the comment on that and I have just discovered a new flv player which is free (others cost hundreds with a doggy license) and should do the job. You will be able the view the viewer I am going to use at
http://www.syntax.cwarn23.info/media/new.html
Wonder what other negative comments there will be on this video?

Try not to bump 10 year old threads as it can be really annoying.
Like php then read my website at http://syntax.cwarn23.net/
Star-Trek-Atlantis - now that's what I call a movie ^_^
My favourite PC. - MacGyver Fan
Bad english note: dis-iz-2b4u

•

Join Date: Jun 2007

Posts: 1,227

Reputation: kkeith29 has a spectacular aura about

Solved Threads: 167

kkeith29

Offline

Nearly a Posting Virtuoso

#83

Oct 15th, 2009

Sorry, I might of sounded at bit harsh there. Its 6:13am here and I haven't been to bed yet. I was just listing what I saw. I figured since others will be viewing and learning from it, the tutorial must be as simple as possible using the best techniques.

The rows and cols comment comes from the fact the w3 validator says they are required.

I am recoding the tutorial using the stuff I mentioned earlier. I will post it here for you to look at and see if you want to implement any of it.

Google is your friend.

Use [code] tags.

If you have found a solution to your problem, please mark the thread as SOLVED.

•

Join Date: Sep 2007

Posts: 1,473

Reputation: cwarn23 has a spectacular aura about

Solved Threads: 136

cwarn23

Offline

Nearly a Posting Virtuoso

#84

Oct 15th, 2009

•

Sorry, I might of sounded at bit harsh there. Its 6:13am here and I haven't been to bed yet.

I think you misunderstood part of my text. I actually like the negative feedback because then I know what to change for next time. So it is great that you posted so many questions and statements. Just for that I'll add + to your rep.

•

The rows and cols comment comes from the fact the w3 validator says they are required.

Ok, then I shall read the w3 documentation to see how they recommend using both css and html (cols/rows) usage.

•

Join Date: Jun 2007

Posts: 1,227

Reputation: kkeith29 has a spectacular aura about

Solved Threads: 167

kkeith29

Offline

Nearly a Posting Virtuoso

#85

Oct 15th, 2009

The new player you are using has a flaw in it. When I press play it starts the video, but doesn't show a pause button. I just goes directly back to play. So when I try to pause it, it darkens the screen and keeps playing the video. Its like the button is inverted.

Google is your friend.

Use [code] tags.

If you have found a solution to your problem, please mark the thread as SOLVED.

•

Join Date: Sep 2007

Posts: 1,473

Reputation: cwarn23 has a spectacular aura about

Solved Threads: 136

cwarn23

Offline

Nearly a Posting Virtuoso

#86

Oct 15th, 2009

Doh.
Version 10 of Flash is so incompatible with version 9 designed apps. With version 9 of Flash the bar is perfect but as soon as I go into Internet Explorer which has version 10 then the bar as you said is backwards. I guess I have another long journey finding a free flv player ahead of me.

•

Join Date: Jun 2007

Posts: 1,227

Reputation: kkeith29 has a spectacular aura about

Solved Threads: 167

kkeith29

Offline

Nearly a Posting Virtuoso

#87

Oct 15th, 2009

Here is my version of your tutorial. The css styling is incomplete as I didn't feel like doing it. This is xhtml strict validated. The php is untested but looked like it would work.

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<title>My Blog</title>
	<meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
	<style type="text/css">
		body {
			font-family: arial,"arial black","sans serif";
			font-size: 12px;
		}
		#container {
			width: 500px;
		}
		.gray {
			background-color: #999;	
		}
		.light-gray {
			background-color: #ccc;
		}
		#container .entry {
			width: 500px;
			margin-top: 15px;
			border: 1px #333 solid;
		}
		#container .entry .name {
			/*style the name here*/
		}
		#container .entry .content {
			/*style the content here*/
			padding: 5px;
		}
		.form .form-row {
			/*style form rows here*/
		}
		.form .form-label,.form-data {
			padding: 5px;
			/*style form labels and inputs here*/
		}
	</style>
</head>
<body>
	<div id="container">
<?php
 
$data = array_chunk( file('data.txt'),2 );
 
$i = 0;
foreach( $data as $entry ) {
	list( $name,$content ) = $entry;
	$color = ( ( $i % 2 ) == 0 ? 'gray' : 'light-gray' );
	echo <<<ENTRY
		<div class="entry {$color}">
			<div class="name">Name: {$name}</div>
			<div class="content">{$content}</div>
		</div>
ENTRY;
	$i++;
}
 
if ( isset( $_POST['submit'] ) ) {
	$name = htmlentities( $_POST['name'],ENT_QUOTES );
	$entry = str_replace( array('\r\n','\r','\n'),'<br />',htmlentities( $_POST['data'],ENT_QUOTES ) );
	//can add error handling here, check for duplicate entries
	file_put_contents( 'data.txt',"{$name}\n{$entry}\n",FILE_APPEND );
}
 
?>
		<div class="form">
			<form action="index.html" method="post">
				<div class="form-row">
					<div class="form-label">Name:</div>
					<div class="form-data"><input type="text" name="name" /></div>
				</div>
				<div class="form-row">
					<div class="form-label">Entry:</div>
					<div class="form-data"><textarea cols="30" rows="7"></textarea></div>
				</div>
			</form>
		</div>
	</div>
</body>
</html>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<title>My Blog</title>
	<meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
	<style type="text/css">
		body {
			font-family: arial,"arial black","sans serif";
			font-size: 12px;
		}
		#container {
			width: 500px;
		}
		.gray {
			background-color: #999;	
		}
		.light-gray {
			background-color: #ccc;
		}
		#container .entry {
			width: 500px;
			margin-top: 15px;
			border: 1px #333 solid;
		}
		#container .entry .name {
			/*style the name here*/
		}
		#container .entry .content {
			/*style the content here*/
			padding: 5px;
		}
		.form .form-row {
			/*style form rows here*/
		}
		.form .form-label,.form-data {
			padding: 5px;
			/*style form labels and inputs here*/
		}
	</style>
</head>
<body>
	<div id="container">
<?php

$data = array_chunk( file('data.txt'),2 );

$i = 0;
foreach( $data as $entry ) {
	list( $name,$content ) = $entry;
	$color = ( ( $i % 2 ) == 0 ? 'gray' : 'light-gray' );
	echo <<<ENTRY
		<div class="entry {$color}">
			<div class="name">Name: {$name}</div>
			<div class="content">{$content}</div>
		</div>
ENTRY;
	$i++;
}

if ( isset( $_POST['submit'] ) ) {
	$name = htmlentities( $_POST['name'],ENT_QUOTES );
	$entry = str_replace( array('\r\n','\r','\n'),'<br />',htmlentities( $_POST['data'],ENT_QUOTES ) );
	//can add error handling here, check for duplicate entries
	file_put_contents( 'data.txt',"{$name}\n{$entry}\n",FILE_APPEND );
}

?>
		<div class="form">
			<form action="index.html" method="post">
				<div class="form-row">
					<div class="form-label">Name:</div>
					<div class="form-data"><input type="text" name="name" /></div>
				</div>
				<div class="form-row">
					<div class="form-label">Entry:</div>
					<div class="form-data"><textarea cols="30" rows="7"></textarea></div>
				</div>
			</form>
		</div>
	</div>
</body>
</html>

Last edited by kkeith29; Oct 15th, 2009 at 8:59 am.

Google is your friend.

Use [code] tags.

If you have found a solution to your problem, please mark the thread as SOLVED.

•

Join Date: Sep 2007

Posts: 1,473

Reputation: cwarn23 has a spectacular aura about

Solved Threads: 136

cwarn23

Offline

Nearly a Posting Virtuoso

#88

Oct 15th, 2009

I shall make some new code with yours being a guide of what features should be implemented (example: I see you added a name field for each poster). Also I'm not sure if this applies in your script but the file function can be a bit buggy because at the end of each array it appends the string "\r\n" which is the new line in the text file. I will post new code in the next 1 or 2 days on this thread to see if it is good enough to be aired.

•

Join Date: Jun 2007

Posts: 1,227

Reputation: kkeith29 has a spectacular aura about

Solved Threads: 167

kkeith29

Offline

Nearly a Posting Virtuoso

#89

Oct 15th, 2009

I have never had that problem (I must not of noticed it). You can just read the file and use explode with "\n" kind of like you did before. Or use array_filter right after the file() call.

Last edited by kkeith29; Oct 15th, 2009 at 9:04 am.

Google is your friend.

Use [code] tags.

If you have found a solution to your problem, please mark the thread as SOLVED.

•

Join Date: Sep 2007

Posts: 1,473

Reputation: cwarn23 has a spectacular aura about

Solved Threads: 136

cwarn23

Offline

Nearly a Posting Virtuoso

#90

Oct 16th, 2009

I just found a free flv player and can be previewed at
http://www.syntax.cwarn23.info/media/new.html
Are you able to spot any obvious bug that I didn't see. I know the full screen mode doesn't work but other than that is it all ok? Thanks.