Java

Input an integer number and display its largest factor

Please support our Java advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Oct 2009

Posts: 15

Reputation: kulrik is an unknown quantity at this point

Solved Threads: 0

kulrik

Offline

Newbie Poster

Input an integer number and display its largest factor

-1

Nov 2nd, 2009

Alright guys i got another one:

In the class Mymath, create a public method called calculateFactor. The method has two two arguments of type integer and checks whether the smaller of the two integers is a factor of the larger of the two integers. The method will return a factor or a zero.

Write a main method which reads in a positive integer n and displays out the largest proper divisor of n (that is, the largest factor of n that is less than n itself).

Sample output:

Input an integer number:
124
Largest divisor: 62
Another input (y/n)?
y
Input an integer number:
18
Largest divisor: 9

Sample Run:

6
28
496

Im having alot of trouble with this one. Please Help.

•

Join Date: Jul 2009

Posts: 243

Reputation: masterofpuppets is an unknown quantity at this point

Solved Threads: 60

masterofpuppets masterofpuppets is offline

Offline

Posting Whiz in Training

-1

Nov 2nd, 2009

for the first problem you could do something like this:

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
public class Mymath {
 
    public calculateFactor( int a, int b ) {
        if ( a < b && b % a == 0 )
            return true;
        elif ( a > b && a % b == 0 )
            return true;
        else
            return false;
    }
}
public class Mymath {

    public calculateFactor( int a, int b ) {
        if ( a < b && b % a == 0 )
            return true;
        elif ( a > b && a % b == 0 )
            return true;
        else
            return false;
    }
}

and for the second part see if this is any helpful

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
import java.util.Scanner;
 
public class Test {
 
	public static void main( String[] args ) {
	    Scanner in = new Scanner( System.in );
	    String goOn = "y";
	    int n, largest = 0;
	    do {
	        System.out.println( "Input an integer number:" );
	        n = in.nextInt();
 
	        for ( int i = 1; i < n; i++ )
	            if ( n % i == 0 )
	                if ( i > largest )
	                    largest = i;
	        System.out.println( "Largest divisor: " + largest );
	        System.out.println( "Another input (y/n)?" );
	        goOn = in.nextLine();
	        goOn = in.nextLine(); //doesn't work in there's only one don't know why.
	        largest = 0;
 
	    } while ( goOn.equals( "y" ) );
      }
}
import java.util.Scanner;

public class Test {

	public static void main( String[] args ) {
	    Scanner in = new Scanner( System.in );
	    String goOn = "y";
	    int n, largest = 0;
	    do {
	        System.out.println( "Input an integer number:" );
	        n = in.nextInt();
	        
	        for ( int i = 1; i < n; i++ )
	            if ( n % i == 0 )
	                if ( i > largest )
	                    largest = i;
	        System.out.println( "Largest divisor: " + largest );
	        System.out.println( "Another input (y/n)?" );
	        goOn = in.nextLine();
	        goOn = in.nextLine(); //doesn't work in there's only one don't know why.
	        largest = 0;
	        
	    } while ( goOn.equals( "y" ) );
      }
}

My site ->> http://8masterofpuppets8.webs.com/
"My belief is stronger than your doubt."

•

Join Date: Dec 2007

Posts: 1,711

Reputation: javaAddict is a name known to all

Solved Threads: 229

javaAddict javaAddict is offline

Offline

Posting Virtuoso

Nov 3rd, 2009

•

Originally Posted by masterofpuppets

hi
for the first problem you could do something like this:
Help with Code Tags

Java Syntax (Toggle Plain Text)
public class Mymath {
 
    public calculateFactor( int a, int b ) {
        if ( a < b && b % a == 0 )
            return true;
        elif ( a > b && a % b == 0 )
            return true;
        else
            return false;
    }
}
public class Mymath { public calculateFactor( int a, int b ) { if ( a < b && b % a == 0 ) return true; elif ( a > b && a % b == 0 ) return true; else return false; } }
and for the second part see if this is any helpful :
Help with Code Tags

Java Syntax (Toggle Plain Text)
import java.util.Scanner;
 
public class Test {
 
	public static void main( String[] args ) {
	    Scanner in = new Scanner( System.in );
	    String goOn = "y";
	    int n, largest = 0;
	    do {
	        System.out.println( "Input an integer number:" );
	        n = in.nextInt();
 
	        for ( int i = 1; i < n; i++ )
	            if ( n % i == 0 )
	                if ( i > largest )
	                    largest = i;
	        System.out.println( "Largest divisor: " + largest );
	        System.out.println( "Another input (y/n)?" );
	        goOn = in.nextLine();
	        goOn = in.nextLine(); //doesn't work in there's only one don't know why.
	        largest = 0;
 
	    } while ( goOn.equals( "y" ) );
      }
}
import java.util.Scanner; public class Test { public static void main( String[] args ) { Scanner in = new Scanner( System.in ); String goOn = "y"; int n, largest = 0; do { System.out.println( "Input an integer number:" ); n = in.nextInt(); for ( int i = 1; i < n; i++ ) if ( n % i == 0 ) if ( i > largest ) largest = i; System.out.println( "Largest divisor: " + largest ); System.out.println( "Another input (y/n)?" ); goOn = in.nextLine(); goOn = in.nextLine(); //doesn't work in there's only one don't know why. largest = 0; } while ( goOn.equals( "y" ) ); } }

Your first code will not compile and it is not java (elif)

The second is totally inefficient and shows no thinking at all to the real problem

Check out my New Bike at my Public Profile at the "About Me" tab

•

Join Date: Dec 2007

Posts: 1,711

Reputation: javaAddict is a name known to all

Solved Threads: 229

javaAddict javaAddict is offline

Offline

Posting Virtuoso

Nov 3rd, 2009

For the second problem. You need the largest divisor? Then why start the loop from 1 and not from the number itself:

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
int n; // read from input using Scanner;
int maxDivisor = 1;
 
for (int i=n-1;i>0;i--) {
    if ( n%i == 0) {
         maxDivisor = i;
          break;
    }
}
int n; // read from input using Scanner;
int maxDivisor = 1;

for (int i=n-1;i>0;i--) {
    if ( n%i == 0) {
         maxDivisor = i;
          break;
    }
}

Also a more efficient way is to have the initial value to be the number dived by 2.

Think about it, the number 100 will not be divided by 99, 98, .. or any of those numbers. It will not be divided by 51, but it will be by 50.
For 93 (93.0/2.0 = 46.5) you can start checking from 46 because none of the numbers above its half can divide it.

In java:
93/2 = 46
93/2.0 = 46.5

So this would work:

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
for (int i=n/2;i>0;i--) {
for (int i=n/2;i>0;i--) {

Check out my New Bike at my Public Profile at the "About Me" tab

•

Join Date: Dec 2007

Posts: 1,711

Reputation: javaAddict is a name known to all

Solved Threads: 229

javaAddict javaAddict is offline

Offline

Posting Virtuoso

Nov 3rd, 2009

For the first problem the method would be:

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
public int calculateFactor(int a, int b) {
  ...
}
public int calculateFactor(int a, int b) {
  ...
}

Inside you will do the checks described in the assignment. No explanation needed. The assignment tells you what to do and what to check. Surely you can understand by now how the '%' works.
Don't forget to check what happens if the 2 numbers are equal. You will still need to return one of the arguments, it doesn't matter which, since they are equal.

Check out my New Bike at my Public Profile at the "About Me" tab