DaniWeb Forum Index > Software Development > C++

Program wont work (Need help with parameter passing)

Please support our C++ advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Nov 2009

Posts: 1

Reputation: acdougla17 is an unknown quantity at this point

Solved Threads: 0

acdougla17 acdougla17 is offline

Offline

Newbie Poster

Program wont work (Need help with parameter passing)

Nov 9th, 2009

OK, so I have this project to do and cant figure it out. I am not positive on calling functions correctly and I am kind of lost when it comes to parameter passing. So my program needs to read a text file 1 integer at a time, find out if it is odd or even, add 1 to either odd_tally or even_tally, and then display the total # of even and odd integers.

I am only getting 3 Warnings right now and it is for unitialized variables (in_val, odd_tally, even_tally)

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <fstream>
using namespace std;
void examine(int, int, int);
void print(int &, int &);
void readFile(ifstream&, int);
int odd(int);
int even(int);
 
int main()
{
	int in_val, odd_tally, even_tally;
    ifstream dataIn;
 
    dataIn.open("prj4.txt");					//Open File
 
 
	if (dataIn.fail()){							//Failure opening file
	 cout << "Error opening data file.\n";
		}
	else
			{   readFile(dataIn, in_val);
	while (!dataIn.eof())                                   //Loop until end of text file
				{
					examine(in_val, odd_tally, even_tally); //Call examine function that will determine if integer s odd or even.
					print(odd_tally, even_tally);			//Call function to display results
				}
				dataIn.close();
			}
	return 0;
}
 
 
void readFile(ifstream &someFile, int txt_int)
{ 
    while (someFile >> txt_int); 					//Read File
	cout << endl;
}
 
void examine(int num,int odd,int even)
{	
	if (num % 2 ==0)                        
		 {
			int even(even);                 //Call even function if num is even
		 }
		else
		 {
			int odd(odd);                  //Call odd function if num is odd
		 }
}
 
int odd(int odd_tally)
	{
		return odd_tally + 1;            //Everytime a odd integer is found, add 1 to odd_tally.
	}
 
int even(int even_tally)
	{
		return even_tally + 1;			//Everytime a even integer is found, add 1 to even_tally.
	}
 
void print(int &odd_tally,int &even_tally)				//Display the total number of even and odd integers in the file.
	{
		cout << "There are " << even_tally << " even integers in the file.";
		cout << "There are " << odd_tally << " odd integers in the file.";
		cout << endl;
	}
#include <iostream>
#include <fstream>
using namespace std;
void examine(int, int, int);
void print(int &, int &);
void readFile(ifstream&, int);
int odd(int);
int even(int);

int main()
{
	int in_val, odd_tally, even_tally;
    ifstream dataIn;

    dataIn.open("prj4.txt");					//Open File


	if (dataIn.fail()){							//Failure opening file
	 cout << "Error opening data file.\n";
		}
	else
			{   readFile(dataIn, in_val);
	while (!dataIn.eof())                                   //Loop until end of text file
				{
					examine(in_val, odd_tally, even_tally); //Call examine function that will determine if integer s odd or even.
					print(odd_tally, even_tally);			//Call function to display results
				}
				dataIn.close();
			}
	return 0;
}


void readFile(ifstream &someFile, int txt_int)
{ 
    while (someFile >> txt_int); 					//Read File
	cout << endl;
}

void examine(int num,int odd,int even)
{	
	if (num % 2 ==0)                        
		 {
			int even(even);                 //Call even function if num is even
		 }
		else
		 {
			int odd(odd);                  //Call odd function if num is odd
		 }
}

int odd(int odd_tally)
	{
		return odd_tally + 1;            //Everytime a odd integer is found, add 1 to odd_tally.
	}

int even(int even_tally)
	{
		return even_tally + 1;			//Everytime a even integer is found, add 1 to even_tally.
	}

void print(int &odd_tally,int &even_tally)				//Display the total number of even and odd integers in the file.
	{
		cout << "There are " << even_tally << " even integers in the file.";
		cout << "There are " << odd_tally << " odd integers in the file.";
		cout << endl;
	}

Last edited by acdougla17; Nov 9th, 2009 at 12:29 pm.

•

Join Date: Oct 2009

Posts: 140

Reputation: restrictment is on a distinguished road

Solved Threads: 10

restrictment restrictment is offline

Offline

Junior Poster

Nov 9th, 2009

Help with Code Tags

(Toggle Plain Text)

	while (!dataIn.eof())                                   //Loop until end of text file
				{
					examine(in_val, odd_tally, even_tally); //Call examine function that will determine if integer s odd or even.
					print(odd_tally, even_tally);			//Call function to display results
				}
				dataIn.close();
			}
	return 0;
}
 
 
void readFile(ifstream &someFile, int txt_int)
{ 
    while (someFile >> txt_int); 					//Read File
	cout << endl;
}
 
void examine(int num,int odd,int even)
{	
	if (num % 2 ==0)                        
		 {
			int even(even);                 //Call even function if num is even
		 }
		else
		 {
			int odd(odd);                  //Call odd function if num is odd
		 }
}

Your parameters are not the same here. The appropriate argument would be:

Help with Code Tags

C++ Syntax (Toggle Plain Text)