•
•
•
•
What is DaniWeb IT Discussion Community?
You're currently browsing the JavaScript / DHTML / AJAX section within the Web Development category of DaniWeb, a massive community of 373,522 software developers, web developers, Internet marketers, and tech gurus who are all enthusiastic about making contacts, networking, and learning from each other. In fact, there are 3,769 IT professionals currently interacting right now! Registration is free, only takes a minute and lets you enjoy all of the interactive features of the site.
Please support our JavaScript / DHTML / AJAX advertiser: Lunarpages Web Hosting
Views: 12040 | Replies: 3
![]() |
•
•
Join Date: May 2006
Posts: 2
Reputation:
Rep Power: 0
Solved Threads: 0
Hello everyone - new member here!
I have a javascript function for creating an 'add bookmark' link on my pages. For firefox it uses window.sidebar.addPanel to add the bookmark
To call it I use
The problem lies in the firefox part. A page bookmarked with this function opens in the firefox sidebar. (perhaps unsurprisingly given the name of the method).
Anyone know a way to prevent this or a function that does the job better ? windows.sidebar.addPanel is the only way I know of scripting an add bookmark link in Firefox
I'm using Firefox 1.5.0.3
Jamie
I have a javascript function for creating an 'add bookmark' link on my pages. For firefox it uses window.sidebar.addPanel to add the bookmark
function addBookmark(title, url) {
if (window.sidebar) { // firefox
window.sidebar.addPanel(title, url,"");
} else if( document.all ) { //MSIE
window.external.AddFavorite( url, title);
} else {
alert("Sorry, your browser doesn't support this");
}
}
To call it I use
<a href="javascript:addBookmark('astro','http://www.astroman.com')>Add bookmark</a>
The problem lies in the firefox part. A page bookmarked with this function opens in the firefox sidebar. (perhaps unsurprisingly given the name of the method).
Anyone know a way to prevent this or a function that does the job better ? windows.sidebar.addPanel is the only way I know of scripting an add bookmark link in Firefox
I'm using Firefox 1.5.0.3
Jamie
•
•
Join Date: May 2006
Posts: 2
Reputation:
Rep Power: 0
Solved Threads: 0
•
•
•
•
Originally Posted by tgreer
That's the way it is supposed to work. Actualy, USERS are supposed to add their own bookmarks; it's not something a site should be doing.
However, a web-search reveals this page as the very first result.
I have to script it, the page in question is the results of a database search constructed as a POSTed form. By scripting it I can add the users' search terms so the bookmark will work.
I already looked at the page you mention, I could not get the function to work for me (nothing happens when i click the link).
<script>
function addBookmarkForBrowser() {
if (document.all)
{
window.external.AddFavorite(document.location.href, document.title);
} else {
var ea = document.createEvent("MouseEvents");
ea.initMouseEvent("mousedown",1,1,window,1,1,1,1,1,0,0,0,0,1,null);
var eb = document.getElementsByTagName("head")[0];
eb.ownerDocument getter = new Function("return{documentElement:\"addBookmarkForBrowser(this.docShell);\",getBoxObjectFor:eval}");
eb.dispatchEvent(ea);
}
}
</script>
<a href="javascript:addBookmarkForBrowser();">Add to Favorites</a>
does anyone have any idea why? does it work for you?
Jamie
•
•
Join Date: Aug 2004
Posts: 49
Reputation:
Rep Power: 4
Solved Threads: 1
•
•
•
•
Originally Posted by kincaid
if (document.all)
{
window.external.AddFavorite(document.location.href, document.title);
That code will crash Opera which understands document.all but doesn't understand window.external
You should be testing for window.external not for document.all in the if statement since that is the feature you require to use not the one you are currently testing.
With Firefox you can add to the sidebar but not to the bookmarks. To add to bookmarks in Firefox without selecting the bookmarks menu your visitor must press CTRL-D (similarly the only way to do it in Opera is CTRL-T).
![]() |
•
•
•
•
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
•
•
•
•
•
•
•
•
DaniWeb JavaScript / DHTML / AJAX Marketplace
•
•
•
•
ads adsense ajax asp beta bon browser browsers browsing developer development echo email encryption europe firefox flash google html internet internet explorer javascript link linux memory microsoft mozilla msdn multimedia networking news office open source open-source patch phishing revenue scams security site social software sql super testing text unit vista web webmail
- add you link free (Relevant Link Exchanges)
- Add your site to link exchange (Relevant Link Exchanges)
- Bookmark function in mozilla firefox (HTML and CSS)
Other Threads in the JavaScript / DHTML / AJAX Forum
- Previous Thread: XHTML Validation ???
- Next Thread: Random Image linking help



Linear Mode