DaniWeb Forum Index > Software Development > C++

C++ RSS

Dynamic Array of Structures, Loop problem!

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Jun 2006

Posts: 7

Reputation: binteron is an unknown quantity at this point

Solved Threads: 0

binteron

Offline

Newbie Poster

Dynamic Array of Structures, Loop problem!

Jun 24th, 2006

I am new to C++ and working through SAMS C++ primer. one of the excercies involves creating a dynamic array of structures to catalogue car information. I have the following code almost working and I am sure that I am missing something really simple.

The program compiles and runs as expected, however on the first run through the loop, the "make" of the car is not stored in the array. All subsequent loops capture the input and display properly.

Any help or point in the right direction would be appreciated.

thanks.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
//c++ primer ch 5 ex 6.
#include <iostream>
using namespace std;
 
struct car {
 
    char make[20];
    int year;
 
 
};
int c;
int t = 1;
    int main() {
            cout <<"How many cars would you like to catalogue? ";
            cin >>c;
            cin.get();
 
            car * catalogue = new car[c];
            car *ptr = &catalogue[0];
 
            for (int i = 0;i < c; ++i)
            {                 
                cout <<"Car# "<<t<<":\n";
                cout <<"Enter make of car: ";
                cin.getline(ptr[i].make,20);
                cout <<"Enter year of car: ";
                cin >> ptr[i].year;
                cin.get();
                cout <<"\n";            
            ++t;
            };
            delete [] catalogue;
 
            cout <<"Your catalogue of cars: \n";
            for (int i = 0; i < c;++i)
            { cout <<catalogue[i].year<<" "<<catalogue[i].make<<"\n";
            };
 
    }
//c++ primer ch 5 ex 6.
#include <iostream>
using namespace std;

struct car {

    char make[20];
    int year;

    
};
int c;
int t = 1;
    int main() {
            cout <<"How many cars would you like to catalogue? ";
            cin >>c;
            cin.get();

            car * catalogue = new car[c];
            car *ptr = &catalogue[0];

            for (int i = 0;i < c; ++i)
            {                 
                cout <<"Car# "<<t<<":\n";
                cout <<"Enter make of car: ";
                cin.getline(ptr[i].make,20);
                cout <<"Enter year of car: ";
                cin >> ptr[i].year;
                cin.get();
                cout <<"\n";            
            ++t;
            };
            delete [] catalogue;

            cout <<"Your catalogue of cars: \n";
            for (int i = 0; i < c;++i)
            { cout <<catalogue[i].year<<" "<<catalogue[i].make<<"\n";
            };

    }

•

Join Date: Dec 2005

Posts: 5,850

Reputation: Salem has a reputation beyond repute

Solved Threads: 749

Salem

Offline

Void main'ers are DOOMed

Re: Dynamic Array of Structures, Loop problem!

Jun 24th, 2006

> car *ptr = &catalogue[0];
What does this achieve?

You can do this
cin.getline(catalogue[i].make,20);

> delete [] catalogue;
You need to do this after you've finished printing the data, not before.

> however on the first run through the loop, the "make" of the car is not stored in the array
Maybe you typed a space after the input of how many cars
So the get() only got rid of the space, not the newline which would immediately satisfy the getline.

•

Join Date: Jun 2006

Posts: 7

Reputation: binteron is an unknown quantity at this point

Solved Threads: 0

binteron

Offline

Newbie Poster

Re: Dynamic Array of Structures, Loop problem!

Jun 25th, 2006

Hi Salem, Thanks for the quick reply. *ptr is something from a different book, it said pointer was best way to access dynamic arrays.

I have run the program many times and not entered a space after the number of cars, so that's a good thought, but not it. Also I had put a cin.get() after the input to see if there was something there causing the problem.

•

Join Date: Jun 2006

Posts: 7

Reputation: binteron is an unknown quantity at this point

Solved Threads: 0

binteron

Offline

Newbie Poster

Re: Dynamic Array of Structures, Loop problem!

Jun 25th, 2006

Well, I moved the delete [] catalogue line to the end of the program and now the thing runs perfectly.

Thanks Salem! I new it would be something simple and painfully obvious when you look at it.....duhhh.

best regards

•

Join Date: Dec 2005

Posts: 5,850

Reputation: Salem has a reputation beyond repute

Solved Threads: 749

Salem

Offline

Void main'ers are DOOMed

Re: Dynamic Array of Structures, Loop problem!

Jun 25th, 2006

> it said pointer was best way to access dynamic arrays.
It's the only way.

But both variables have the same type.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
            car * catalogue = new car[c];
            car *ptr = &catalogue[0];
            car * catalogue = new car[c];
            car *ptr = &catalogue[0];

All you've actually achieved is changing a 9-letter variable name (with some meaning) for a 3-letter variable name (with very little meaning). ptr[n] and catalogue[n] do exactly the same thing.

What you've also created is a dangling pointer problem. By having two variables pointing at the same memory you introduce the possibility of accessing ptr[n] long after you've done delete [ ] catalogue.

•

Join Date: Jun 2006

Posts: 7

Reputation: binteron is an unknown quantity at this point

Solved Threads: 0

binteron

Offline

Newbie Poster

Re: Dynamic Array of Structures, Loop problem!

Jun 25th, 2006

I see, so in essence i created an extra pointer, one that wasn't needed. I had wondered about that, I must have misinterpreted the first book i read. Thanks a bunch for taking the time to clear that up form me.

Cheers Salem.