DaniWeb Forum Index > Software Development > C++

C++ RSS

getline cutting off input

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Jul 2007

Posts: 5

Reputation: bapef is an unknown quantity at this point

Solved Threads: 0

bapef

Offline

Newbie Poster

getline cutting off input

Jul 12th, 2007

The problem I am having is one in which I am using getline to read in a name with spaces, and when I attempt to output it it is cutting off the beginning of the names. This is the code I am using. I also have to have the cin.ignore('\n') else the program skips over the input completely.

newcustomer=new customerType;
cout<<"Please enter a name: ";
cin.ignore('\n');
cin.getline(newcustomer->name,21,'\n');

Any help is greatly appreciated as the project I am working ons deadline is approaching quick.

for example of what it does say I enter "john smith" minus the quotes, the output on the screen is just the 'h' at the end of smith nothing else.

Last edited by bapef; Jul 12th, 2007 at 12:17 am. Reason: forgot something

•

Join Date: Sep 2006

Posts: 80

Reputation: parthiban is an unknown quantity at this point

Solved Threads: 6

parthiban

Offline

Junior Poster in Training

Re: getline cutting off input

Jul 12th, 2007

Hi bapef ,
I don't know whether you are using array of character or string data type for 'name'.

If you are using character array means get() function will help to get around this problem .

Here's an example

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
# include <iostream>
using namespace std;
 
int main(void)
{
    const int MAX =80;
    char full_name[MAX];
    cout<<"Enter your name: ";
    cin.get(full_name,MAX);
    cout<<"Hi !"<<full_name<<endl;
    cin.get();
 
    return 0;
}
# include <iostream>
using namespace std;

int main(void)
{
    const int MAX =80;
    char full_name[MAX];
    cout<<"Enter your name: ";
    cin.get(full_name,MAX);
    cout<<"Hi !"<<full_name<<endl;
    cin.get();

    return 0;
}

If you are using an instance of string data type means follow this approach :

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
# include <iostream>
# include <string>
using namespace std;
 
int main(void)
{
    string full_name;
    cout<<"Enter your name: ";
    getline(cin,full_name);
    cout<<"Hi !"<<full_name<<endl;
    cin.get();
 
    return 0;
}
# include <iostream>
# include <string>
using namespace std;

int main(void)
{
    string full_name;
    cout<<"Enter your name: ";
    getline(cin,full_name);
    cout<<"Hi !"<<full_name<<endl;
    cin.get();

    return 0;
}

Hopes it's helpful for you .

but I have one question if we execute the above code in Microsoft visual c++ compiler means i have to enter two times to input name where as i works perfectly in Devc++ compiler I don't why
can any one clarify me ?

•

Join Date: Jul 2007

Posts: 126

Reputation: krnekhelesh is an unknown quantity at this point

Solved Threads: 3

krnekhelesh krnekhelesh is offline

Offline

Junior Poster

Re: getline cutting off input

Jul 12th, 2007

Can't you instead use gets() function?

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include<iostream.h>
#include<conio.h>
 
int main()
{
  char name[25];
  cout<<"Enter the name of the customer: ";
  gets(name);
  cout<<name;
}
#include<iostream.h>
#include<conio.h>

int main()
{
  char name[25];
  cout<<"Enter the name of the customer: ";
  gets(name);
  cout<<name;
}

gets(name); inputs the name with all the blanks and everything.Thats the difference between cin and gets.

Ubuntu Linux User #25732

•

Join Date: Aug 2005

Posts: 15,381

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1466

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: getline cutting off input

Jul 12th, 2007

•

Originally Posted by krnekhelesh

Can't you instead use gets() function?

No -- gets() is C not C++ and its terrible to use in C code too.

Last edited by Ancient Dragon; Jul 12th, 2007 at 6:10 am.

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Aug 2005

Posts: 15,381

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1466

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: getline cutting off input

Jul 12th, 2007

•

Originally Posted by bapef

Help with Code Tags

C++ Syntax (Toggle Plain Text)
newcustomer=new customerType;
cout<<"Please enter a name: ";
cin.ignore('\n');
cin.getline(newcustomer->name,21,'\n');
newcustomer=new customerType; cout<<"Please enter a name: "; cin.ignore('\n'); cin.getline(newcustomer->name,21,'\n');
for example of what it does say I enter "john smith" minus the quotes, the output on the screen is just the 'h' at the end of smith nothing else.

post the customerType structure -- how did you declare name? Since this is c++ why don't you use std::string instead of char*?

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Jul 2007

Posts: 5

Reputation: bapef is an unknown quantity at this point

Solved Threads: 0

bapef

Offline

Newbie Poster

Re: getline cutting off input

Jul 12th, 2007

parthiban I tried using cin.get() and I still end up with it cutting off most of the name. Its really weird and I know once I see the solution I am going to kick myself for its simplicity.

Ancient Dragon here is my struct declaration,
struct customerType
{
char name[21];
int pin;
float balance;
customerType *link;
};

I used a char array because there is a fixed ammount of room for the customers names.

Last edited by bapef; Jul 12th, 2007 at 4:37 pm.

•

Join Date: Aug 2005

Posts: 5,264

Reputation: iamthwee is a splendid one to behold

Solved Threads: 377

iamthwee

Offline

Posting Expert

Re: getline cutting off input

-2

Jul 12th, 2007

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream.h>
#include <conio.h>
 
struct customerType
{
char name[21];
int pin;
float balance;
customerType *link;
};
 
void main(){
customerType newcustomer ;
cout<<"Please enter a name: ";
cin.getline(newcustomer.name,21);
cout <newcustomer.name;
getch();
}
#include <iostream.h>
#include <conio.h>

struct customerType
{
char name[21];
int pin;
float balance;
customerType *link;
};

void main(){
customerType newcustomer ;
cout<<"Please enter a name: ";
cin.getline(newcustomer.name,21);
cout <newcustomer.name;
getch();
}

Seems to work

Last edited by cscgal; Jul 13th, 2007 at 2:06 am. Reason: Removed color bbcode and added code tags

*Voted best profile in the world*

•

Join Date: Sep 2006

Posts: 80

Reputation: parthiban is an unknown quantity at this point

Solved Threads: 6

parthiban

Offline

Junior Poster in Training

Re: getline cutting off input

Jul 13th, 2007

I think you are using cin.ignore() before cin.getline() function. Avoid it and try .
It will work perfectly without cin.ignore() function .

If you want to access name using pointer means this code works

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
#include <iostream.h>
#include <conio.h>
 
struct customerType
{
    char name[21];
    int pin;
    float balance;
    customerType *link;
};
 
void main()
{
    customerType* newcustomer= new customerType;
    cout<<"Please enter a name: ";
    //cin.ignore('\n');
 
    cin.getline(newcustomer->name,21);
 
    cout<<newcustomer->name<<endl;
 
 
}
#include <iostream.h>
#include <conio.h>

struct customerType
{
    char name[21];
    int pin;
    float balance;
    customerType *link;
};

void main()
{
    customerType* newcustomer= new customerType;
    cout<<"Please enter a name: ";
    //cin.ignore('\n');

    cin.getline(newcustomer->name,21);

    cout<<newcustomer->name<<endl;

    
}

one more thing is the third argument for getline is by default '\n' so that is also no need .

•

Join Date: Aug 2005

Posts: 15,381

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1466

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: getline cutting off input

Jul 13th, 2007

You should not hardcode the size of the name array as shown on line 18 but use the sizeof operator so that if you change the size of the array you don't have to worry about changing it in more than one spot.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
cin.getline(newcustomer->name, sizeof(newcustomer->name));
cin.getline(newcustomer->name, sizeof(newcustomer->name));

or like this

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
cin.getline(newcustomer->name, 
   sizeof((struct customerType*)0->name));
cin.getline(newcustomer->name, 
   sizeof((struct customerType*)0->name));