Java

Java RSS

Changing the icons of JButtons

Please support our Java advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Aug 2004

Posts: 350

Reputation: Ghost is an unknown quantity at this point

Solved Threads: 2

Ghost

Offline

Posting Whiz

Changing the icons of JButtons

Aug 21st, 2007

Hi,
I am trying to create a simon-says type game, where there are four icons of different colors. One icon lights up. The user clicks it. Next, a new icon lights up. The user clicks the sequence... etc, etc, etc.
Right now, the first round works. Unfortunately, the icons do not change after that point. Any help would be appreciated. Thanks!

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
import javax.swing.*;
import javax.swing.event.*;
import java.awt.*;
import java.awt.event.*;
 
public class IanSays extends JFrame implements ActionListener
{
    ImageIcon dark [] = {new ImageIcon("darkRed.png"),
                  new ImageIcon("darkBlue.png"), new ImageIcon("darkGreen.png"),
                                             new ImageIcon("darkYellow.png")};
    ImageIcon light [] = {new ImageIcon("red.png"),
                  new ImageIcon("blue.png"), new ImageIcon("green.png"),
                                             new ImageIcon("yellow.png")};
    JButton btns [] = {new JButton(dark[0]),new JButton(dark[1]),
                    new JButton(dark[2]), new JButton(dark[3])};
 
    Container cont;
 
    String code = "";
 
    String guess = "";
 
    int guesses = 0;
 
    public IanSays()
    {
        super("Ian Says");
        setSize(415,425);
        setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        setVisible(true);
 
        cont = getContentPane();
        cont.setLayout(null);
 
        for(int i = 0; i < btns.length; i++)
        {
            cont.add(btns[i]);
            btns[i].addActionListener(this);
            if(i<2)
            {
                btns[i].setBounds(i*200,0,200,200);
            }
            else
            {
                btns[i].setBounds((i-2)*200,200,200,200);
            }
        }
        play();
    }
 
    public void play()
    {
        System.out.println("play");
        for(int i = 0; i < code.length(); i++)
        {
            System.out.println(" in play loop");
            reset();
 
            cont.validate();
 
            try
            {
                Thread.sleep(250);
            }
            catch(Exception e){}
 
            char letter = code.toCharArray()[i];
            if(letter=='r')
            {
                System.out.println("    RED");
                btns[0].setIcon(light[0]);
            }
            if(letter=='b')
            {
                System.out.println("    BLUE");
                btns[1].setIcon(light[1]);
            }
            if(letter=='g')
            {
                System.out.println("    GREEN");
                btns[2].setIcon(light[2]);
            }
            if(letter=='y')
            {
                System.out.println("    YELLOW");
                btns[3].setIcon(light[3]);
            }
 
            cont.validate();
 
            try
            {
                Thread.sleep(250);
            }
            catch(Exception e){}
        }
 
        try
        {
            Thread.sleep(250);
        }
        catch(Exception e){}
 
        newColor();
 
        try
        {
            Thread.sleep(250);
        }
        catch(Exception e){}
        reset();
        System.out.println("    end of play");
    }
 
    public void newColor()
    {
        int rand = (int)(Math.random()*4);
        if(rand==0)
        {
            btns[rand].setIcon(light[rand]);
            code+="r";
        }
        if(rand==1)
        {
            btns[rand].setIcon(light[rand]);
            code+="b";
        }
        if(rand==2)
        {
            btns[rand].setIcon(light[rand]);
            code+="g";
        }
        if(rand==3)
        {
            btns[rand].setIcon(light[rand]);
            code+="y";
        }
        cont.validate();
    }
 
    public void reset()
    {
        for(int i = 0; i < btns.length; i++)
        {
            btns[i].setIcon(dark[i]);
        }
    }
 
    public void actionPerformed(ActionEvent e)
    {
        for(int i = 0; i < btns.length; i++)
        {
            if(e.getSource()==btns[i])
            {
                if(i==0)
                    guess+="r";
                if(i==1)
                    guess+="b";
                if(i==2)
                    guess+="g";
                if(i==3)
                    guess+="y";
                guesses++;
                break;
            }
        }
 
        String codeSeg = code.substring(0,guesses);
        System.out.println("code "+code);
        System.out.println("codeseg "+codeSeg);
        System.out.println("guess "+guess);
        if(!codeSeg.equals(guess))
        {
            System.out.println("lose!");
            //You Lose
        }
        else
        {
            if(guesses==code.length())
            {
                System.out.println("next rnd!");
                guess = "";
                guesses = 0;
                play();
            }
        }
    }
 
    public static void main (String[]args)
    {
        new IanSays();
    }
}
import javax.swing.*;
import javax.swing.event.*;
import java.awt.*;
import java.awt.event.*;

public class IanSays extends JFrame implements ActionListener
{
    ImageIcon dark [] = {new ImageIcon("darkRed.png"),
                  new ImageIcon("darkBlue.png"), new ImageIcon("darkGreen.png"),
                                             new ImageIcon("darkYellow.png")};
    ImageIcon light [] = {new ImageIcon("red.png"),
                  new ImageIcon("blue.png"), new ImageIcon("green.png"),
                                             new ImageIcon("yellow.png")};
    JButton btns [] = {new JButton(dark[0]),new JButton(dark[1]),
                    new JButton(dark[2]), new JButton(dark[3])};
    
    Container cont;
    
    String code = "";
    
    String guess = "";
    
    int guesses = 0;
    
    public IanSays()
    {
        super("Ian Says");
        setSize(415,425);
        setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        setVisible(true);
        
        cont = getContentPane();
        cont.setLayout(null);
        
        for(int i = 0; i < btns.length; i++)
        {
            cont.add(btns[i]);
            btns[i].addActionListener(this);
            if(i<2)
            {
                btns[i].setBounds(i*200,0,200,200);
            }
            else
            {
                btns[i].setBounds((i-2)*200,200,200,200);
            }
        }
        play();
    }
    
    public void play()
    {
        System.out.println("play");
        for(int i = 0; i < code.length(); i++)
        {
            System.out.println(" in play loop");
            reset();
            
            cont.validate();
            
            try
            {
                Thread.sleep(250);
            }
            catch(Exception e){}
            
            char letter = code.toCharArray()[i];
            if(letter=='r')
            {
                System.out.println("    RED");
                btns[0].setIcon(light[0]);
            }
            if(letter=='b')
            {
                System.out.println("    BLUE");
                btns[1].setIcon(light[1]);
            }
            if(letter=='g')
            {
                System.out.println("    GREEN");
                btns[2].setIcon(light[2]);
            }
            if(letter=='y')
            {
                System.out.println("    YELLOW");
                btns[3].setIcon(light[3]);
            }
            
            cont.validate();

            try
            {
                Thread.sleep(250);
            }
            catch(Exception e){}
        }
        
        try
        {
            Thread.sleep(250);
        }
        catch(Exception e){}

        newColor();

        try
        {
            Thread.sleep(250);
        }
        catch(Exception e){}
        reset();
        System.out.println("    end of play");
    }
    
    public void newColor()
    {
        int rand = (int)(Math.random()*4);
        if(rand==0)
        {
            btns[rand].setIcon(light[rand]);
            code+="r";
        }
        if(rand==1)
        {
            btns[rand].setIcon(light[rand]);
            code+="b";
        }
        if(rand==2)
        {
            btns[rand].setIcon(light[rand]);
            code+="g";
        }
        if(rand==3)
        {
            btns[rand].setIcon(light[rand]);
            code+="y";
        }
        cont.validate();
    }
    
    public void reset()
    {
        for(int i = 0; i < btns.length; i++)
        {
            btns[i].setIcon(dark[i]);
        }
    }
    
    public void actionPerformed(ActionEvent e)
    {
        for(int i = 0; i < btns.length; i++)
        {
            if(e.getSource()==btns[i])
            {
                if(i==0)
                    guess+="r";
                if(i==1)
                    guess+="b";
                if(i==2)
                    guess+="g";
                if(i==3)
                    guess+="y";
                guesses++;
                break;
            }
        }
        
        String codeSeg = code.substring(0,guesses);
        System.out.println("code "+code);
        System.out.println("codeseg "+codeSeg);
        System.out.println("guess "+guess);
        if(!codeSeg.equals(guess))
        {
            System.out.println("lose!");
            //You Lose
        }
        else
        {
            if(guesses==code.length())
            {
                System.out.println("next rnd!");
                guess = "";
                guesses = 0;
                play();
            }
        }
    }
    
    public static void main (String[]args)
    {
        new IanSays();
    }
}

•

Join Date: Aug 2007

Posts: 794

Reputation: darkagn has a spectacular aura about

Solved Threads: 110

darkagn

Offline

Master Poster

Re: Changing the icons of JButtons

Aug 21st, 2007

Try using Util.Random class for your random generator. Something like:

 Help with Code Tags 
 java Syntax (Toggle Plain Text) 
java.util.Random randomGen = new java.util.Random(System.currentTimeMillis());
int rand = randomGen.nextInt(4);
java.util.Random randomGen = new java.util.Random(System.currentTimeMillis());
int rand = randomGen.nextInt(4);

will create a new seeded random generator every time. I think this should be more stable than using Math.random() but let us know if that's not the problem.

Last edited by darkagn; Aug 21st, 2007 at 8:54 pm.

•

Join Date: Aug 2004

Posts: 350

Reputation: Ghost is an unknown quantity at this point

Solved Threads: 2

Ghost

Offline

Posting Whiz

Re: Changing the icons of JButtons

Aug 21st, 2007

Thanks, but I'm pretty sure that is not the problem. I think the problem has to do with the JFrame or JButtons not updating... Thanks!

•

Join Date: Aug 2007

Posts: 794

Reputation: darkagn has a spectacular aura about

Solved Threads: 110

darkagn

Offline

Master Poster

Re: Changing the icons of JButtons

Aug 21st, 2007

Ah, sorry. I misunderstood what you meant. I think maybe you may need to call the repaint() method on the JFrame in the newColor() and reset() methods?

•

Join Date: Aug 2004

Posts: 350

Reputation: Ghost is an unknown quantity at this point

Solved Threads: 2

Ghost

Offline

Posting Whiz

Re: Changing the icons of JButtons

Aug 21st, 2007

I tried that, but it did not work. The odd thing is that it works on the first round... but not any of the others.
Thanks for your help!

•

Join Date: Aug 2007

Posts: 794

Reputation: darkagn has a spectacular aura about

Solved Threads: 110

darkagn

Offline

Master Poster

Re: Changing the icons of JButtons

Aug 21st, 2007

•

Originally Posted by Ghost

The odd thing is that it works on the first round... but not any of the others.

Do you mean that a full sequence of colours runs correctly the first time and then the next time the sequence is the same?

•

Join Date: Aug 2004

Posts: 350

Reputation: Ghost is an unknown quantity at this point

Solved Threads: 2

Ghost

Offline

Posting Whiz

Re: Changing the icons of JButtons

Aug 21st, 2007

The first time, there is only one blink in the sequence. The next time, there are two blinks... and so on.
Only the first blink works correctly

•

Join Date: Aug 2007

Posts: 794

Reputation: darkagn has a spectacular aura about

Solved Threads: 110

darkagn

Offline

Master Poster

Re: Changing the icons of JButtons

Aug 21st, 2007

I think you should call newColor() at the start of the play() method as opposed to the end?

•

Join Date: Aug 2004

Posts: 350

Reputation: Ghost is an unknown quantity at this point

Solved Threads: 2

Ghost

Offline

Posting Whiz

Re: Changing the icons of JButtons

Aug 21st, 2007

Actually, the game is played like this:
*The computer lights up 1 button.
*All buttons go dark
*The player clicks the button the computer lit
*The computer re-lights the original button, and then all buttons go dark, and then the computer lights a new button.
*All buttons go dark.
*The player clicks the previously lit buttons in the correct order.
The process repeats until the player messes up.

•

Join Date: Aug 2007

Posts: 794

Reputation: darkagn has a spectacular aura about

Solved Threads: 110

darkagn

Offline

Master Poster

Re: Changing the icons of JButtons

#10

Aug 22nd, 2007

Sorry Ghost, I was at work but now I'm at home and can look more closely at your code.

I'm thinking that your problem lies in the reading of the second (and subsequent possibly) characters to your code string. Instead of

 Help with Code Tags 
 java Syntax (Toggle Plain Text) 
char letter = code.toCharArray()[i];
char letter = code.toCharArray()[i];

try

 Help with Code Tags 
 java Syntax (Toggle Plain Text) 
char letter = code.charAt(i);
char letter = code.charAt(i);

I'm not sure if this will make any difference but I can't see anything wrong with the rest of your code. Does

 Help with Code Tags 
 java Syntax (Toggle Plain Text) 
cont.validate();
cont.validate();

repaint the buttons? Do they return to dark after the first round?

EDIT: I just compiled your code on my PC, it looks like the code follows what I press rather than the other way around. On the very first pass, code.length() = 0, so there is no code to guess. I pressed yellow, and the second pass had a code of 'y'.

Last edited by darkagn; Aug 22nd, 2007 at 9:34 am.