DaniWeb Forum Index > Web Development > PHP

what's wrong in this code?

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

« First

•

Join Date: Aug 2007

Posts: 4

Reputation: mikewzp is an unknown quantity at this point

Solved Threads: 0

mikewzp

Offline

Newbie Poster

Re: what's wrong in this code?

#21

Aug 23rd, 2007

Well, I tested your php code in my computer. After i
mysql> create table guestbook
-> (name varchar(150),
-> location varchar(150),
-> email varchar(150),
-> url varchar(150),
-> comments text);
Query OK, 0 rows affected (0.01 sec)
It works. like:
View my GuestBook!!
Name:a
Location:a
Email:a
URL:a
Comments:b

So your code no problem, but i don't know whether your db is prepared or not.
You said sign.php and create_entry.php worked, so you can check in your db.
Use : mysql> use guestbook;
mysql> select * from guestbook;
To see whether there are records.
Mine has recoreds:
mysql> select * from guestbook;
+------+----------+-------+------+----------+
| name | location | email | url | comments |
+------+----------+-------+------+----------+
| a | a | a | a | b |
| w | w | w | e | s |
| h | h | h | h | h |
+------+----------+-------+------+----------+
3 rows in set (0.01 sec)

•

Join Date: Sep 2005

Posts: 1,075

Reputation: digital-ether is just really nice

Solved Threads: 66

digital-ether digital-ether is offline

Offline

Veteran Poster

Re: what's wrong in this code?

#22

Aug 24th, 2007

•

Originally Posted by Nichito

here are all my codes:

dbconnect.php
Help with Code Tags

php Syntax (Toggle Plain Text)
<?php
mysql_connect("localhost","nobody","ydobon")
   or die("<h3>could not connect to MySQL</h3>\n");
mysql_select_db("guestbook")
   or die("<h3>could not select database 'guestbook'</h3>\n");
?>
<?php mysql_connect("localhost","nobody","ydobon") or die("<h3>could not connect to MySQL</h3>\n"); mysql_select_db("guestbook") or die("<h3>could not select database 'guestbook'</h3>\n"); ?>
sign.php
Help with Code Tags

php Syntax (Toggle Plain Text)
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>
 
 <BODY>
  <h2>Sign my guestbook!</h2>
  <form method="post" action="create_entry.php">
 
     <b>Name:</b>
     <input type="text" size="40" name="name">
     <br>
     <b>Location:</b>
     <input type="text" size="40" name="location">
     <br>
     <b>Email:</b>
     <input type="text" size="40" name="email">
     <br>
     <b>Home Page URL:</b>
     <input type="text" size="40" name="url">
     <br>
     <b>Comments:</b>
     <textarea name="comments" cols="40" rows="4"
     wrap="virtualv"></textarea>
     <br>
 
     <input type="submit" name="submit" value="Sign!">
     <input type="reset" name="reset" value="Start Over">
 
     </form>
 </BODY>
</HTML>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML> <HEAD> <TITLE> New Document </TITLE> <META NAME="Generator" CONTENT="EditPlus"> <META NAME="Author" CONTENT=""> <META NAME="Keywords" CONTENT=""> <META NAME="Description" CONTENT=""> </HEAD> <BODY> <h2>Sign my guestbook!</h2> <form method="post" action="create_entry.php"> <b>Name:</b> <input type="text" size="40" name="name"> <br> <b>Location:</b> <input type="text" size="40" name="location"> <br> <b>Email:</b> <input type="text" size="40" name="email"> <br> <b>Home Page URL:</b> <input type="text" size="40" name="url"> <br> <b>Comments:</b> <textarea name="comments" cols="40" rows="4" wrap="virtualv"></textarea> <br> <input type="submit" name="submit" value="Sign!"> <input type="reset" name="reset" value="Start Over"> </form> </BODY> </HTML>
create_entry.php
Help with Code Tags

php Syntax (Toggle Plain Text)
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>
 
 <BODY>
  <?php
  include("dbconnect.php");
 
  if ($_REQUEST["submit"]=="Sign!")
  {
     $query="insert into guestbook(name,location,email,url,comments) values ('"
            .$_REQUEST["name"]
            ."', '"
            .$_REQUEST["location"]
            ."', '"
            .$_REQUEST["email"]
            ."', '"
            .$_REQUEST["url"]
            ."', '"
            .$_REQUEST["comments"]
            ."') "
     ;
     mysql_query($query);
 ?>
 <h2>Thanks!!</h2>
 <h2><a href="view.php">View my GuestBook!!</a></h2>
 <?php
 }
 else
 {
    include("sign.php");
 }
 ?>
 </BODY>
</HTML>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML> <HEAD> <TITLE> New Document </TITLE> <META NAME="Generator" CONTENT="EditPlus"> <META NAME="Author" CONTENT=""> <META NAME="Keywords" CONTENT=""> <META NAME="Description" CONTENT=""> </HEAD> <BODY> <?php include("dbconnect.php"); if ($_REQUEST["submit"]=="Sign!") { $query="insert into guestbook(name,location,email,url,comments) values ('" .$_REQUEST["name"] ."', '" .$_REQUEST["location"] ."', '" .$_REQUEST["email"] ."', '" .$_REQUEST["url"] ."', '" .$_REQUEST["comments"] ."') " ; mysql_query($query); ?> <h2>Thanks!!</h2> <h2><a href="view.php">View my GuestBook!!</a></h2> <?php } else { include("sign.php"); } ?> </BODY> </HTML>
view.php
Help with Code Tags

php Syntax (Toggle Plain Text)
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML>
 <HEAD>
  <TITLE> New Document </TITLE>
  <META NAME="Generator" CONTENT="EditPlus">
  <META NAME="Author" CONTENT="">
  <META NAME="Keywords" CONTENT="">
  <META NAME="Description" CONTENT="">
 </HEAD>
 
 <BODY>
  <?php include("dbconnect.php") ?>
 
  <h2>View my GuestBook!!</h2>
 
  <?php
 
  $result = mysql_query("select * from guestbook")
     or die(mysql_error());
  while ($row = mysql_fetch_array($result))
  {
     echo "Name:";
     echo $row["name"];
     echo "<br>\n";
     echo "<b>Location:</b>";
     echo $row["location"];
     echo "<br>\n";
     echo "<b>Email:</b>";
     echo $row["email"];
     echo "<br>\n";
     echo "<b>URL:</b>";
     echo $row["url"];
     echo "<br>\n";
     echo "<b>Comments:</b>";
     echo $row["comments"];
     echo "<br>\n";
     echo "<br>\n";
     echo "<br>\n";
  }
  mysql_free_result($result);
  ?>
 
  <h2><a href="sign.php">Sign my GuestBook</a></h2>
 
 </BODY>
</HTML>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML> <HEAD> <TITLE> New Document </TITLE> <META NAME="Generator" CONTENT="EditPlus"> <META NAME="Author" CONTENT=""> <META NAME="Keywords" CONTENT=""> <META NAME="Description" CONTENT=""> </HEAD> <BODY> <?php include("dbconnect.php") ?> <h2>View my GuestBook!!</h2> <?php $result = mysql_query("select * from guestbook") or die(mysql_error()); while ($row = mysql_fetch_array($result)) { echo "Name:"; echo $row["name"]; echo "<br>\n"; echo "<b>Location:</b>"; echo $row["location"]; echo "<br>\n"; echo "<b>Email:</b>"; echo $row["email"]; echo "<br>\n"; echo "<b>URL:</b>"; echo $row["url"]; echo "<br>\n"; echo "<b>Comments:</b>"; echo $row["comments"]; echo "<br>\n"; echo "<br>\n"; echo "<br>\n"; } mysql_free_result($result); ?> <h2><a href="sign.php">Sign my GuestBook</a></h2> </BODY> </HTML>
everything works just fine until when it gets to view.php... dunno what the problem is...

Could you post the HTML Source of the output from view.php.

Also, place the following above the page:

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
<?php 
 
error_reporting(E_ALL);
display_errors(true);
 
?>
<?php 

error_reporting(E_ALL);
display_errors(true);

?>

Or the equivalent in your PHP.ini.

That way any warnings, notices, etc. will be printed.

www.fijiwebdesign.com - web design and development and fun
Cpanel Email - Let users Register email accounts on your website upon registration
Ajax Chat - Fully browser based chat!

•

Join Date: Dec 2004

Posts: 196

Reputation: mikeSQL is an unknown quantity at this point

Solved Threads: 3

mikeSQL

Offline

Junior Poster

Re: what's wrong in this code?

#23

Aug 24th, 2007

•

Originally Posted by Nichito

so, i started at php and i'm doing some exercises from the book, but when i type this code into my "view.php", the output is all wrong...
Help with Code Tags

php Syntax (Toggle Plain Text)
  <?php include("dbconnect.php") ?>
 
  <h2>View my GuestBook!!</h2>
 
  <?php
 
  $result=mysql_query("select * from guestbook")
     or die(mysql_error());
  while ($row=mysql_fetch_array($result))
  {
     echo "<b>Name:</b>";
     echo $row["name"];
     echo "<br>\n";
     echo "<b>Location:</b>";
     echo $row["location"];
     echo "<br>\n";
     echo "<b>Email:</b>";
     echo $row["email"];
     echo "<br>\n";
     echo "<b>URL:</b>";
     echo $row["url"];
     echo "<br>\n";
     echo "<b>Comments:</b>";
     echo $row["comments"];
     echo "<br>\n";
     echo "<br>\n";
     echo "<br>\n";
  }
  mysql_free_result($reslut);
  ?>
<?php include("dbconnect.php") ?> <h2>View my GuestBook!!</h2> <?php $result=mysql_query("select * from guestbook") or die(mysql_error()); while ($row=mysql_fetch_array($result)) { echo "<b>Name:</b>"; echo $row["name"]; echo "<br>\n"; echo "<b>Location:</b>"; echo $row["location"]; echo "<br>\n"; echo "<b>Email:</b>"; echo $row["email"]; echo "<br>\n"; echo "<b>URL:</b>"; echo $row["url"]; echo "<br>\n"; echo "<b>Comments:</b>"; echo $row["comments"]; echo "<br>\n"; echo "<br>\n"; echo "<br>\n"; } mysql_free_result($reslut); ?>
the output is like this:

Everything looks like its good to me except what Mitko said. I belive he may be right if else. The codes look good, I would check or uninstall/reinstall xampp. digital-ether is right also.

Last edited by mikeSQL; Aug 24th, 2007 at 5:07 pm.

dynastyCODERS#1 when it comes to Programming Tutorials, Database designs and discussions, Operating Systems, you name it, check us out and drop us a line to tell us your opinions on any and everything in mind!;)

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

Re: what's wrong in this code?

#24

Aug 25th, 2007

i think ther might be an error in XAMPP installation, since it doesn't seem to recognize the echo command... i'll try uninstalling and installing it again... (the other two worked well, since there were no "echo-es" in them...

-->sometimes i wanna take my toaster in a bath<--

•

Join Date: Sep 2005

Posts: 1,075

Reputation: digital-ether is just really nice

Solved Threads: 66

digital-ether digital-ether is offline

Offline

Veteran Poster

Re: what's wrong in this code?

#25

Aug 25th, 2007

•

Originally Posted by Nichito

i think ther might be an error in XAMPP installation, since it doesn't seem to recognize the echo command... i'll try uninstalling and installing it again... (the other two worked well, since there were no "echo-es" in them...

I'd recommend testing any theories individually before going through the whole uninstall/install process.

Just try a PHP file with:

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
<?php echo 'hello'; ?>
<?php echo 'hello'; ?>

see if echo behaves funny.. etc.

BTW: Nichito, your avatar is scary! lol.

www.fijiwebdesign.com - web design and development and fun
Cpanel Email - Let users Register email accounts on your website upon registration
Ajax Chat - Fully browser based chat!

•

Join Date: Aug 2007

Posts: 52

Reputation: JeniF is an unknown quantity at this point

Solved Threads: 5

JeniF

Offline

Junior Poster in Training

Re: what's wrong in this code?

#26

Aug 25th, 2007

try escaping the '' like so:
\"
and in your record set use single quotes like so:
$row['name']

Last edited by JeniF; Aug 25th, 2007 at 4:54 pm.

I keep hitting "escape", but I'm still here!!!!
:}

•

Join Date: Mar 2007

Posts: 1,429

Reputation: Nichito is an unknown quantity at this point

Solved Threads: 29

Nichito

Offline

Nearly a Posting Virtuoso

Re: what's wrong in this code?

#27

Aug 26th, 2007

i tried the <?php echo "hello" ?>command, and the output was:

•

so i guess that confirms my supposition...

though, i reinstalled in succesfully and it still returns the same output... i even tried other codes consisting in echoes and nothing happened...

-->sometimes i wanna take my toaster in a bath<--