DaniWeb Forum Index > Software Development > C++

C++ RSS

Object compiler errors

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

Last »

•

Join Date: Dec 2007

Posts: 226

Reputation: henpecked1 is an unknown quantity at this point

Solved Threads: 1

henpecked1 henpecked1 is offline

Offline

Posting Whiz in Training

Re: Object compiler errors

#11

Mar 21st, 2008

one die header:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#ifndef ONEDIE_H
#define ONEDIE_H
 
class onedie
{
	public:
		void rollit();
		int getroll();
 
	private:
		int result;
};
 
#endif
#ifndef ONEDIE_H
#define ONEDIE_H

class onedie
{
	public:
		void rollit();
		int getroll();

	private:
		int result;
};

#endif

threedice header:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#ifndef THREEDICE_H
#define THREEDICE_H
 
class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
 
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};
 
#endif
#ifndef THREEDICE_H
#define THREEDICE_H

class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
		
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};

#endif

noclass header:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#ifndef NOCLASS_H
#define NOCLASS_H
 
void statistics (int rolls[],int rollsize, int allresults[]);  //prototype given by instructor
 
//display function here
 
#endif
#ifndef NOCLASS_H
#define NOCLASS_H

void statistics (int rolls[],int rollsize, int allresults[]);  //prototype given by instructor

//display function here

#endif

onedie.cpp

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "onedie.h"
#include <iostream>
#include <cstdlib>
#include <ctime>
 
using namespace std;
 
 
void onedie::rollit()
{
	srand(time_t(NULL));
	result= 1 + rand() % 6;
}
 
int onedie::getroll()
{
	return result;
}
#include "onedie.h"
#include <iostream>
#include <cstdlib>
#include <ctime>

using namespace std;


void onedie::rollit()
{
	srand(time_t(NULL));
	result= 1 + rand() % 6;
}

int onedie::getroll()
{
	return result;
}

threedice.cpp

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "threedice.h"
#include <iostream>
 
using namespace std;
 
void threedice::rollem()
{
	die1.rollit();
	die2.rollit();
	die3.rollit();
}
 
int threedice::getsumFaces()
{
	return die1.getroll()+die2.getroll()+die3.getroll();
}
#include "threedice.h"
#include <iostream>

using namespace std;

void threedice::rollem()
{
	die1.rollit();
	die2.rollit();
	die3.rollit();
}

int threedice::getsumFaces()
{
	return die1.getroll()+die2.getroll()+die3.getroll();
}

noclass.cpp

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "noclass.h"
#include "threedice.h"
#include <iostream>
 
using namespace std;
 
void statistics (int rolls[], int rollsize,int allresults[])
{
	threedice tryerluck;
	rollsize=200;
	rolls[rollsize];
	allresults[16];
 
	for(int i=0;i<200;i++)
	{
		tryerluck.rollem();
		rolls[i]= tryerluck.getsumFaces();
	}
}
#include "noclass.h"
#include "threedice.h"
#include <iostream>

using namespace std;

void statistics (int rolls[], int rollsize,int allresults[])
{
	threedice tryerluck;
	rollsize=200;
	rolls[rollsize];
	allresults[16];

	for(int i=0;i<200;i++)
	{
		tryerluck.rollem();
		rolls[i]= tryerluck.getsumFaces();
	}
}

Okay, that's all of it. Where did I screw up please?

•

Join Date: Nov 2007

Posts: 978

Reputation: mitrmkar is just really nice

Solved Threads: 208

mitrmkar

Offline

Posting Shark

Re: Object compiler errors

#12

Mar 21st, 2008

In your THREEDICE.H add the following forward declaration

Help with Code Tags

(Toggle Plain Text)

#define THREEDICE_H
class onedie;
class threedice
...

Then the statistics() function is a bit odd, if you think it will be called from e.g. main(),
it probably should look like

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
int main()
{
    const int roll_count = 200;
    int rolls[roll_count] = {0};
    // I'm not actually sure what the allresults should be
    int allresults[roll_count] = {0}; 
    // Then you can make the statistics() call ...
    statistics (rolls, roll_count, allresults);
    return 0;
}
 
void statistics (int rolls[], int count, int allresults[])
{
    threedice tryerluck;
    for(int i=0;i<count;i++)
    {
        tryerluck.rollem();
        rolls[i]= tryerluck.getsumFaces();
    }
 
    // and maybe do something here with the allresults too    
}
int main()
{
    const int roll_count = 200;
    int rolls[roll_count] = {0};
    // I'm not actually sure what the allresults should be
    int allresults[roll_count] = {0}; 
    // Then you can make the statistics() call ...
    statistics (rolls, roll_count, allresults);
    return 0;
}

void statistics (int rolls[], int count, int allresults[])
{
    threedice tryerluck;
    for(int i=0;i<count;i++)
    {
        tryerluck.rollem();
        rolls[i]= tryerluck.getsumFaces();
    }

    // and maybe do something here with the allresults too    
}

•

Join Date: Dec 2007

Posts: 226

Reputation: henpecked1 is an unknown quantity at this point

Solved Threads: 1

henpecked1 henpecked1 is offline

Offline

Posting Whiz in Training

Re: Object compiler errors

#13

Mar 21st, 2008

I put the class onedie; in the threedice header and it says undefined class...did I leave something out or have I incorrectly defined it in onedie.cpp?

I was indeed going to call the statistics function in main and there will be more to it. After the for loop, I have to make another one (I think) with a switch to fill the allresults with the spread of results between 3 and 18.

update:
I changed it from class onedie; to #include onedie.h and now it compiles, is that correct?

Last edited by henpecked1; Mar 21st, 2008 at 10:40 pm.

•

Join Date: Aug 2005

Posts: 15,442

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1474

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: Object compiler errors

#14

Mar 21st, 2008

I got it to compile without error. Problem seems to be here

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#ifndef THREEDICE_H
#define THREEDICE_H
 
#include "onedie.h" // <<<<<<<<<<<<<<<<<< ADD THIS LINE
 
class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
 
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};
 
#endif
#ifndef THREEDICE_H
#define THREEDICE_H

#include "onedie.h" // <<<<<<<<<<<<<<<<<< ADD THIS LINE

class threedice
{
	public:
		void rollem();  	  
		int getsumFaces();
		
	private:
		onedie die1;
		onedie die2;
		onedie die3;
};

#endif

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Dec 2007

Posts: 226

Reputation: henpecked1 is an unknown quantity at this point

Solved Threads: 1

henpecked1 henpecked1 is offline

Offline

Posting Whiz in Training

Re: Object compiler errors

#15

Mar 21st, 2008

that's what I did...ooo...I almost figured something out on my own...lol.

Okay, now I have to try the loop to fill allresults. I'm thinking a for loop with a switch, does that sound right....or at least like it would work?

•

Join Date: Dec 2007

Posts: 226

Reputation: henpecked1 is an unknown quantity at this point

Solved Threads: 1

henpecked1 henpecked1 is offline

Offline

Posting Whiz in Training

Re: Object compiler errors

#16

Mar 21st, 2008

Okay, the switch isn't working, I'm getting a bunch of illegal cases. Do I have the wrong condition?

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
 
for (int i=0;i<rollsize;i++)
{
        switch (rolls[i])
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        case 5:allresults[2] = allresults [2]+1; break;
        case 6:allresults[3] = allresults [3]+1; break;
        case 7:allresults[4] = allresults [4]+1; break;
        case 8:allresults[5] = allresults [5]+1; break;
        case 9:allresults[6] = allresults [6]+1; break;
        case 10:allresults[7] = allresults [7]+1; break;
        case 11:allresults[8] = allresults [8]+1; break;
        case 12:allresults[9] = allresults [9]+1; break;
        case 13:allresults[10] = allresults [10]+1; break;
        case 14:allresults[11] = allresults [11]+1; break;
        case 15:allresults[12] = allresults [12]+1; break;
        case 16:allresults[13] = allresults [13]+1; break;
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
}
for (int i=0;i<rollsize;i++)
{
        switch (rolls[i])
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        case 5:allresults[2] = allresults [2]+1; break;
        case 6:allresults[3] = allresults [3]+1; break;
        case 7:allresults[4] = allresults [4]+1; break;
        case 8:allresults[5] = allresults [5]+1; break;
        case 9:allresults[6] = allresults [6]+1; break;
        case 10:allresults[7] = allresults [7]+1; break;
        case 11:allresults[8] = allresults [8]+1; break;
        case 12:allresults[9] = allresults [9]+1; break;
        case 13:allresults[10] = allresults [10]+1; break;
        case 14:allresults[11] = allresults [11]+1; break;
        case 15:allresults[12] = allresults [12]+1; break;
        case 16:allresults[13] = allresults [13]+1; break;
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
}

Last edited by WolfPack; Mar 21st, 2008 at 11:45 pm. Reason: Corrected indenting.

•

Join Date: Jun 2005

Posts: 1,496

Reputation: WolfPack has a spectacular aura about

Solved Threads: 104

WolfPack

Offline

Mentally Challenged Mod.

Re: Object compiler errors

#17

Mar 21st, 2008

Either you didn't know that you should use braces, or you forgot.

 Help with Code Tags 
 cpp Syntax (Toggle Plain Text) 
for (int i=0;i<rollsize;i++)
{
    switch (rolls[i])
    { // Forgot this
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        /* ......... */ 
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
    } // And this
}
for (int i=0;i<rollsize;i++)
{
    switch (rolls[i])
    { // Forgot this
        case 3:allresults[0] = allresults [0]+1; break;
        case 4:allresults[1] = allresults [1]+1; break;
        /* ......... */ 
        case 17:allresults[14] = allresults [14]+1; break;
        case 18:allresults[15] = allresults [15]+1; break;
    } // And this
}

Last edited by WolfPack; Mar 21st, 2008 at 11:50 pm. Reason: Corrected indenting.

バルサミコ酢やっぱいらへんで

•

Join Date: Dec 2007

Posts: 226

Reputation: henpecked1 is an unknown quantity at this point

Solved Threads: 1

henpecked1 henpecked1 is offline

Offline

Posting Whiz in Training

Re: Object compiler errors

#18

Mar 21st, 2008

okay, I feel stupid now

•

Join Date: Aug 2005

Posts: 15,442

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1474

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: Object compiler errors

#19

Mar 21st, 2008

you don't need that switch statement at all

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
for (int i=0;i<rollsize;i++)
{
        allresults[i] = allresults [i]+1;
}
for (int i=0;i<rollsize;i++)
{
        allresults[i] = allresults [i]+1;
}

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Dec 2007

Posts: 226

Reputation: henpecked1 is an unknown quantity at this point

Solved Threads: 1

henpecked1 henpecked1 is offline

Offline

Posting Whiz in Training

Re: Object compiler errors

#20

Mar 22nd, 2008

AD, does that increment the different elements of the results array so you know which numbers are rolled how many times? I used the switch because that's what the prof has in the lesson plan, but I'm just as keen on keeping things simple.

Okay, main looks like it's outputting a memory address instead of a bunch of dice rolls. Should I just move that statistics and display functions to main instead of calling them? Or I might have screwed up the display function....it's supposed to print each element of the allresults array.

Here is main:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include "threedice.h"
#include "noclass.h"
#include <iostream>
 
using namespace std;
 
int main ()
{
	const int rollsize = 200;
    int rolls[rollsize] = {0};
	int allresults[16]={0};
 
 
	statistics(rolls,rollsize,allresults);
	displayResults(allresults);
 
 
	return 0;
}
#include "threedice.h"
#include "noclass.h"
#include <iostream>

using namespace std;

int main ()
{
	const int rollsize = 200;
    int rolls[rollsize] = {0};
	int allresults[16]={0};


	statistics(rolls,rollsize,allresults);
	displayResults(allresults);


	return 0;
}

The display function

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
void displayResults(int allresults[])
	{
		cout << allresults << endl;
	}
void displayResults(int allresults[])
	{
		cout << allresults << endl;
	}