I think my favourite game of all time would have to be Monkey Island. I used to have an old Amiga 500+ (what a machine that was!) and I adored that game when I was a kid. I guess a lot of my love of that game is sentimental too, because it marked the beginnings and ends of a lot of things for me. Plus its funny as hell despite the fact that its all text and no voices hehehe.
Other than that, my best games list is as follows (in no particular order):
Hitman I, II & III
Soldier of Fortune I & II
Doom (the early games)
Discworld I, II & III
Mystery of the Druids
Beneath a Steel Sky
Monkey Island II, III & IV
Broken Sword I & II
Grim Fandango
R-Type
Street Fighter II (The old arcade machine version)
I think that'll do for now

As you can probably tell I'm a big fan of Point 'n Click adventures! hehehe