Please support our Pascal and Delphi advertiser: Programming Forums
Views: 1323 | Replies: 6 | Solved
 |
•
•
Join Date: Dec 2007
Posts: 7
Reputation: 
Rep Power: 0
Solved Threads: 0
Newbie Poster
Hello, guys!
I have to generate 10 different numbers.
What I do is to store the generated numbers in array.
Before that I check the array for duplicates.
It compiles, but I get some duplicates.
Thanks in advance for any help.
I have to generate 10 different numbers.
What I do is to store the generated numbers in array.
Before that I check the array for duplicates.
It compiles, but I get some duplicates.
Thanks in advance for any help.
Pascal Syntax (Toggle Plain Text)
Last edited by simps0n : Apr 12th, 2008 at 7:50 am.
•
•
Join Date: Feb 2008
Posts: 11
Reputation:
Rep Power: 1
Solved Threads: 1
Newbie Poster
The problem is that, apparently, what you really want is a permutation - it looks like you want only 10 random numbers between 1 and 10. There are any number of ways to do this. One is to go to jsoftware.com, download and install J, then type "1+10?10" in a session.
However, since this is a "Pascal and Delphi" forum, the answer will be substantially more complicated than this.
Here's my guess, allowing for my lack of Pascal knowledge: initialize the array of numbers 1 to 10, then loop through, say 10 times (this is probably overkill), swapping numbers randomly, something like this code fragment:
for i := 1 to 10 do
begin
number[i] = i;
end; (for loop)
for i := 1 to 10 do
begin
ix1 := 1+random(10);
ix2 := 1+random(10);
svnum := number[ix1];
number[ix1] := number[ix2];
number[ix2] := svnum;
end; (for loop)
Since you're swapping (roughly) 2 each time, you could shorten the loop to as little as 5 - somewhere between 5 and 10 would be optimal.
However, since this is a "Pascal and Delphi" forum, the answer will be substantially more complicated than this.
Here's my guess, allowing for my lack of Pascal knowledge: initialize the array of numbers 1 to 10, then loop through, say 10 times (this is probably overkill), swapping numbers randomly, something like this code fragment:
for i := 1 to 10 do
begin
number[i] = i;
end; (for loop)
for i := 1 to 10 do
begin
ix1 := 1+random(10);
ix2 := 1+random(10);
svnum := number[ix1];
number[ix1] := number[ix2];
number[ix2] := svnum;
end; (for loop)
Since you're swapping (roughly) 2 each time, you could shorten the loop to as little as 5 - somewhere between 5 and 10 would be optimal.
•
•
Join Date: Jan 2008
Location: definately not on moon :P
Posts: 65
Reputation: 
Rep Power: 0
Solved Threads: 4
Junior Poster in Training
SysUtils is a turbo pascal unit?
•
•
Join Date: Jun 2006
Location: Blumenau, Brazil
Posts: 71
Reputation:
Rep Power: 3
Solved Threads: 4
Junior Poster in Training
•
•
•
•
Originally Posted by simps0n 
It compiles, but I get some duplicates.
Hi simps0n,
Without taking in consideration any others questions, You must to call randomize procedure just an once time in Your project (take a look in help about it).
So, put the call to this procedure before while .. do scope, like this:
delphi Syntax (Toggle Plain Text)
Bye
"It always has, at least, two ways to make one same thing. Exactly that they are certain and wrong"(Micheus)
Brazil - Blumenau
Brazil - Blumenau
•
•
Join Date: Oct 2007
Location: South Africa
Posts: 60
Reputation:
Rep Power: 2
Solved Threads: 7
Junior Poster in Training
What is also happening in your code, is that when you find a duplicate, you are setting included to True, but are not exiting your loop and the next number in the array is not a duplicate, so included is set back to false.
You just add an additional line to exit the loop when included is set to true.
Just a bit about the begin ... end in your code -
You only need to wrap the commands in those if there is more than one command to be performed - in the above example, if the test is true you are going to perform 2 or more commands, so you need the begin ... end. If it is false, you are running only one command, so you don't need them, so the code could look like this:
You just add an additional line to exit the loop when included is set to true.
// Checking array for duplicates.
for i := 1 to 10 do
begin
if (number[i] = a) or (a=0) then
begin
included := true;
exit;
end
else
begin
included := false;
end; {if loop}
end; {for loop}Just a bit about the begin ... end in your code -
You only need to wrap the commands in those if there is more than one command to be performed - in the above example, if the test is true you are going to perform 2 or more commands, so you need the begin ... end. If it is false, you are running only one command, so you don't need them, so the code could look like this:
// Checking array for duplicates.
for i := 1 to 10 do
begin
if (number[i] = a) or (a=0) then
begin
included := true;
exit;
end
else included := false; {end if loop}
end; {for loop} •
•
Join Date: Dec 2007
Posts: 7
Reputation:
Rep Power: 0
Solved Threads: 0
Newbie Poster
Thank you all, guys!
Really appreciated.
Really appreciated.
•
•
Join Date: Feb 2008
Posts: 11
Reputation:
Rep Power: 1
Solved Threads: 1
Newbie Poster
•
•
•
•
Originally Posted by simps0n
Thank you all, guys!
Really appreciated.
I hope you noticed, though no one commented on it, that the suggestion I made scales much better than the original algorithm. That is, if you're doing this for 10,000 numbers instead of 10, the original algorithm will take about a million times as long versus about a thousand times as long for what I proposed.
|
•
•
•
•
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
Linear Mode
