•
•
•
•
What is DaniWeb IT Discussion Community?
You're currently browsing the C section within the Software Development category of DaniWeb, a massive community of 363,388 software developers, web developers, Internet marketers, and tech gurus who are all enthusiastic about making contacts, networking, and learning from each other. In fact, there are 2,786 IT professionals currently interacting right now! Registration is free, only takes a minute and lets you enjoy all of the interactive features of the site.
Please support our C advertiser:
Views: 389 | Replies: 8 | Solved
 |
•
•
Join Date: Aug 2007
Posts: 20
Reputation: 
Rep Power: 0
Solved Threads: 0
Newbie Poster
#include<stdio.h>
int main()
{
int i ,j ,a[5];
for(i=0;i<=4;i++)
{
printf("\n\tEnter the %dst value of the array: ", i+1);
scanf("%d", &a[i]);
}
j = a[0];
printf("\n\tOriginal array entered by the user: ");
for(i=0;i<=4;i++)
{
printf(" %d ", a[i]);
if(a[i]<a[i+1])
{
j = a[i+1];
}
}
printf("\n\n\tGreatest no. from the array: %d", j);
getch();
return 0;
}according to me there is no problem in this code.......
but its printing some wierd values again n again.....
plz...help me out here....
My Wierd Output:
Enter the 1st value of the array: 56
Enter the 2st value of the array: 35
Enter the 3st value of the array: 26
Enter the 4st value of the array: 15
Enter the 5st value of the array: 24
Original array entered by the user: 56 35 26 15 24
Greatest no. from the array: 4007048
Last edited by web_master : May 9th, 2008 at 2:17 pm.
•
•
Join Date: Dec 2005
Posts: 2,919
Reputation: 
Rep Power: 18
Solved Threads: 321
Your i+1 means you're reading off the end of the array.
Also, finding the maximum is a lot simpler than this.
Also, finding the maximum is a lot simpler than this.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
•
•
Join Date: May 2008
Posts: 3
Reputation:
Rep Power: 0
Solved Threads: 1
Newbie Poster
your value of j= [i+1] reads the value of the a[5] in the last cycle which does not exist at all...
•
•
Join Date: Aug 2007
Posts: 20
Reputation:
Rep Power: 0
Solved Threads: 0
Newbie Poster
I solved it myself......
the code is:
the loop that was comparing the numbers was looping one extra time so i limited it to 4 times (i<=3) instead of 5(i.e. the array size).....
now it works fine......
and i dont see a better way of doing it......maybe there is a easier way.......
the code is:
#include<stdio.h>
int main()
{
int i ,j ,a[5];
for(i=0;i<=4;i++)
{
printf("\n\tEnter the %dst value of the array: ", i+1);
scanf("%d", &a[i]);
}
j = a[0];
printf("\n\tOriginal array entered by the user: ");
for(i=0;i<=3;i++)
{
printf(" %d ", a[i]);
if(a[i]<a[i+1])
{
j = a[i+1];
}
}
printf("\n\n\tGreatest no. from the array: %d", j);
getch();
return 0;
}the loop that was comparing the numbers was looping one extra time so i limited it to 4 times (i<=3) instead of 5(i.e. the array size).....
now it works fine......
and i dont see a better way of doing it......maybe there is a easier way.......
•
•
Join Date: Feb 2008
Location: Seattle
Posts: 666
Reputation:
Rep Power: 4
Solved Threads: 42
Practically a Master Poster
good thing about shotguns is that if you're close enough you can still hit the target even if your aim is lousy.
I drink your milkshake.
•
•
Join Date: May 2008
Posts: 2
Reputation:
Rep Power: 0
Solved Threads: 0
Newbie Poster
Change the prog as follows
#include<stdio.h>
#include<conio.h>
int main()
{
int i ,j ,a[5];
for(i=0;i<=4;i++)
{
printf("\n\tEnter the %dst value of the array: ", i+1);
scanf("%d", &a[i]);
}
j = a[0];
printf("\n\tOriginal array entered by the user: ");
for(i=0;i<=4;i++)
{
printf(" %d ", a[i]);
if(j<a[i])
{
j = a[i];
}
}
printf("\n\n\tGreatest no. from the array: %d", j);
getch();
return 0;
} Last edited by ~s.o.s~ : May 12th, 2008 at 1:27 pm. Reason: Added code tags, learn to use them.
•
•
Join Date: May 2008
Posts: 2
Reputation:
Rep Power: 0
Solved Threads: 0
Newbie Poster
Your program still contain serious logical error.give data like 120,12,13,45,90 and check with your prog.
•
•
•
•
Originally Posted by web_master 
I solved it myself......
the code is:
#include<stdio.h> int main() { int i ,j ,a[5]; for(i=0;i<=4;i++) { printf("\n\tEnter the %dst value of the array: ", i+1); scanf("%d", &a[i]); } j = a[0]; printf("\n\tOriginal array entered by the user: "); for(i=0;i<=3;i++) { printf(" %d ", a[i]); if(a[i]<a[i+1]) { j = a[i+1]; } } printf("\n\n\tGreatest no. from the array: %d", j); getch(); return 0; }
the loop that was comparing the numbers was looping one extra time so i limited it to 4 times (i<=3) instead of 5(i.e. the array size).....
now it works fine......
and i dont see a better way of doing it......maybe there is a easier way.......
•
•
Join Date: Feb 2008
Location: Seattle
Posts: 666
Reputation:
Rep Power: 4
Solved Threads: 42
Practically a Master Poster
since he's happy with his own "solution", i think it's safe to say he's not looking to improve/fix it -- hence, my earlier shotgun metaphor.
theres another metaphor that applies here, it starts with "you can lead a horse to water..."
.
theres another metaphor that applies here, it starts with "you can lead a horse to water..."
.
Last edited by jephthah : May 13th, 2008 at 3:23 am.
I drink your milkshake.
•
•
Join Date: Nov 2007
Posts: 18
Reputation:
Rep Power: 1
Solved Threads: 0
Newbie Poster
•
•
•
•
Originally Posted by web_master
#include<stdio.h> int main() { int i ,j ,a[5]; for(i=0;i<=4;i++) { printf("\n\tEnter the %dst value of the array: ", i+1); scanf("%d", &a[i]); } j = a[0]; printf("\n\tOriginal array entered by the user: "); for(i=0;i<=4;i++) { printf(" %d ", a[i]); if(a[i]<a[i+1]) { j = a[i+1]; } } printf("\n\n\tGreatest no. from the array: %d", j); getch(); return 0; }
according to me there is no problem in this code.......
but its printing some wierd values again n again.....
plz...help me out here....
My Wierd Output:
Enter the 1st value of the array: 56
Enter the 2st value of the array: 35
Enter the 3st value of the array: 26
Enter the 4st value of the array: 15
Enter the 5st value of the array: 24
Original array entered by the user: 56 35 26 15 24
Greatest no. from the array: 4007048
Hi...
U were not comparing all the elements. code started with comparing a single element with others. Following code will help u out.
cplusplus Syntax (Toggle Plain Text)
Last edited by Narue : May 16th, 2008 at 12:41 pm. Reason: Added code tags
|
•
•
•
•
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
•
•
•
•
•
•
•
•
DaniWeb C Marketplace
Linear Mode
Other Threads in the C Forum
- Previous Thread: Hiding Invisible charactors in Visual Studio 2005
- Next Thread: Help with doing loops
