 |  |  |  |  |  |  |  |
Iterator assertion failure. How?
Please support our C++ advertiser: Intel Parallel Studio Home
 |
Hello everyone. Welcome to my first post.
I have problem, it didn't brough me here, but maybe someone figure it out, I'm staring at this piece of code for hour. I'm trying to make directory listing class. It puts filenames and directories to vectors. It's not finished, yet not working loop:
In meantime I'll try make this code readable.
I have problem, it didn't brough me here, but maybe someone figure it out, I'm staring at this piece of code for hour. I'm trying to make directory listing class. It puts filenames and directories to vectors. It's not finished, yet not working loop:
C++ Syntax (Toggle Plain Text)
In meantime I'll try make this code readable.
Last edited by Cybulski; May 14th, 2008 at 8:42 am.
•
•
Join Date: Aug 2005
Posts: 15,442
Reputation: 
Solved Threads: 1474
My guess is that neither of those loops will work.
1) how is iter_vsDirectory initialized? You failed to post it.
2) what is the purpose of that first loop with the iterator ? The iterator doesn't appear to be used anywhere within the loop. Adding more strings to the end of the vector might invalidate the iterator.
3) You have to call FindFirstFile() before you can start a loop for FindNextFile(). The FindNextFile() you have code will always fail.
1) how is iter_vsDirectory initialized? You failed to post it.
2) what is the purpose of that first loop with the iterator ? The iterator doesn't appear to be used anywhere within the loop. Adding more strings to the end of the vector might invalidate the iterator.
3) You have to call FindFirstFile() before you can start a loop for FindNextFile(). The FindNextFile() you have code will always fail.
C++ Syntax (Toggle Plain Text)
Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.
•
•
•
•
Originally Posted by Ancient Dragon 
My guess is that neither of those loops will work.
1) how is iter_vsDirectory initialized? You failed to post it.
2) what is the purpose of that first loop with the iterator ? The iterator doesn't appear to be used anywhere within the loop. Adding more strings to the end of the vector might invalidate the iterator.
3) You have to call FindFirstFile() before you can start a loop for FindNextFile(). The FindNextFile() you have code will always fail.
vector<string>::iterator iter_vsDirectory = v_sDirectories.begin();
2)
First loop is meant cycle trough directories. For each directory found in v_sDirectories it will call FindFirstFile, then internal loop to list files/directories inside. In case of dir found, it will append last setion of path to work recirsive in all directories inside one given at start.
If adding objects to vector invalidates iterator - thats not the way vector should work imo.
3)
It is called, before main loop.
There is result of running it:
C++ Syntax (Toggle Plain Text)
Last edited by Ancient Dragon; May 14th, 2008 at 9:22 am. Reason: corrected quote tags
•
•
Join Date: Aug 2005
Posts: 15,442
Reputation:
Solved Threads: 1474
From what you said in 2) you apparently did not post all the code. If that is correct then I suspect the problem is the iterator is getting invalidated when a new string is put into the vector.
If you are attempting to build a list of directory and their subdirectory names then maybe using recursion would be a better approach. Here is an example program how to do that. It gets all the file names as well, but you can easily modify the code to do what you want with it.
If you are attempting to build a list of directory and their subdirectory names then maybe using recursion would be a better approach. Here is an example program how to do that. It gets all the file names as well, but you can easily modify the code to do what you want with it.
Last edited by Ancient Dragon; May 14th, 2008 at 9:28 am.
Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.
Thank you very much mr. Ancient Dragon. Your code looks very nice and reusable. Will use these ideas in my solution.
[edit]
Anyway I'll think about it some more, inserting elements shouldn't invalidate iterator.
[edit]
Anyway I'll think about it some more, inserting elements shouldn't invalidate iterator.
Last edited by Cybulski; May 14th, 2008 at 9:48 am.
Ok, here is my solution:
Two things bother me:
1) strcmp() don't want take data.name as first parameter,
2) "." should be found and displayed, but it isn't.
It works well besides that.
C++ Syntax (Toggle Plain Text)
Two things bother me:
1) strcmp() don't want take data.name as first parameter,
2) "." should be found and displayed, but it isn't.
It works well besides that.
Last edited by Cybulski; May 16th, 2008 at 9:48 am.
•
•
Join Date: Aug 2005
Posts: 15,442
Reputation:
Solved Threads: 1474
you must have something else wrong because your function compiled ok for me. All I did was make it a simple function and declare the vector globally.
C++ Syntax (Toggle Plain Text)
Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.
yes, it compiles and works ok, but this:
Should display:
for every directory. It only does it for "..". Why is that?
And I had to declare additional strings and use
C++ Syntax (Toggle Plain Text)
Should display:
C++ Syntax (Toggle Plain Text)
And I had to declare additional strings and use
string.compare(...) because strcmp() takes no struct_filedata.name as parameter. •
•
Join Date: Aug 2005
Posts: 15,442
Reputation:
Solved Threads: 1474
>>if( (s_current.compare(struct_filedata.name) && s_parrent.compare(struct_filedata.name)) )
use || operator instead of && because it can't be both at the same time.
use || operator instead of && because it can't be both at the same time.
Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.
•
•
•
•
Originally Posted by Ancient Dragon
>>if( (s_current.compare(struct_filedata.name) && s_parrent.compare(struct_filedata.name)) )
use || operator instead of && because it can't be both at the same time.
|
Similar Threads
- Debug Assertion Failure (Web Browsers)
Other Threads in the C++ Forum
- Previous Thread: create blank charaters (white spaces)
- Next Thread: bubble sort
| Thread Tools | Search this Thread |
You need to join our community in order to build your list of favorite forums. You can visit the forum index for a listing of all forums.
Latest C++ Posts
- Today's Posts
- Unanswered Threads
Related Forum Features
api array arrays based binary c++ c/c++ calculator char char* class classes code coding compile compiler console conversion convert count database delete deploy desktop developer directshow dll download dynamic dynamiccharacterarray email encryption error file forms fstream function functions game generator givemetehcodez google graph gui homeworkhelp iamthwee ifstream input int java lib linkedlist linker list loop looping loops map math matrix memory multiple news number numbertoword output pointer problem program programming project python random read recursion recursive reference rpg sorting string strings temperature template templates test text text-file tree unix url variable vector video visual visualstudio win32 windows winsock wordfrequency wxwidgets
