User Name Password Register
DaniWeb IT Discussion Community
All
What is DaniWeb IT Discussion Community?
You're currently browsing the C section within the Software Development category of DaniWeb, a massive community of 402,620 software developers, web developers, Internet marketers, and tech gurus who are all enthusiastic about making contacts, networking, and learning from each other. In fact, there are 2,294 IT professionals currently interacting right now! Registration is free, only takes a minute and lets you enjoy all of the interactive features of the site.
Please support our C advertiser: Programming Forums

Problem in finding the greatest no. from array

Join Date: Nov 2007
Posts: 18
Reputation: varsha0702 is an unknown quantity at this point 
Rep Power: 1
Solved Threads: 0
varsha0702 varsha0702 is offline Offline
Newbie Poster

Re: Problem in finding the greatest no. from array

  #9  
May 16th, 2008
Originally Posted by web_master View Post
#include<stdio.h>
int main()
{
    int i ,j ,a[5];
    for(i=0;i<=4;i++)
    {
        printf("\n\tEnter the %dst value of the array: ", i+1);
        scanf("%d", &a[i]);
    }
    j = a[0];
    printf("\n\tOriginal array entered by the user: ");
    for(i=0;i<=4;i++)
    {
        printf(" %d ", a[i]);
        if(a[i]<a[i+1])
        {
             j = a[i+1];
        }
    }
    printf("\n\n\tGreatest no. from the array: %d", j);
getch();
return 0;   
}

according to me there is no problem in this code.......

but its printing some wierd values again n again.....

plz...help me out here....

My Wierd Output:

Enter the 1st value of the array: 56

Enter the 2st value of the array: 35

Enter the 3st value of the array: 26

Enter the 4st value of the array: 15

Enter the 5st value of the array: 24

Original array entered by the user: 56 35 26 15 24

Greatest no. from the array: 4007048




Hi...
U were not comparing all the elements. code started with comparing a single element with others. Following code will help u out.
  1. #include<stdio.h>
  2. int main()
  3. {
  4. int i ,j ,a[5],temp;
  5. for(i=0;i<=4;i++)
  6. {
  7. printf("\n\tEnter the %dst value of the array: ", i+1);
  8. scanf("%d", &a[i]);
  9. }
  10. i=0;
  11. // printf("\n\tOriginal array entered by the user: ");
  12.  
  13. //for(i=0;i<=3;i++)
  14. //{
  15. // printf(" %d ", a[i]);
  16. i=0;
  17. for(j=1;j<=4;j++)
  18. {
  19. if(a[i]>a[j])
  20. {
  21. temp =a[i];
  22. a[i]=a[j];
  23. a[j]=temp;
  24.  
  25. }
  26.  
  27. i++;
  28. }
  29.  
  30. printf("\n\n\tGreatest no. from the array: %d\n", a[4]);
  31.  
  32. return 0;
  33. }
Last edited by Narue : May 16th, 2008 at 12:41 pm. Reason: Added code tags
Reply With Quote  
All times are GMT -4. The time now is 1:11 am.
Forum system based on vBulletin Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
©2003 - 2008 DaniWeb® LLC