DaniWeb Forum Index > Web Development > PHP

Could a switch statement be used here?

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

•

Join Date: Jun 2008

Posts: 23

Reputation: forwardlookguy is an unknown quantity at this point

Solved Threads: 0

forwardlookguy forwardlookguy is offline

Offline

Newbie Poster

Could a switch statement be used here?

Jun 7th, 2008

I've got some code using a lot of complex if statements that I'm using for a VIN decoder. I finally got it working and I'm hesitant to alter it but these if statements are huge! If a switch statement could be used to accomplish what the if statements are doing, could someone give me an example using my data? Here's a snippet of code:

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
$ModelYear=substr($decode,5,1);
$AssemblyPlant=strtoupper(substr($decode,6,1));
          if ($AssemblyPlant == "2" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = St. Therese, Canada<br />";
	} elseif ($AssemblyPlant == "7" && $ModelYear == "9"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "B" && $ModelYear == "7"){
		echo "$AssemblyPlant = Baltimore, MD<br />";
	} elseif ($AssemblyPlant == "C"){
		echo "$AssemblyPlant = Southgate, California<br />";
	} elseif ($AssemblyPlant == "E" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Linden, NJ<br />";
        } elseif ($AssemblyPlant == "G"){
		echo "$AssemblyPlant = Framingham, Massachusetts<br />";
        } elseif ($AssemblyPlant == "H"){
		echo "$AssemblyPlant = Flint, Michigan<br />";
	} elseif ($AssemblyPlant == "K" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Leeds, MO<br />";
	} elseif ($AssemblyPlant == "L" && ($ModelYear >= 3 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Van Nuys, CA<br />";
	} elseif ($AssemblyPlant == "N" && $ModelYear == "4"){
		echo "$AssemblyPlant = Norwood, OH<br />";
	} elseif ($AssemblyPlant == "T" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Tarrytown, NY<br />";
	} elseif ($AssemblyPlant == "U" && $ModelYear == "8"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "W" && ($ModelYear >= 8 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Willow Run, MI<br />";
        } elseif ($AssemblyPlant == "X"){
		echo "$AssemblyPlant = Fairfax, Kansas<br />";
        } elseif ($AssemblyPlant == "Y" && ($ModelYear >= 2 && $ModelYear <= 5)){
		echo "$AssemblyPlant = Wilmington, Delaware<br />";
        } elseif ($AssemblyPlant == "Z"){
		echo "$AssemblyPlant = Fremont, California<br />";
} else {
		echo "Buick's weren't built at this plant in 197$ModelYear. Please check your VIN and try again.<br />";
}
$ModelYear=substr($decode,5,1);
$AssemblyPlant=strtoupper(substr($decode,6,1));
          if ($AssemblyPlant == "2" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = St. Therese, Canada<br />";
	} elseif ($AssemblyPlant == "7" && $ModelYear == "9"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "B" && $ModelYear == "7"){
		echo "$AssemblyPlant = Baltimore, MD<br />";
	} elseif ($AssemblyPlant == "C"){
		echo "$AssemblyPlant = Southgate, California<br />";
	} elseif ($AssemblyPlant == "E" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Linden, NJ<br />";
        } elseif ($AssemblyPlant == "G"){
		echo "$AssemblyPlant = Framingham, Massachusetts<br />";
        } elseif ($AssemblyPlant == "H"){
		echo "$AssemblyPlant = Flint, Michigan<br />";
	} elseif ($AssemblyPlant == "K" && ($ModelYear >= 5 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Leeds, MO<br />";
	} elseif ($AssemblyPlant == "L" && ($ModelYear >= 3 && $ModelYear <= 7)){
		echo "$AssemblyPlant = Van Nuys, CA<br />";
	} elseif ($AssemblyPlant == "N" && $ModelYear == "4"){
		echo "$AssemblyPlant = Norwood, OH<br />";
	} elseif ($AssemblyPlant == "T" && ($ModelYear >= 6 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Tarrytown, NY<br />";
	} elseif ($AssemblyPlant == "U" && $ModelYear == "8"){
		echo "$AssemblyPlant = Lordstown, OH<br />";
	} elseif ($AssemblyPlant == "W" && ($ModelYear >= 8 && $ModelYear <= 9)){
		echo "$AssemblyPlant = Willow Run, MI<br />";
        } elseif ($AssemblyPlant == "X"){
		echo "$AssemblyPlant = Fairfax, Kansas<br />";
        } elseif ($AssemblyPlant == "Y" && ($ModelYear >= 2 && $ModelYear <= 5)){
		echo "$AssemblyPlant = Wilmington, Delaware<br />";
        } elseif ($AssemblyPlant == "Z"){
		echo "$AssemblyPlant = Fremont, California<br />";
} else {
		echo "Buick's weren't built at this plant in 197$ModelYear. Please check your VIN and try again.<br />";
}

Thanks!

Last edited by peter_budo; Jun 10th, 2008 at 7:47 am. Reason: Keep It Organized - please use [code] tags

•

Join Date: Jun 2008

Posts: 3

Reputation: patelamitbe is an unknown quantity at this point

Solved Threads: 0

patelamitbe patelamitbe is offline

Offline

Newbie Poster

Re: Could a switch statement be used here?

Jun 8th, 2008

Hy, As i read your description I think if you are using switch statements the coding line should be same no difference only thing is that code looking is good but not code line

Thanks

•

Join Date: Jul 2006

Posts: 856

Reputation: pritaeas will become famous soon enough

Solved Threads: 139

pritaeas

Offline

Practically a Posting Shark

Re: Could a switch statement be used here?

Jun 9th, 2008

Hi. I don't think a switch statement will make your code better or easier to read.

In my (humble) opoinion you're better off creating a lookup table containing: plant, modelyearfrom, modelyearto, description.