DaniWeb Forum Index > Software Development > C++

Program works but shorter code?

Please support our C++ advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Jul 2008

Posts: 14

Reputation: Code Shark is an unknown quantity at this point

Solved Threads: 0

Code Shark Code Shark is offline

Offline

Newbie Poster

Program works but shorter code?

Jul 13th, 2008

Hello, I'm new to this forum and have a brief knowledge of C++. I made this program to ask the user for a word and make it so the word would not be allowed any "i's". I completed the task just my code looks a bit to much I think. Can you suggest ways i shorten it. Thank you.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
// Code Shark
 
#include <iostream>
 
using namespace std;
 
int main() {
    char word[20];
    int i = 0;
 
    cout << "Enter a word which includes NO i's : ";
    cin >> word;
 
    do {
        word[i];
 
        if(word[i] == 'i') {
                   i++;
                   cout << endl << "I asked for no i's!";
                   cin.get();
                   cin.get();
        }
    }
 
    while(i);
 
    return 0;
 
    cin.get();
    cin.get();
}
// Code Shark

#include <iostream>

using namespace std;

int main() {
    char word[20];
    int i = 0;
    
    cout << "Enter a word which includes NO i's : ";
    cin >> word;
    
    do {
        word[i];
        
        if(word[i] == 'i') {
                   i++;
                   cout << endl << "I asked for no i's!";
                   cin.get();
                   cin.get();
        }
    }
    
    while(i);
    
    return 0;
        
    cin.get();
    cin.get();
}

•

Join Date: Aug 2005

Posts: 15,679

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1504

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: Program works but shorter code?

Jul 13th, 2008

line 15: does nothing so you might as well delete it.
The loop lines 14-25 can be rewritten like this:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
char word[20];
while(1)
{
   cout << "Enter a word which includes NO i's : ";
   cin >> word;
 
   if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }
   else
       break;
}
char word[20];
while(1)
{
   cout << "Enter a word which includes NO i's : ";
   cin >> word;

   if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }
   else
       break;
}

I told Santa what I wanted for Christmas and he washed my mouth out with soap.

•

Join Date: May 2006

Posts: 1,867

Reputation: ithelp is a name known to all

Solved Threads: 120

ithelp

Offline

Posting Virtuoso

Re: Program works but shorter code?

Jul 13th, 2008

I guess it is C++ , you can use std::string apis like find , your code will reduce drastically.

•

Join Date: Jan 2008

Posts: 401

Reputation: CoolGamer48 is on a distinguished road

Solved Threads: 40

CoolGamer48 CoolGamer48 is offline

Offline

Posting Pro in Training

Re: Program works but shorter code?

Jul 13th, 2008

@AncientDragon
Doesn't the loop you give continually ask for strings until you enter one that doesn't have an 'i'? The original program just asked for one, and check if there was an 'i' in it, then ended. You can reduce lines 14-25 to

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }
if( strchr(word,'i') )
   {
      cout << endl << "I asked for no i's!";
   }

You can also remove line 9, the deceleration of the variable i, if you employ this method.

Also, the program terminates after return 0; , so there's no point in the two cin.get() statements after that. They can either be removed, or, you can put them before return 0; if you want them to be executed.

I'm a student. If my statements seem too absolute, feel free to coat them with "In my opinion..." or "I believe...".

•

Join Date: Jul 2008

Posts: 2,001

Reputation: ArkM has much to be proud of

Solved Threads: 343

ArkM

Offline

Postaholic

Re: Program works but shorter code?

Jul 13th, 2008

Never never never use cin >> char array!

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
string word;
 
while (cout << "Enter a word which includes NO i's : ",
         cin   >> word,
         word.find('i') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;
string word;

while (cout << "Enter a word which includes NO i's : ",
         cin   >> word,
         word.find('i') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;

•

Join Date: Jul 2008

Posts: 2,001

Reputation: ArkM has much to be proud of

Solved Threads: 343

ArkM

Offline

Postaholic

Re: Program works but shorter code?

Jul 13th, 2008

Sorry, more robust code (Ctrl-Z reaction added):

 Help with Code Tags 
 cpp Syntax (Toggle Plain Text) 
string word;
 
while (cout << "Enter a word which includes NO i's : ",
         cin >> word &&
         word.find_first_of('iI') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;string word;
string word;

while (cout << "Enter a word which includes NO i's : ",
         cin >> word &&
         word.find_first_of('iI') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;string word;

Last edited by Tekmaven; Jul 13th, 2008 at 5:29 pm. Reason: Added syntax to code tags

•

Join Date: Jan 2008

Posts: 401

Reputation: CoolGamer48 is on a distinguished road

Solved Threads: 40

CoolGamer48 CoolGamer48 is offline

Offline

Posting Pro in Training

Re: Program works but shorter code?

Jul 13th, 2008

•

Originally Posted by ArkM

Sorry, more robust code (Ctrl-Z reaction added):
Help with Code Tags

cpp Syntax (Toggle Plain Text)
string word;
 
while (cout << "Enter a word which includes NO i's : ",
         cin >> word &&
         word.find_first_of('iI') != string::npos
        )
        cout << "I asked for no i's!" << endl;
cout << "Thank you. Bye..." << endl;string word;
string word; while (cout << "Enter a word which includes NO i's : ", cin >> word && word.find_first_of('iI') != string::npos ) cout << "I asked for no i's!" << endl; cout << "Thank you. Bye..." << endl;string word;

Wait, when will the loop terminate? And what does the && operator do with left-operand istream and right-operand size_t? Is that even defined?

I'm a student. If my statements seem too absolute, feel free to coat them with "In my opinion..." or "I believe...".

•

Join Date: Aug 2007

Posts: 10

Reputation: galin is an unknown quantity at this point

Solved Threads: 2

galin

Offline

Newbie Poster

Re: Program works but shorter code?

Jul 13th, 2008

OK I tink if code pass all unit tests it's good code. Your code is good, but use std::string not char array with cin >>. If you want to catch all words that have ' , you can use boost regex lib http://www.boost.org/doc/libs/1_35_0...tml/index.html

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <boost/regex.hpp>
#include <iostream>
#include<string>
 
int main()
{
  std::string word;
  boost::regex e = "\b.+?[^'].+\b";
  boost::smatch what;
  std::cout << "Enter a word";
  std::cin >> word;
  if(boost::regex_match(word, what, e)
  {
    std::cout << "The word can not include ' " << std::endl;
  }
  std::cout << "Thank you. Bye..." << std::endl;
}
#include <boost/regex.hpp>
#include <iostream>
#include<string>

int main()
{
  std::string word;
  boost::regex e = "\b.+?[^'].+\b";
  boost::smatch what;
  std::cout << "Enter a word";
  std::cin >> word;
  if(boost::regex_match(word, what, e)
  {
    std::cout << "The word can not include ' " << std::endl;
  }
  std::cout << "Thank you. Bye..." << std::endl;
}

•

Join Date: Aug 2005

Posts: 15,679

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1504

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: Program works but shorter code?

-1

Jul 13th, 2008

•

Originally Posted by galin

OK I tink if code pass all unit tests it's good code. Your code is good, but use std::string not char array with cin >>. If you want to catch all words that have ' , you can use boost regex lib http://www.boost.org/doc/libs/1_35_0...tml/index.html

I think you have over complicated things for this assignment. All the op wants is for the program to detect when the word includes the letter 'i'. Doing regular expressions if far far beyond the scope of this assignment.

I told Santa what I wanted for Christmas and he washed my mouth out with soap.

•

Join Date: Jul 2008

Posts: 2,001

Reputation: ArkM has much to be proud of

Solved Threads: 343

ArkM

Offline

Postaholic

Re: Program works but shorter code?

#10

Jul 14th, 2008

Some explanations:

Stream operator >> (and << too) returns reference to stream (that's why we may couple expressions in

Help with Code Tags

cpp Syntax (Toggle Plain Text)

cin >> first >> second;
// (cin >> first) >> second - again stream >> target

Stream classes have conversion to bool (inherited from the common ancestor). It returns true if stream is OK otherwise false). Operator && is a simple C logical AND.

So the loop will been terminated when:
cin returns false (end of input stream or i/o error)
AND
find_first_of() returns std::string::npos value (no i's in the world).

The while stmt condition follows by the template:
Do_prompt , input_OK AND word_with_i

Do_prompt is the 1st arg of a comma operator (do this and forget then do the 2nd arg).

Some correction of my prev post:
1. Of course, the literal must "iI", not 'iI'
2. Discard string word in the tail (careless copy/paste op artifact