•
•
•
•
What is DaniWeb IT Discussion Community?
You're currently browsing the C++ section within the Software Development category of DaniWeb, a massive community of 423,634 software developers, web developers, Internet marketers, and tech gurus who are all enthusiastic about making contacts, networking, and learning from each other. In fact, there are 3,232 IT professionals currently interacting right now! Registration is free, only takes a minute and lets you enjoy all of the interactive features of the site.
Please support our C++ advertiser: Programming Forums
Views: 137 | Replies: 2
 |
•
•
Join Date: Jan 2008
Location: USA East Cost
Posts: 389
Reputation: 
Rep Power: 1
Solved Threads: 37
Posting Whiz
Is it bad to make a reference parameter optional by giving it a default value? Like here:
Here, the caller of the function may pass an optional std::string that will be filled with an error message if there is one. Is this considered "ok", both as far as being safe, good code and having good style?
int Parse(std::string filename, std::string& error = (std::string)"");
Here, the caller of the function may pass an optional std::string that will be filled with an error message if there is one. Is this considered "ok", both as far as being safe, good code and having good style?
I'm a student. If my statements seem too absolute, feel free to coat them with "In my opinion..." or "I believe...".
•
•
Join Date: Jul 2008
Posts: 582
Reputation:
Rep Power: 5
Solved Threads: 87
Posting Pro
It's legal construct (better use more accurate std::string(""), avoid old C style casts).
I don't like this style (tastes differ). It's an ineffective code (string constructor works on every call for default argument). It's some confusing code (pass by reference means inout parameter as ususlly).
In that case I prefer
I don't like this style (tastes differ). It's an ineffective code (string constructor works on every call for default argument). It's some confusing code (pass by reference means inout parameter as ususlly).
In that case I prefer
const char* msg = 0 - programmer's intentions are more evident... •
•
Join Date: Oct 2007
Location: Cherry Hill, NJ
Posts: 1,876
Reputation: 
Rep Power: 11
Solved Threads: 193
There is nothing wrong with it. You'll just get a reference to a temporary default.
The best advice is to write
as your argument. This will take strings and char*s equally.
Hope this helps.
The best advice is to write
const std::string& error = std::string()as your argument. This will take strings and char*s equally.
Hope this helps.
|
•
•
•
•
•
•
•
•
DaniWeb C++ Marketplace
•
•
•
•
Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
Linear Mode
Other Threads in the C++ Forum
- Previous Thread: what does this mean?
- Next Thread: Trouble with vector of pointers
