DaniWeb Forum Index > Software Development > C++

C++ RSS

Not repeated elements in link list (help)

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Jan 2008

Posts: 17

Reputation: lmastex is an unknown quantity at this point

Solved Threads: 0

lmastex

Offline

Newbie Poster

Not repeated elements in link list (help)

Dec 4th, 2008

Hi.

I want my Insertion method in my link list class not to insert repeated elements. I have tried several ways but I have seriously ugly bugs in my code:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
template <typename ListElement>
void List <ListElement>::Insert()
{
  NodePtr Ptr;
  Ptr = new Node;
  bool repeated = true;
 
if (Ptr == NULL)
  {
     cout << "Error: Insuficient Storage " << endl;
     exit(1);
  }
 
  cout << " Enter The Social Security Number of New Student: ";
  cin >> Ptr->Info.SSN;
  cout << "Enter The Age of This Student: ";
  cin >> Ptr->Info.Age;
 
	while( Ptr->Next != NULL)
	{
           if(Ptr->Info.Age == Ptr->Next->Info.Age)
             repeated = false;
             break; // This break is for not to add the element
 
             Ptr = Ptr->Next;
 
 
           }
 
Ptr->Next = Head;
  Head = Ptr;
 
if(repeated = false)
 cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works
 
 
 
	}
template <typename ListElement>
void List <ListElement>::Insert()
{
  NodePtr Ptr;
  Ptr = new Node;
  bool repeated = true;

if (Ptr == NULL)
  {
     cout << "Error: Insuficient Storage " << endl;
     exit(1);
  }
  
  cout << " Enter The Social Security Number of New Student: ";
  cin >> Ptr->Info.SSN;
  cout << "Enter The Age of This Student: ";
  cin >> Ptr->Info.Age;
 
	while( Ptr->Next != NULL)
	{
           if(Ptr->Info.Age == Ptr->Next->Info.Age)
             repeated = false;
             break; // This break is for not to add the element
             
             Ptr = Ptr->Next;
         
         
           }
  
Ptr->Next = Head;
  Head = Ptr;
  	
if(repeated = false)
 cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works
 


	}

What do you think it is? Thanks

Last edited by Narue; Dec 4th, 2008 at 3:41 pm. Reason: fixed code tags

•

Join Date: Apr 2008

Posts: 670

Reputation: Freaky_Chris is a jewel in the rough

Solved Threads: 113

Freaky_Chris Freaky_Chris is offline

Offline

Practically a Master Poster

Re: Not repeated elements in link list (help)

Dec 4th, 2008

Use code tags please [code=cplusplus][/code]
Also what exactly is the problem?

Chris

Knowledge is power -- But experience is everything

•

Join Date: Jan 2008

Posts: 17

Reputation: lmastex is an unknown quantity at this point

Solved Threads: 0

lmastex

Offline

Newbie Poster

Re: Not repeated elements in link list (help)

Dec 4th, 2008

Sorry I forgot ( I remember I used them though) Anyways.
The problem is that when I make an insertion of an element, I don't want to insert a repeated element, so if I inserted (Age = 20) and then If I insert (Age = 20) my list should have only one person who Age is 20, i don't want two ages of 20 in my list. Insertion without repeating elements.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
template <typename ListElement>
void List <ListElement>::Insert()
{
NodePtr Ptr;
Ptr = new Node;
bool repeated = true;
 
if (Ptr == NULL)
{
cout << "Error: Insuficient Storage " << endl;
exit(1);
}
 
cout << " Enter The Social Security Number of New Student: ";
cin >> Ptr->Info.SSN;
cout << "Enter The Age of This Student: ";
cin >> Ptr->Info.Age;
 
while( Ptr->Next != NULL)
{
if(Ptr->Info.Age == Ptr->Next->Info.Age)
repeated = false;
break; // This break is for not to add the element
 
Ptr = Ptr->Next;
 
 
}
 
Ptr->Next = Head;
Head = Ptr;
 
if(repeated = false)
cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works
 
 
 
}
template <typename ListElement>
void List <ListElement>::Insert()
{
NodePtr Ptr;
Ptr = new Node;
bool repeated = true;

if (Ptr == NULL)
{
cout << "Error: Insuficient Storage " << endl;
exit(1);
}

cout << " Enter The Social Security Number of New Student: ";
cin >> Ptr->Info.SSN;
cout << "Enter The Age of This Student: ";
cin >> Ptr->Info.Age;

while( Ptr->Next != NULL)
{
if(Ptr->Info.Age == Ptr->Next->Info.Age)
repeated = false;
break; // This break is for not to add the element

Ptr = Ptr->Next;


}

Ptr->Next = Head;
Head = Ptr;

if(repeated = false)
cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works



}

•

Join Date: Apr 2008

Posts: 670

Reputation: Freaky_Chris is a jewel in the rough

Solved Threads: 113

Freaky_Chris Freaky_Chris is offline

Offline

Practically a Master Poster

Re: Not repeated elements in link list (help)

Dec 4th, 2008

Here is one method of doing it, get the Age from the user, loop through your linked list. If you find it don't add it to the list if you don't then when add it to the list

Chris

Knowledge is power -- But experience is everything

•

Join Date: Jul 2008

Posts: 320

Reputation: cikara21 is an unknown quantity at this point

Solved Threads: 63

cikara21

Offline

Posting Whiz

Re: Not repeated elements in link list (help)

Dec 4th, 2008

Just call this..

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
bool sample::exist(NodePtr *p,int age)
{
   bool isexist=false;
   NodePtr *n_ptr = p;
   for(;n_ptr!=0;n_ptr=n_ptr->Next)
      if(n_ptr->Info.Age==age)
         isexist=true;
   return isexist;
)
bool sample::exist(NodePtr *p,int age)
{
   bool isexist=false;
   NodePtr *n_ptr = p;
   for(;n_ptr!=0;n_ptr=n_ptr->Next)
      if(n_ptr->Info.Age==age)
         isexist=true;
   return isexist;
)

$.:-cikara21-:.$

•

Join Date: Jun 2006

Posts: 147

Reputation: Laiq Ahmed will become famous soon enough

Solved Threads: 20

Laiq Ahmed Laiq Ahmed is offline

Offline

Junior Poster

Re: Not repeated elements in link list (help)

Dec 4th, 2008

•

Originally Posted by lmastex

Sorry I forgot ( I remember I used them though) Anyways.
The problem is that when I make an insertion of an element, I don't want to insert a repeated element, so if I inserted (Age = 20) and then If I insert (Age = 20) my list should have only one person who Age is 20, i don't want two ages of 20 in my list. Insertion without repeating elements.
Help with Code Tags

C++ Syntax (Toggle Plain Text)
template <typename ListElement>
void List <ListElement>::Insert()
{
NodePtr Ptr;
Ptr = new Node;
bool repeated = true;
 
if (Ptr == NULL)
{
cout << "Error: Insuficient Storage " << endl;
exit(1);
}
 
cout << " Enter The Social Security Number of New Student: ";
cin >> Ptr->Info.SSN;
cout << "Enter The Age of This Student: ";
cin >> Ptr->Info.Age;
 
while( Ptr->Next != NULL)
{
if(Ptr->Info.Age == Ptr->Next->Info.Age)
repeated = false;
break; // This break is for not to add the element
 
Ptr = Ptr->Next;
 
 
}
 
Ptr->Next = Head;
Head = Ptr;
 
if(repeated = false)
cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works
 
 
 
}
template <typename ListElement> void List <ListElement>::Insert() { NodePtr Ptr; Ptr = new Node; bool repeated = true; if (Ptr == NULL) { cout << "Error: Insuficient Storage " << endl; exit(1); } cout << " Enter The Social Security Number of New Student: "; cin >> Ptr->Info.SSN; cout << "Enter The Age of This Student: "; cin >> Ptr->Info.Age; while( Ptr->Next != NULL) { if(Ptr->Info.Age == Ptr->Next->Info.Age) repeated = false; break; // This break is for not to add the element Ptr = Ptr->Next; } Ptr->Next = Head; Head = Ptr; if(repeated = false) cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works }

I've changed your code

 Help with Code Tags 
 cpp Syntax (Toggle Plain Text) 
template <typename ListElement>
void List <ListElement>::Insert()
{
NodePtr Ptr;
Ptr = new Node;
bool repeated = false;
 
  if (Ptr == NULL)
 {
    cout << "Error: Insuficient Storage " << endl;
    exit(1);
 }
 
  cout << " Enter The Social Security Number of New Student: ";
  cin >> Ptr->Info.SSN;
  cout << "Enter The Age of This Student: ";
  cin >> Ptr->Info.Age;
 
 while( Ptr->Next != NULL)
 {
      if(Ptr->Info.Age == Ptr->Next->Info.Age) {
          repeated = true; 
          break; 
     }
     // This break is for not to add the element
     Ptr = Ptr->Next;
  }
 
 if(repeated = false) {
    Ptr->Next = Head;
    Head = Ptr;
 }
  else { 
          delete Ptr;
          cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works
   }
template <typename ListElement>
void List <ListElement>::Insert()
{
NodePtr Ptr;
Ptr = new Node;
bool repeated = false;

  if (Ptr == NULL)
 {
    cout << "Error: Insuficient Storage " << endl;
    exit(1);
 }

  cout << " Enter The Social Security Number of New Student: ";
  cin >> Ptr->Info.SSN;
  cout << "Enter The Age of This Student: ";
  cin >> Ptr->Info.Age;

 while( Ptr->Next != NULL)
 {
      if(Ptr->Info.Age == Ptr->Next->Info.Age) {
          repeated = true; 
          break; 
     }
     // This break is for not to add the element
     Ptr = Ptr->Next;
  }

 if(repeated = false) {
    Ptr->Next = Head;
    Head = Ptr;
 }
  else { 
          delete Ptr;
          cout << "repetition just ocurred" << endl; // This is just 4 me to verified if the function works
   }

Hope Above idea helps

•

Join Date: Jan 2008

Posts: 17

Reputation: lmastex is an unknown quantity at this point

Solved Threads: 0

lmastex

Offline

Newbie Poster

Re: Not repeated elements in link list (help)

Dec 4th, 2008

If there is a break in line 23 to stop the element to be added, then why is line 34 is a deletion?

(Im having problems with the code "cpp Syntax" changed)

•

Join Date: Jun 2006

Posts: 147

Reputation: Laiq Ahmed will become famous soon enough

Solved Threads: 20

Laiq Ahmed Laiq Ahmed is offline

Offline

Junior Poster

Re: Not repeated elements in link list (help)

Dec 4th, 2008

because You allocated the element on Heap in the beginning and you should release its memory if its a repeated element otherwise you'd have a memory leak.