 |  |  |  |  |  |  |  |
Card Games
Please support our C++ advertiser: Intel Parallel Studio Home
 |
i mean...
something like this one...
something like this one...
c++ Syntax (Toggle Plain Text)
I see what you mean.
I was only worried to make it work so I forgot a couple of important things:
1 - At the beginning of the pokerGame::deal() function I had to clear all players' hands, something like otherwise the next hand won't be dealt (because theirs are already full)
2 - At the end of the pokerGame::showdown() function I had to update the m_dealer variable with
Thanks for making me notice these.
I am currently working on making it recognize the points, I'll post the whole program zipped as soon as I'm done with this
EDIT: Being the deck random shuffling seed initialised from the clock, dealing a couple of hands without anything in between will just result in the same hands dealt to different players. This won't be a problem during a game but I thought to mention it. (I tested this inserting and removing non-portable
I was only worried to make it work so I forgot a couple of important things:
1 - At the beginning of the pokerGame::deal() function I had to clear all players' hands, something like
c++ Syntax (Toggle Plain Text)
2 - At the end of the pokerGame::showdown() function I had to update the m_dealer variable with
m_dealer = (m_dealer + 1) % m_numPlayers; Thanks for making me notice these.
I am currently working on making it recognize the points, I'll post the whole program zipped as soon as I'm done with this
EDIT: Being the deck random shuffling seed initialised from the clock, dealing a couple of hands without anything in between will just result in the same hands dealt to different players. This won't be a problem during a game but I thought to mention it. (I tested this inserting and removing non-portable
sleep(1); between the two pokerGame::deal() calls) Last edited by mrboolf; Dec 24th, 2008 at 8:21 am.
Ok just a little upgrade:
some minor changes throughout the code and it now recognizes the hands as real poker hands.
testmain.cpp provides a little example of a 4-hand "match" (there's still to do comparison between points to decide winner...).
No action at all but it kinda works so far
I hope this'll help someone other than me, in the meantime I am much grateful for any criticism and I want to thank all of you spending time with this
some minor changes throughout the code and it now recognizes the hands as real poker hands.
testmain.cpp provides a little example of a 4-hand "match" (there's still to do comparison between points to decide winner...).
No action at all but it kinda works so far
I hope this'll help someone other than me, in the meantime I am much grateful for any criticism and I want to thank all of you spending time with this
Please make the following changes (if you can) so I don't have to re-make them the next time I re-import your code:
Add
(You know you're only supposed to call srand() once per program run, right?)
Add
Add
#include <time.h> to deck.cpp and game.cpp(You know you're only supposed to call srand() once per program run, right?)
Add
#include <algorithm> to game.cpp and hand.cpp Ok changes made next attachment (to appear after christmas I guess) will have them.
srand() call in deck::build was there because I used deck class directly before writing pokerGame class - now it's gone as it should, thanks for noticing!
next attachment (to appear after christmas I guess) will have them.srand() call in deck::build was there because I used deck class directly before writing pokerGame class - now it's gone as it should, thanks for noticing!
Last edited by mrboolf; Dec 24th, 2008 at 12:35 pm.
I'm seeing an assertion (for array index out of bounds) on the last line posted below:
The clear() gets rid of all of the elements in the vector.
You call reserve() which makes sure the array can hold that many but doesn't fill it.
You could call resize() to actually change the size of the vector, but it appears that it would require pokerPoint to have a default constructor and it doesn't have one.
What do you think about giving pokerPoint a default constructor that sets it to a non-hand (or really low hand if a non-hand isn't possible). Then instead of calling clear() and reserve(), leave the pokerPoint instances in but call a new method
I may try to do something like that myself just to get it running again.
c++ Syntax (Toggle Plain Text)
The clear() gets rid of all of the elements in the vector.
You call reserve() which makes sure the array can hold that many but doesn't fill it.
You could call resize() to actually change the size of the vector, but it appears that it would require pokerPoint to have a default constructor and it doesn't have one.
What do you think about giving pokerPoint a default constructor that sets it to a non-hand (or really low hand if a non-hand isn't possible). Then instead of calling clear() and reserve(), leave the pokerPoint instances in but call a new method
pokerPoint::update(hand h, value minInDeck) passing in the players hand. This new method would update the pokerPoint based on the new hand. (You could keep re-constructing them to get the points, but is there a value added to create/destroy/re-create?)I may try to do something like that myself just to get it running again.
ok, I did the default constructor and called resize(). The assert is gone and the program runs.
I also did a little more playing, I added a third player 'Bob' who is also a CPU (not that it really matters right now).
Here's the output from my last run:
I don't know about you, but I'd almost like to see the hands in a short form, something like this:
Also when I was going through fixing it so it would run again, I spent more time actually looking at the design. I have a couple of comments. First, although you can declare a lot of classes and/or methods as friends, it is generally not good design. If there is a motivating reason, go ahead, but for simple things you can avoid it.
As an example, card had 7 friends:
almost all of those are friends so they can access the protected data members:
But you provided public accessors for those items, they're even inline so in theory you don't even pay the price of a call. (But you could change them later if you needed to and no-one would REALLY care.)
I would recommend that you re-visit all of your friend relationships to determine if they are really adding value. (I still have the pokerPoints output operator friendship, he's pretty connected, but I'm still not sure about him.)
You also have at least 2 copies of the string arrays for the card names and the suit names. (One in card and one in game.) Also when people are using the arrays, they are always doing something like
These methods can be accessed like
Speaking of constant references, const can be your friend (sometimes he's a little painful at first, but you'll come to love him too). There were several places where you're passing literal copies of objects or passing non-constant references. (If you pass a non-constant reference, the function or method you call could change the object you pass them.) It's normally good form when you're writing a method that does not need to make changes to a parameter passed by reference to make it a const reference.
A side effect of this is that when you're working with const references, you can only call methods of the object that have been marked const. So, for example, I marked card's accessors (to get the suit and the value) as const because they will not change the card. So they could be called from someone that had a const reference to a card.
The last thing (I remember) doing to card was moving the sort compare functions from being external friends to public static members of the class. (As members of the class, they get 'free' permission to access the protected data members.) Ok, so here's the class header:
The
Here's the source to match the header:
note that to implement the above changes, there were ripples through almost all of the other project files. Fairly straightforward, but they were there.
I also did a little more playing, I added a third player 'Bob' who is also a CPU (not that it really matters right now).
Here's the output from my last run:
C++ Syntax (Toggle Plain Text)
I don't know about you, but I'd almost like to see the hands in a short form, something like this:
C++ Syntax (Toggle Plain Text)
Also when I was going through fixing it so it would run again, I spent more time actually looking at the design. I have a couple of comments. First, although you can declare a lot of classes and/or methods as friends, it is generally not good design. If there is a motivating reason, go ahead, but for simple things you can avoid it.
As an example, card had 7 friends:
c++ Syntax (Toggle Plain Text)
almost all of those are friends so they can access the protected data members:
c++ Syntax (Toggle Plain Text)
But you provided public accessors for those items, they're even inline so in theory you don't even pay the price of a call. (But you could change them later if you needed to and no-one would REALLY care.)
c++ Syntax (Toggle Plain Text)
I would recommend that you re-visit all of your friend relationships to determine if they are really adding value. (I still have the pokerPoints output operator friendship, he's pretty connected, but I'm still not sure about him.)
You also have at least 2 copies of the string arrays for the card names and the suit names. (One in card and one in game.) Also when people are using the arrays, they are always doing something like
strValue[foo.m_value - 1] (with the non-friendship it looks more like strValue[foo.getValue()-1] . So I added a couple of static methods to card to do the lookup (and then I hid the arrays). c++ Syntax (Toggle Plain Text)
card::valueText(foo.getValue()) and return a constant reference to the string from the hidden array.Speaking of constant references, const can be your friend (sometimes he's a little painful at first, but you'll come to love him too). There were several places where you're passing literal copies of objects or passing non-constant references. (If you pass a non-constant reference, the function or method you call could change the object you pass them.) It's normally good form when you're writing a method that does not need to make changes to a parameter passed by reference to make it a const reference.
A side effect of this is that when you're working with const references, you can only call methods of the object that have been marked const. So, for example, I marked card's accessors (to get the suit and the value) as const because they will not change the card. So they could be called from someone that had a const reference to a card.
c++ Syntax (Toggle Plain Text)
The last thing (I remember) doing to card was moving the sort compare functions from being external friends to public static members of the class. (As members of the class, they get 'free' permission to access the protected data members.) Ok, so here's the class header:
c++ Syntax (Toggle Plain Text)
The
cmpValueAceHigh() comparison function could be used in hand sorting (oh, say from pokerPoints) to sort the hand by value and to get the ace to the end of the array. It would tend to make the hand outputs a little prettier and might allow you to be more generic in some of the 'if I have an ACE' code in pokerPoints. I was thinking about it, and wrote the comparison, but I haven't really looked into using it.Here's the source to match the header:
c++ Syntax (Toggle Plain Text)
note that to implement the above changes, there were ripples through almost all of the other project files. Fairly straightforward, but they were there.
Last edited by Murtan; Dec 24th, 2008 at 3:18 pm. Reason: spelling
|
Similar Threads
- nVidia Card; Games with presistant white flickering. (Monitors, Displays and Video Cards)
- Card Games Help!!!! (Java)
- Card Game Help (Java)
- Nvidia graphics card catastrophic failure (Windows NT / 2000 / XP)
- Games act weird (Troubleshooting Dead Machines)
Other Threads in the C++ Forum
- Previous Thread: Dependency line needs colon or double colon operator
- Next Thread: Help with simple classes-constructors
| Thread Tools | Search this Thread |
You need to join our community in order to build your list of favorite forums. You can visit the forum index for a listing of all forums.
Related Forum Features
Latest C++ Posts
- Today's Posts
- Unanswered Threads
api array based binary bitmap c++ c/c++ calculator char char* class classes code coding compile console conversion count database delete deploy desktop developer directshow dll download dynamic dynamiccharacterarray email encryption error file forms fstream function functions game givemetehcodez google graph gui homeworkhelp iamthwee ifstream input int java lib linkedlist linker linux list loop looping loops map math matrix memory multiple news node number numbertoword output pointer problem program programming project python random read recursion recursive reference return rpg sorting string strings temperature template templates test text text-file tree unix url variable vector video visualstudio win32 windows winsock word wordfrequency wxwidgets
