DaniWeb Forum Index > Software Development > C

Segmentation Error

Please support our C advertiser: Programming Forums - DaniWeb Sister Site

Thread Solved

•

Join Date: Oct 2008

Posts: 48

Reputation: atman is an unknown quantity at this point

Solved Threads: 0

atman

Offline

Light Poster

Segmentation Error

Jan 18th, 2009

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
#include<stdio.h>
#define COUNT 5
 
 
void enter(int *p_arr);
void report(int arr[], int count);
 
int main()
{
 
 
	int arr[5];
	int i;
	for(i=0; i < COUNT; i++)
	{
		enter(&arr[i]);
	}
 
	report(arr, COUNT);
 
 
}   
 
void enter(int *p_arr)
{
	int i;
	int insert;
	printf("\nplease enter the number:");
	scanf("%d", &insert);
	p_arr[i]=insert;
}
 
 
void report(int arr[], int count)
{
	int i;
    printf("The numbers you have entered are:");
	for(i=0; i< count; i++)
		printf("\n%d", arr[i]);
}
#include<stdio.h>
#define COUNT 5


void enter(int *p_arr);
void report(int arr[], int count);

int main()
{
	
	
	int arr[5];
	int i;
	for(i=0; i < COUNT; i++)
	{
		enter(&arr[i]);
	}
	
	report(arr, COUNT);
	
	
}   

void enter(int *p_arr)
{
	int i;
	int insert;
	printf("\nplease enter the number:");
	scanf("%d", &insert);
	p_arr[i]=insert;
}


void report(int arr[], int count)
{
	int i;
    printf("The numbers you have entered are:");
	for(i=0; i< count; i++)
		printf("\n%d", arr[i]);
}

Hello Guys.,
I'm new and learning C, when i compiled and ran this program on my mac in bash using gcc, it works... on our school server however it compiles but after the first entry it sais "Segmentation Error" and quits, any thoughts would be greatly appreciated!
Thanx!

•

Join Date: Sep 2004

Posts: 7,789

Reputation: Narue has a reputation beyond repute

Solved Threads: 746

Narue

Offline

Code Goddess

Re: Segmentation Error

Jan 18th, 2009

>p_arr[i]=insert;
Tell me the value of i in this line of code.

I'm here to prove you wrong.

•

Join Date: Oct 2008

Posts: 48

Reputation: atman is an unknown quantity at this point

Solved Threads: 0

atman

Offline

Light Poster

Re: Segmentation Error

Jan 18th, 2009

•

Originally Posted by Narue

>p_arr[i]=insert;
Tell me the value of i in this line of code.

depends on the pass if its the first pass then 0, if second then 1, e.c.t...

•

Join Date: Dec 2006

Posts: 2,039

Reputation: Aia has much to be proud of

Solved Threads: 177

Aia

Offline

Postaholic

Re: Segmentation Error

Jan 18th, 2009

•

Originally Posted by atman

depends on the pass if its the first pass then 0, if second then 1, e.c.t...

Nope. That i has the value of "segmentation fault".
It never gets initialized.
If you want to pass it a value you need to do it as an argument.
void enter(int *p_arr, int i); Make sure the passed int contains a meaningful value.

Last edited by Aia; Jan 18th, 2009 at 10:39 pm.

•

Join Date: Sep 2004

Posts: 7,789

Reputation: Narue has a reputation beyond repute

Solved Threads: 746

Narue

Offline

Code Goddess

Re: Segmentation Error

Jan 19th, 2009

>depends on the pass if its the first pass then 0, if second then 1, e.c.t...
Bzzt! Wrong. The correct answer is "I don't know". Though I would have accepted "indeterminate" as well. Technically you don't need i at all in that function because you pass the address of the correct array element:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
void enter(int *p_arr)
{
  int insert;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  *p_arr=insert;
}
void enter(int *p_arr)
{
  int insert;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  *p_arr=insert;
}

However, because you use p_arr[i] where i is indeterminate (usually this means a large number), then you're pretty sure to index the array well out of its bounds.

If you want to continue using array notation, this will solve the problem immediately (though it's technically identical to my previous fix):

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
void enter(int *p_arr)
{
  int i = 0;
  int insert;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  p_arr[i]=insert;
}
void enter(int *p_arr)
{
  int i = 0;
  int insert;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  p_arr[i]=insert;
}

Note that i is always 0, because p_arr always points to the element you want to initialize. You can also change your logic as Aia suggested such that the index actually makes sense:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
int main()
{
  int arr[5];
  int i;
 
  for ( i = 0; i < COUNT; i++ )
    enter ( arr, i );
 
  report ( arr, COUNT );
 
  return 0;
}   
 
void enter ( int *p_arr, int i )
{
  int insert;
 
  printf ( "\nplease enter the number:" );
  scanf ( "%d", &insert );
  p_arr[i] = insert;
}
int main()
{
  int arr[5];
  int i;

  for ( i = 0; i < COUNT; i++ )
    enter ( arr, i );

  report ( arr, COUNT );

  return 0;
}   

void enter ( int *p_arr, int i )
{
  int insert;

  printf ( "\nplease enter the number:" );
  scanf ( "%d", &insert );
  p_arr[i] = insert;
}

Last edited by Narue; Jan 19th, 2009 at 9:41 am.

I'm here to prove you wrong.

•

Join Date: Apr 2006

Posts: 357

Reputation: death_oclock will become famous soon enough

Solved Threads: 37

death_oclock death_oclock is offline

Offline

Posting Whiz

Re: Segmentation Error

Jan 19th, 2009

If you have to use array notation, also consider using a static variable instead of a parameter:

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
void enter(int *p_arr)
{
  static int insert = 0;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  p_arr[i++]=insert;
}
void enter(int *p_arr)
{
  static int insert = 0;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  p_arr[i++]=insert;
}

•

Join Date: Sep 2004

Posts: 7,789

Reputation: Narue has a reputation beyond repute

Solved Threads: 746

Narue

Offline

Code Goddess

Re: Segmentation Error

Jan 19th, 2009

>If you have to use array notation, also consider
>using a static variable instead of a parameter
That's a horrible suggestion. You've managed with one change to ruin the function's flexibility, potential error handling, actual error handling, and thread safety. Congratulations, this gets my vote for the most damaging minor change of the week award.

p.s. Your code is broken, so I mentally changed it to this:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
void enter(int *p_arr)
{
  static int i = 0;
  int insert;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  p_arr[i++]=insert;
}
void enter(int *p_arr)
{
  static int i = 0;
  int insert;
  printf("\nplease enter the number:");
  scanf("%d", &insert);
  p_arr[i++]=insert;
}