DaniWeb Forum Index > Software Development > C

minmax

Please support our C advertiser: Programming Forums - DaniWeb Sister Site

Thread Solved

•

Join Date: Dec 2008

Posts: 101

Reputation: Dewey1040 is an unknown quantity at this point

Solved Threads: 3

Dewey1040

Offline

Junior Poster

minmax

Mar 30th, 2009

ok so im creating a program minmax to find the minimum and maximum numbers of an array. heres my code but i get segmentation fault where do you think im going wrong?

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
#include <stdio.h>
#include <stdlib.h>
 
void minmax( int numberlist[], int n, int *p_min, int *p_max );
 
int main( int argc, char *argv[] ){
 
  int *numberlist, i, n, *min, *max ;
 
  n = atoi( argv[1] );
 
  numberlist = ( int * ) malloc( n * sizeof( int ) );
 
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;
 
  minmax( numberlist, n, min, max );
 
  printf( "The minimum value in your array is: %d", *min );
  printf( "The maximum value in your array is: %d", *max );
 return 0;
}
 
void minmax( int numberlist[], int n, int *p_min, int *p_max ){
 
  int min2, max2, i;
 
  if( n == 1 ) *p_min = *p_max = numberlist[0];
 
  else if( n == 2 ) {
 
    if( numberlist[0] < numberlist[i] ) {
      *p_min = numberlist[0];
      *p_max = numberlist[1];
 
    } else {
      *p_min = numberlist[1];
      *p_max = numberlist[0];
    }
 
  } else {
minmax( numberlist, n / 2, p_min, p_max );
    minmax( numberlist + n / 2, n - ( n / 2 ), &min2, &max2 );
 
    if( min2 < *p_min )
      *p_min = min2;
 
    if( max2 > *p_max )
      *p_max = max2;
  }
}
#include <stdio.h>
#include <stdlib.h>

void minmax( int numberlist[], int n, int *p_min, int *p_max );

int main( int argc, char *argv[] ){

  int *numberlist, i, n, *min, *max ;

  n = atoi( argv[1] );

  numberlist = ( int * ) malloc( n * sizeof( int ) );

  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

  minmax( numberlist, n, min, max );

  printf( "The minimum value in your array is: %d", *min );
  printf( "The maximum value in your array is: %d", *max );
 return 0;
}

void minmax( int numberlist[], int n, int *p_min, int *p_max ){

  int min2, max2, i;

  if( n == 1 ) *p_min = *p_max = numberlist[0];

  else if( n == 2 ) {

    if( numberlist[0] < numberlist[i] ) {
      *p_min = numberlist[0];
      *p_max = numberlist[1];

    } else {
      *p_min = numberlist[1];
      *p_max = numberlist[0];
    }

  } else {
minmax( numberlist, n / 2, p_min, p_max );
    minmax( numberlist + n / 2, n - ( n / 2 ), &min2, &max2 );

    if( min2 < *p_min )
      *p_min = min2;

    if( max2 > *p_max )
      *p_max = max2;
  }
}

Last edited by Dewey1040; Mar 30th, 2009 at 11:03 am.

•

Join Date: Jan 2009

Posts: 476

Reputation: csurfer is just really nice

Solved Threads: 76

csurfer

Offline

Posting Pro in Training

Re: minmax

Mar 30th, 2009

This is where you went wrong.

In your program pointers min and max are there but are not pointing to any memory space at all.So when you try to access some memory as *min or *max they try to refer a memory not been allocated hence segmentation fault core dumped.

Try this:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
int main( int argc, char *argv[] ){
 
int *numberlist, i, n, *min, *max ,minimum,maximum;
 
min=&minimum;
max=&maximum;
//Followed by your code
int main( int argc, char *argv[] ){

int *numberlist, i, n, *min, *max ,minimum,maximum;

min=&minimum;
max=&maximum;
//Followed by your code

By this you will have allocated the memory and then accessing it so no problem. And ya your max and min values will be in maximum and minimum.

Last edited by csurfer; Mar 30th, 2009 at 1:50 pm.

I Surf in "C"....

•

Join Date: Dec 2008

Posts: 101

Reputation: Dewey1040 is an unknown quantity at this point

Solved Threads: 3

Dewey1040

Offline

Junior Poster

Re: minmax

Mar 30th, 2009

thanks csurfer, ill try that as soon as putty chooses to work again

•

Join Date: Apr 2006

Posts: 357

Reputation: death_oclock will become famous soon enough

Solved Threads: 37

death_oclock death_oclock is offline

Offline

Posting Whiz

Re: minmax

Mar 30th, 2009

Purely for the sake of simplicity, I would go with this route (doesn't use a second set of variables):

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
int main( int argc, char *argv[] ){
  int *numberlist, i, n, min, max ;
 
  n = atoi( argv[1] );
  numberlist = ( int * ) malloc( n * sizeof( int ) );
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;
 
  minmax( numberlist, n, &min, &max );
int main( int argc, char *argv[] ){
  int *numberlist, i, n, min, max ;

  n = atoi( argv[1] );
  numberlist = ( int * ) malloc( n * sizeof( int ) );
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

  minmax( numberlist, n, &min, &max );

•

Join Date: Jul 2008

Posts: 2,001

Reputation: ArkM has much to be proud of

Solved Threads: 343

ArkM

Offline

Postaholic

Re: minmax

Mar 30th, 2009

Think about another approach:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
struct IntRange { int minval, maxval; };
 
struct IntRange MinMax(const int* arr, int n)
{
    struct IntRange range = { 0, 0 };
    if (arr && 0 < n) {
        int i;
        range.minval = range.maxval = arr[0];
        for (i = 1; i < n; ++i) {
            if (arr[i] < range.minval)
                range.minval = arr[i];
            else if (range.maxval < arr[i])
                range.maxval = arr[i];
        }
    }
    return range;
};
 
int main()
{
    int* numberlist;
    struct Range range;
    ...
    range = MinMax(numberlist,n);
    printf("Min %d\nMax %d\n",range.minval.range.maxval);
	return 0;
}
struct IntRange { int minval, maxval; };

struct IntRange MinMax(const int* arr, int n)
{
    struct IntRange range = { 0, 0 };
    if (arr && 0 < n) {
        int i;
        range.minval = range.maxval = arr[0];
        for (i = 1; i < n; ++i) {
            if (arr[i] < range.minval)
                range.minval = arr[i];
            else if (range.maxval < arr[i])
                range.maxval = arr[i];
        }
    }
    return range;
};

int main()
{
    int* numberlist;
    struct Range range;
    ...
    range = MinMax(numberlist,n);
    printf("Min %d\nMax %d\n",range.minval.range.maxval);
	return 0;
}

•

Join Date: Dec 2008

Posts: 101

Reputation: Dewey1040 is an unknown quantity at this point

Solved Threads: 3

Dewey1040

Offline

Junior Poster

Re: minmax

Mar 30th, 2009

i have to use that function minmax because that is the one that we were assigned to use for the class, and i made the changed death oclock gave, but it just prints out the min and max values are 0... any ideas?

•

Join Date: Apr 2006

Posts: 357

Reputation: death_oclock will become famous soon enough

Solved Threads: 37

death_oclock death_oclock is offline

Offline

Posting Whiz

Re: minmax

Mar 30th, 2009

Ark's approach is much neater and most likely works. Your solution is very hard to read; the looping approach makes more sense.

•

Join Date: Dec 2008

Posts: 101

Reputation: Dewey1040 is an unknown quantity at this point

Solved Threads: 3

Dewey1040

Offline

Junior Poster

Re: minmax

Mar 31st, 2009

heres my iterative method, the full assigment is to test the recursive method, and iterative method to see when the recursive method begins to be faster then the iterative method. (time both with array sizes of 500, 5000, 50000, 500000 numbers). And at the moment this one also only prints out the min and max values are 0.

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
/*********************************************************************/
/* iterminmax.c                                                       */
/*********************************************************************/
 
#include <stdio.h>
#include <stdlib.h>
 
void minmax( int a[], int n, int *p_min, int *p_max );
 
int main( int argc, char *argv[] ){
 
  int *numberlist, i, n, min, max;
 
  n = atoi( argv[1] );
 
  numberlist = ( int * ) malloc( n * sizeof( int ) );
 
  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;
 
  minmax( numberlist, n, &min, &max );
 
  printf( "\nThe minimum value in your array is: %d", min );
  printf( "\nThe maximum value in your array is: %d\n", max );
 
 
  return 0;
}
 
void minmax( int a[], int n, int *p_min, int *p_max ){
 
  int i;
 
  *p_max = *p_min = a[0];
 
  for( i = 1; i < n; i++ ){
 
    if( a[i] > *p_max )
      *p_max = a[i];
 
    if( a[i] < *p_min )
      *p_min = a[i];
  }
}
/*********************************************************************/
/* iterminmax.c                                                       */
/*********************************************************************/

#include <stdio.h>
#include <stdlib.h>

void minmax( int a[], int n, int *p_min, int *p_max );

int main( int argc, char *argv[] ){

  int *numberlist, i, n, min, max;

  n = atoi( argv[1] );

  numberlist = ( int * ) malloc( n * sizeof( int ) );

  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

  minmax( numberlist, n, &min, &max );

  printf( "\nThe minimum value in your array is: %d", min );
  printf( "\nThe maximum value in your array is: %d\n", max );


  return 0;
}

void minmax( int a[], int n, int *p_min, int *p_max ){

  int i;

  *p_max = *p_min = a[0];

  for( i = 1; i < n; i++ ){

    if( a[i] > *p_max )
      *p_max = a[i];

    if( a[i] < *p_min )
      *p_min = a[i];
  }
}

•

Join Date: Jul 2008

Posts: 2,001

Reputation: ArkM has much to be proud of

Solved Threads: 343

ArkM

Offline

Postaholic

Re: minmax

Mar 31st, 2009

Look at csurfer's post again!
It was the true solution of your problems (in other words, it was a correction of your mistake

)...

•

Join Date: Nov 2007

Posts: 981

Reputation: mitrmkar is just really nice

Solved Threads: 210

mitrmkar

Offline

Posting Shark

Re: minmax

#10

Mar 31st, 2009

There is an initialization failure ...

Help with Code Tags

(Toggle Plain Text)

  for( i = 0; i < n; i++ ) numberlist[i] == rand() % n ;

Quick Reply to Thread

Show Printable Version

Similar Threads

How do i load a image on the same page ? (Site Layout and Usability)
pebble chess in c++ (C++)
CSV file (C)
Build Failed Issues.. (Java)
Overfloat? IE6/win? (HTML and CSS)
i need a project (C++)
C++ help (C++)
TO CHAINSAW - or anybody else who knows C++ (C++)

Other Threads in the C Forum

Previous Thread: Need pointer version of this
Next Thread: clearing the text file contents using C

Views: 712 | Replies: 10

Thread Tools	Search this Thread
Show Printable Version Email this Page

DaniWeb Message

Cancel Changes