DaniWeb Forum Index > Software Development > C++

C++ RSS

Need C++ BlackJack Shuffle Example

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Apr 2009

Posts: 2

Reputation: soulbee1 is an unknown quantity at this point

Solved Threads: 0

soulbee1

Offline

Newbie Poster

Need C++ BlackJack Shuffle Example

Apr 15th, 2009

Forgive my ignorance, I am learning. I am writing a C++ BlackJack program for school project. I have googled and incorporated the following code into my project. My results are I am getting a value for the cards of 2 - 5 and i do not understand why.
If someone can advise me of what I am doing wrong or have a good sample for me to look at would be greatly appreciated.
int lowest=2;
int numCards=14;
// 2,3,4,5,6,7,8,9,10,J,Q,K,A
int range=(numCards-lowest)+1;
// range of 1 to 14 card values
srand(time(0)); // initialize seed "randomly"
for(int i = 0; i < (120 - 1); i++)
{
int randNum1 = (rand() % (range));
int randNum2 = (rand() % (range));
card *temp = myDeck[randNum1];
myDeck[randNum1] = myDeck[randNum2];
myDeck[randNum2] = temp;

}
Thanks for your help in advance.

Last edited by soulbee1; Apr 15th, 2009 at 1:55 am.

•

Join Date: Jan 2008

Posts: 3,825

Reputation: VernonDozier has a reputation beyond repute

Solved Threads: 501

VernonDozier VernonDozier is offline

Offline

Senior Poster

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

•

Originally Posted by soulbee1

Forgive my ignorance, I am learning. I am writing a C++ BlackJack program for school project. I have googled and incorporated the following code into my project. My results are I am getting a value for the cards of 2 - 5 and i do not understand why.
If someone can advise me of what I am doing wrong or have a good sample for me to look at would be greatly appreciated.
int lowest=2;
int numCards=14;
// 2,3,4,5,6,7,8,9,10,J,Q,K,A
int range=(numCards-lowest)+1;
// range of 1 to 14 card values
srand(time(0)); // initialize seed "randomly"
for(int i = 0; i < (120 - 1); i++)
{
int randNum1 = (rand() % (range));
int randNum2 = (rand() % (range));
card *temp = myDeck[randNum1];
myDeck[randNum1] = myDeck[randNum2];
myDeck[randNum2] = temp;

}
Thanks for your help in advance.

I think I'd have to see the rest of the code to be able to duplicate what you are getting exactly. Here are two code snippets I wrote that may be helpful:

http://www.daniweb.com/code/snippet1034.html
http://www.daniweb.com/code/snippet1019.html

One is easier to follow than the other.

My shuffling methods were different from what you are attempting. I'm not 100% sure what is going on with what you are doing (like I said, I'd have to see the rest of the code). Basically you are picking two random indexes and swapping the array elements of those two. That's a valid way of shuffling. I am wondering, though, if there is possibly some issue with your swap. Perhaps it is a shallow versus deep copy issue? Post more of your code so we can see the array initialization and the display function and can test it out.

Here's a way that worked and that looks like it is using the method you are trying to use, so the methodology is sound. Quite possibly the problem may also be somewhere in the code you haven't posted.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <ctime>
using namespace std;
 
int main ()
{
    srand (time (NULL));
    int cards[13];
    for (int i = 0; i < 13; i++)
        cards[i] = i;
 
    for (int i = 0; i < 200; i++)
    {
        int index1 = rand () % 13;
        int index2 = rand () % 13;
        if (index1 != index2)
        {
            int temp = cards[index1];
            cards[index1] = cards[index2];
            cards[index2] = temp;
        }
    }
 
    for (int i = 0; i < 13; i++)
        cout << cards[i] << endl;
 
    cin.get ();
    return 0;
}
#include <iostream>
#include <ctime>
using namespace std;

int main ()
{
    srand (time (NULL));
    int cards[13];
    for (int i = 0; i < 13; i++)
        cards[i] = i;
        
    for (int i = 0; i < 200; i++)
    {
        int index1 = rand () % 13;
        int index2 = rand () % 13;
        if (index1 != index2)
        {
            int temp = cards[index1];
            cards[index1] = cards[index2];
            cards[index2] = temp;
        }
    }
    
    for (int i = 0; i < 13; i++)
        cout << cards[i] << endl;
        
    cin.get ();
    return 0;
}

•

Join Date: Sep 2008

Posts: 90

Reputation: unbeatable0 is an unknown quantity at this point

Solved Threads: 12

unbeatable0 unbeatable0 is offline

Offline

Junior Poster in Training

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

Why not use the built-in random shuffle() function from the header <algorithm> ?

•

Join Date: Oct 2008

Posts: 476

Reputation: nucleon has a spectacular aura about

Solved Threads: 91

nucleon

Offline

Posting Pro in Training

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

Here's a simple shuffle that ensures every element is moved at least once. Note the loop only needs 13 reps for 13 numbers.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
const int MAX = 13;
int a[MAX];
for (int i = 0; i < MAX; ++i) a[i] = i;
for (int i = 0; i < MAX; ++i) {
    int r = rand() % MAX;
    int t = a[i]; a[i] = a[r]; a[r] = t;
}
const int MAX = 13;
int a[MAX];
for (int i = 0; i < MAX; ++i) a[i] = i;
for (int i = 0; i < MAX; ++i) {
    int r = rand() % MAX;
    int t = a[i]; a[i] = a[r]; a[r] = t;
}

•

Join Date: Sep 2008

Posts: 90

Reputation: unbeatable0 is an unknown quantity at this point

Solved Threads: 12

unbeatable0 unbeatable0 is offline

Offline

Junior Poster in Training

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

•

Originally Posted by nucleon

Here's a simple shuffle that ensures every element is moved at least once. Note the loop only needs 13 reps for 13 numbers.
Help with Code Tags

C++ Syntax (Toggle Plain Text)
const int MAX = 13;
int a[MAX];
for (int i = 0; i < MAX; ++i) a[i] = i;
for (int i = 0; i < MAX; ++i) {
    int r = rand() % MAX;
    int t = a[i]; a[i] = a[r]; a[r] = t;
}
const int MAX = 13; int a[MAX]; for (int i = 0; i < MAX; ++i) a[i] = i; for (int i = 0; i < MAX; ++i) { int r = rand() % MAX; int t = a[i]; a[i] = a[r]; a[r] = t; }

You can't ensure that this code will move every element at least once because you can't ensure that r=rand()%MAX; won't give the exact value of i.
The code might also replace twice the same elements, causing no change.

Last edited by unbeatable0; Apr 15th, 2009 at 1:21 pm.

•

Join Date: May 2008

Posts: 376

Reputation: Clockowl is on a distinguished road

Solved Threads: 27

Clockowl

Offline

Posting Whiz

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
const int MAX = 13;
int a[MAX];
for (int i = 0; i < MAX; ++i) a[i] = i;
for (int i = 0; i < MAX; ++i) {
    int r = rand() % MAX;
    while(r == i) r = rand() % MAX;
    int t = a[i]; a[i] = a[r]; a[r] = t;
}
const int MAX = 13;
int a[MAX];
for (int i = 0; i < MAX; ++i) a[i] = i;
for (int i = 0; i < MAX; ++i) {
    int r = rand() % MAX;
    while(r == i) r = rand() % MAX;
    int t = a[i]; a[i] = a[r]; a[r] = t;
}

That oughta take care of the first thing. ;D Shuffling the same elements twice is something that has in chance in real life as well, so it's part of being random.

Last edited by Clockowl; Apr 15th, 2009 at 1:31 pm.

•

Join Date: Sep 2008

Posts: 90

Reputation: unbeatable0 is an unknown quantity at this point

Solved Threads: 12

unbeatable0 unbeatable0 is offline

Offline

Junior Poster in Training

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

•

Originally Posted by Clockowl

Help with Code Tags

c Syntax (Toggle Plain Text)
const int MAX = 13;
int a[MAX];
for (int i = 0; i < MAX; ++i) a[i] = i;
for (int i = 0; i < MAX; ++i) {
    int r = rand() % MAX;
    while(r == i) r = rand() % MAX;
    int t = a[i]; a[i] = a[r]; a[r] = t;
}
const int MAX = 13; int a[MAX]; for (int i = 0; i < MAX; ++i) a[i] = i; for (int i = 0; i < MAX; ++i) { int r = rand() % MAX; while(r == i) r = rand() % MAX; int t = a[i]; a[i] = a[r]; a[r] = t; }
That oughta take care of the first thing. ;D Shuffling the same elements twice is something that has in chance in real life as well, so it's part of being random.

I didn't say it isn't random, I just said he can't ensure that every element moves at least once

•

Join Date: May 2008

Posts: 376

Reputation: Clockowl is on a distinguished road

Solved Threads: 27

Clockowl

Offline

Posting Whiz

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

•

Originally Posted by unbeatable0

I didn't say it isn't random, I just said he can't ensure that every element moves at least once

Well technically, they moved twice. But I catch your drift: it's not guaranteed that all the values will be at different indexes from where they started. Anyway, your first argument was pretty good, nobody would ever "switch" card 1 with card 1, so... I think that's a pretty good algo for randomizing stuff.

But, hey, we're C++, why not use STL's random_shuffle? Works on every STL container, suits the job just fine.

Here's a nice example: http://www.cplusplus.com/reference/a...andom_shuffle/

•

Join Date: Oct 2008

Posts: 476

Reputation: nucleon has a spectacular aura about

Solved Threads: 91

nucleon

Offline

Posting Pro in Training

Re: Need C++ BlackJack Shuffle Example

Apr 15th, 2009

•

Originally Posted by unbeatable0

You can't ensure that this code will move every element at least once

Good point. I don't know what I was thinking. An element should be allowed to stay in the same place, otherwise it is certainly not a random permutation.

•

Join Date: Nov 2008

Posts: 395

Reputation: StuXYZ is a glorious beacon of light

Solved Threads: 72

StuXYZ

Online

Posting Whiz

Re: Need C++ BlackJack Shuffle Example

#10

Apr 15th, 2009

Sorry, but most of these solutions are inelegant and that is because to achieve randomness they require an excessive number of random number calls:

(a) Shuffling the stack by selecting two cards and exchanging requires about 7 times the deck of length to get to nearly random on a 52 deck set, and more on a later deck. It is because you can't ensure that you avoid leaving pairs (do this with a deck of 1,2,3,4 ... etc and shuffle and see how many consecuative pairs you have.

(b) If you loop through the deck index in the forward direction and then swap, you definately want the possibility that a card does not move. BUT this shuffle is flawed. Take a deck of 26 0 + 26 1 in that order ie. 0,0,0,0.....,0,1,1...1 and then shuffle. If you do the shuffle once and then add the first 5 cards you get about 2.55 and 2.45 for the sums as you repeat to an infinite number of tests. [i.e. shuffle the deck, sum, reset the deck] * infinity. That is a significant fraction for a casino to lose. The drift to pure randomness is asymptotic.

(c) Use the algorithm shuffle. Depends on implementation but normally very good

(d) something that is random is this: [ well significantly better than either (a) or (b) ]

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
int deckIndex[52];
int deck[52];
for(int i=0;i<52;i++)
   deckIndex[i]=i;
 
for(int i=52;i>=1;i--)
  {
     // ugly: Use a proper random number system e.g
     // Mesene Twister. 
     const int X=rand() % i;
      deck[i-1]=deckIndex[X];
      deckIndex[X]=deckIndex[i-1];
   }
int deckIndex[52];
int deck[52];
for(int i=0;i<52;i++)
   deckIndex[i]=i;

for(int i=52;i>=1;i--)
  {
     // ugly: Use a proper random number system e.g
     // Mesene Twister. 
     const int X=rand() % i;
      deck[i-1]=deckIndex[X];
      deckIndex[X]=deckIndex[i-1];
   }

Yes you have to use another array, but it is a temp, the calls to your random number generator are expensive. If you are doing many shuffles then you don't need to regenerate deckIndex as any list works. [you can cut one off the calls to the rng. but I haven't]

Note, I had look at random_shuffle under gcc/stl and it looks like a sophisticated version of (d) -- but I am not 100% certain of that.

Last edited by StuXYZ; Apr 15th, 2009 at 5:35 pm.

experience is the most expensive way to learn anything