DaniWeb Forum Index > Software Development > C

You'd think I would know how to use strings by now, but...

Please support our C advertiser: Programming Forums - DaniWeb Sister Site

Thread Solved

•

Join Date: Apr 2006

Posts: 357

Reputation: death_oclock will become famous soon enough

Solved Threads: 37

death_oclock death_oclock is offline

Offline

Posting Whiz

You'd think I would know how to use strings by now, but...

Apr 19th, 2009

I'm getting an error (unhandled exception writing address so and so) trying to modify a string. It gets weirder though. Let me show what i've got:

--Main.c--

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
#include "stdafx.h"
#include "commands.h"
 
int main(int argc, char* argv[])
{
	char word[256];
	int id;
 
	strcpy(word, "move");
	strToUpper(word);
	printf("%s", word);
	id = getCommandId(word);
 
	if(id == -1)
		perror("Error");
	else if(id == 0)
		printf("No such command.");
	else
		printf("ID: %d\n", getCommandId("move"));
 
	getchar();
	return 0;
}
#include "stdafx.h"
#include "commands.h"

int main(int argc, char* argv[])
{
	char word[256];
	int id;

	strcpy(word, "move");
	strToUpper(word);
	printf("%s", word);
	id = getCommandId(word);

	if(id == -1)
		perror("Error");
	else if(id == 0)
		printf("No such command.");
	else
		printf("ID: %d\n", getCommandId("move"));

	getchar();
	return 0;
}

--commands.h--

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
#pragma once
 
#define COMMAND_MOVE 1
#define COMMAND_TAKE 2
#define COMMAND_LOOK 3
 
int getCommandId(char *word);
void strToUpper(char *str);
#pragma once

#define COMMAND_MOVE 1
#define COMMAND_TAKE 2
#define COMMAND_LOOK 3

int getCommandId(char *word);
void strToUpper(char *str);

And --commands.c--

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
#include "stdafx.h"
#include "commands.h"
 
void strToUpper(char *str)
{
	int i = 0;
	while(str[i] != '\0')
	{
		str[i++] &= 0xDF; //reset bit 5
	}
}
 
int getCommandId(char *word)
{
	FILE *fp;
	char buf[256];
	char *tok;
	int i = 0;
 
	fp = fopen("commands.dat", "r");
	if(fp == NULL)
		return -1;
 
	strToUpper(word);
 
	while(++i)
	{
		if(fgets(buf, 255, fp) == NULL)
			break;
 
		tok = strtok(buf, " ");
		while(tok != NULL)
		{
			if(strcmp(tok, word) == 0)
				return i;
 
			tok = strtok(NULL, " ");
		}
	}
 
	return 0;
}
#include "stdafx.h"
#include "commands.h"

void strToUpper(char *str)
{
	int i = 0;
	while(str[i] != '\0')
	{
		str[i++] &= 0xDF; //reset bit 5
	}
}

int getCommandId(char *word)
{
	FILE *fp;
	char buf[256];
	char *tok;
	int i = 0;

	fp = fopen("commands.dat", "r");
	if(fp == NULL)
		return -1;
	
	strToUpper(word);

	while(++i)
	{
		if(fgets(buf, 255, fp) == NULL)
			break;

		tok = strtok(buf, " ");
		while(tok != NULL)
		{
			if(strcmp(tok, word) == 0)
				return i;

			tok = strtok(NULL, " ");
		}
	}

	return 0;
}

Nothing real exciting happens with the call to strToUpper in main, other than the string being capitalized. Then getCommandId is called, and therefore strToUpper is too, with the same pointer word as before. Only this time, I get the nasty error described at the top of my post. Thoughts?

Last edited by death_oclock; Apr 19th, 2009 at 9:00 pm.

•

Join Date: Aug 2005

Posts: 15,648

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1498

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: You'd think I would know how to use strings by now, but...

Apr 19th, 2009

>>str[i++] &= 0xDF; //reset bit 5
Programming is not about trying to be cute, but about writing code that you and everyone else in the world can easily comprehend.
str[i] = toupper(str[i]); ++i;

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Apr 2006

Posts: 357

Reputation: death_oclock will become famous soon enough

Solved Threads: 37

death_oclock death_oclock is offline

Offline

Posting Whiz

Re: You'd think I would know how to use strings by now, but...

Apr 19th, 2009

"Being cute" was not my intention. I was thinking of efficiency at the time. And while I appreciate the suggestion, it doesn't help my immediate problem.

•

Join Date: Oct 2008

Posts: 476

Reputation: nucleon has a spectacular aura about

Solved Threads: 91

nucleon

Offline

Posting Pro in Training

Re: You'd think I would know how to use strings by now, but...

Apr 19th, 2009

Do you still get the error if you remove:
* the file stuff? (replace it with a single buf load to tokenize)
* the token stuff?
Post a single file minimal version that recreates the error.

•

Join Date: Aug 2005

Posts: 15,648

Reputation: Ancient Dragon has a reputation beyond repute

Solved Threads: 1498

Ancient Dragon Ancient Dragon is offline

Offline

Still Learning

Re: You'd think I would know how to use strings by now, but...

Apr 19th, 2009

I put your program all in one file and here is the result (using VC ++ 2008 Express)

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
#include <ctype.h>
#pragma warning(disable: 4996)
 
 
void strToUpper(char *str)
{
	int i = 0;
	while(str[i] != '\0')
	{
		str[i] = toupper(str[i]); //reset bit 5
        ++i;
	}
}
 
int getCommandId(char *word)
{
	FILE *fp;
	char buf[256];
	char *tok;
	int i = 0;
 
	fp = fopen("commands.txt", "r");
	if(fp == NULL)
		return -1;
 
	strToUpper(word);
    i = 0;
	while(fgets(buf, 255, fp) != NULL)
	{
        strToUpper(buf);
		tok = strtok(buf, " ");
        ++i;
		while(tok != NULL)
		{
			if(strcmp(tok, word) == 0)
				return i;
 
			tok = strtok(NULL, " ");
		}
	}
 
	return 0;
}
 
int main(int argc, char* argv[])
{
	char word[256];
	int id;
 
	strcpy(word, "move");
	strToUpper(word);
	printf("%s", word);
	id = getCommandId(word);
 
	if(id == -1)
		perror("Error");
	else if(id == 0)
		printf("No such command.");
	else
		printf("ID: %d\n", getCommandId("move"));
 
	getchar();
	return 0;
}
#include <ctype.h>
#pragma warning(disable: 4996)


void strToUpper(char *str)
{
	int i = 0;
	while(str[i] != '\0')
	{
		str[i] = toupper(str[i]); //reset bit 5
        ++i;
	}
}

int getCommandId(char *word)
{
	FILE *fp;
	char buf[256];
	char *tok;
	int i = 0;

	fp = fopen("commands.txt", "r");
	if(fp == NULL)
		return -1;
	
	strToUpper(word);
    i = 0;
	while(fgets(buf, 255, fp) != NULL)
	{
        strToUpper(buf);
		tok = strtok(buf, " ");
        ++i;
		while(tok != NULL)
		{
			if(strcmp(tok, word) == 0)
				return i;

			tok = strtok(NULL, " ");
		}
	}

	return 0;
}

int main(int argc, char* argv[])
{
	char word[256];
	int id;

	strcpy(word, "move");
	strToUpper(word);
	printf("%s", word);
	id = getCommandId(word);

	if(id == -1)
		perror("Error");
	else if(id == 0)
		printf("No such command.");
	else
		printf("ID: %d\n", getCommandId("move"));

	getchar();
	return 0;
}

The main problem with the program is that main() calls getComandId() twice. In the printf() line, instead of calling getCommandId() again (line 60 of the code I posted) just use the return value from the previous call.

getCommandId() also needs to close the file before exiting, which I did NOT correct.

Last edited by Ancient Dragon; Apr 19th, 2009 at 10:16 pm.

Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.

•

Join Date: Oct 2008

Posts: 476

Reputation: nucleon has a spectacular aura about

Solved Threads: 91

nucleon

Offline

Posting Pro in Training

Re: You'd think I would know how to use strings by now, but...

Apr 19th, 2009

Nice one AD!

I did not spot that call tucked away in there.
getCommandId is being called with a string literal (constant),
which it tries to modify in strToUpper:
getCommandId("move"));

•

Join Date: Apr 2006

Posts: 5,051

Reputation: John A is a splendid one to behold

Solved Threads: 332

John A

Offline

Vampirical Lurker

Re: You'd think I would know how to use strings by now, but...

Apr 19th, 2009

The real reason you're having problems with your code is you're trying to modify a string literal:
>printf("ID: %d\n", getCommandId("move"));

You never allocated space for "move", so who knows what strtok() and your strToUpper() function are trying to do with your computer's memory.

"Technological progress is like an axe in the hands of a pathological criminal."

All my posts may be freely redistributed under the terms of the MIT license.

•

Join Date: Feb 2008

Posts: 1,669

Reputation: jephthah has much to be proud of

Solved Threads: 123

jephthah

Offline

Posting Virtuoso

Re: You'd think I would know how to use strings by now, but...

Apr 19th, 2009

as an aside....

the plan to "reset bit 5" as a method to convert a string to uppercase will make for some fun times if the string ever contains a numeral or other non-alphabetical character.

It is indeed rather "cute".

Last edited by jephthah; Apr 19th, 2009 at 11:48 pm.