DaniWeb Forum Index > Web Development > PHP

Delete function acts unexpectedly

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

•

Join Date: Oct 2008

Posts: 40

Reputation: JimD C++ Newb is an unknown quantity at this point

Solved Threads: 0

JimD C++ Newb JimD C++ Newb is offline

Offline

Light Poster

Delete function acts unexpectedly

May 5th, 2009

Hello!

I have a small problem with a MySQL query inside a PHP site. If a user clicks "Yes" to delete a record, the record should be deleted (which works great)

However, when the user clicks "No", it should redirect the user to another location, leaving the record intact...but it redirects the user AND deletes the record anyway.

What am I overlooking?

Thank you in advance for any assistance!!

- Jim

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
require_once('mysql_connect.php');
if(isset($_POST['submitted'])){
if($_POST['sure'] == "Yes") {
	echo $_POST['submitted'];
	$query = "delete from movie_users where movie_users_id = '$id'";
	$result = @mysql_query ($query);
	header("Location: current_users.php");
	echo "User deleted successfully";
} elseif($_POST['sure'] == "No") {
        header("Location: not_deleted.php");
}
}
 
	?>
	<body>
	<form action="delete_user.php" method ="post">
	<div id="main">
	<p><?PHP echo "Are you sure you want to delete user $fl_name"; ?>	
	</p>
	<input type = "radio" name = "sure" value = "Yes" /> Yes
	<input type = "radio" name = "sure" value = "No" /> No</p>
	<p><input type = "submit" name = "submit" value = "submit" /> </p>
	<input type = "hidden" name = "submitted" value = "TRUE" />
	<input type = "hidden" name = "id" value = "<?php echo $id; ?>" />
	</form>
	</body>
	</div>
 
mysql_close();
<?php
include('footer.php');
 
?>
require_once('mysql_connect.php');
if(isset($_POST['submitted'])){
if($_POST['sure'] == "Yes") {
	echo $_POST['submitted'];
	$query = "delete from movie_users where movie_users_id = '$id'";
	$result = @mysql_query ($query);
	header("Location: current_users.php");
	echo "User deleted successfully";
} elseif($_POST['sure'] == "No") {
        header("Location: not_deleted.php");
}
}
		
	?>
	<body>
	<form action="delete_user.php" method ="post">
	<div id="main">
	<p><?PHP echo "Are you sure you want to delete user $fl_name"; ?>	
	</p>
	<input type = "radio" name = "sure" value = "Yes" /> Yes
	<input type = "radio" name = "sure" value = "No" /> No</p>
	<p><input type = "submit" name = "submit" value = "submit" /> </p>
	<input type = "hidden" name = "submitted" value = "TRUE" />
	<input type = "hidden" name = "id" value = "<?php echo $id; ?>" />
	</form>
	</body>
	</div>
 
mysql_close();
<?php
include('footer.php');

?>

•

Join Date: Jul 2008

Posts: 1,072

Reputation: Shanti Chepuru is on a distinguished road

Solved Threads: 98

Shanti Chepuru Shanti Chepuru is offline

Offline

Veteran Poster

Re: Delete function acts unexpectedly

May 5th, 2009

what you have written in delete_user.php file...
And your div tag is not closed properly..
Post delete_user.php file data..

Be intelligent, But Don't try to cheat.. Be innocent But Don't get cheated..

•

Join Date: Oct 2008

Posts: 40

Reputation: JimD C++ Newb is an unknown quantity at this point

Solved Threads: 0

JimD C++ Newb JimD C++ Newb is offline

Offline

Light Poster

Re: Delete function acts unexpectedly

May 5th, 2009

Oh! I found the error myself! /smackhead

<form action="delete_user.php" method ="post">

needed to be

<form action="delete_user1.php" method ="post">

I forgot that I had changed the name of the file to do some other work on it while keeping the integrity of the first file incase the changes didn't work.

Thank you!

But what is wrong with my close tag?

•

Join Date: Jul 2008

Posts: 1,072

Reputation: Shanti Chepuru is on a distinguished road

Solved Threads: 98

Shanti Chepuru Shanti Chepuru is offline

Offline

Veteran Poster

Re: Delete function acts unexpectedly

May 5th, 2009

see here , you have started a div like this :

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
<body>
	<form action="delete_user.php" method ="post">
	<div id="main">
<body>
	<form action="delete_user.php" method ="post">
	<div id="main">

But You have to Ends it like

Help with Code Tags

PHP Syntax (Toggle Plain Text)

</div></form></body>

Instead of

Help with Code Tags

PHP Syntax (Toggle Plain Text)

</form>
	</body>
	</div>

Be intelligent, But Don't try to cheat.. Be innocent But Don't get cheated..

•

Join Date: Oct 2008

Posts: 40

Reputation: JimD C++ Newb is an unknown quantity at this point

Solved Threads: 0

JimD C++ Newb JimD C++ Newb is offline

Offline

Light Poster

Re: Delete function acts unexpectedly

May 5th, 2009

Thank you for pointing out the error I didn't even see.

Everything seemed to work properly the way that I had it before, so I guess my question is...is it just good practice to close them in the reverse order you opened them, or does it really make a difference that just didn't happen to appear in this particular instance?

Thank you again

- Jim

•

Join Date: Apr 2005

Posts: 1,402

Reputation: ShawnCplus is a glorious beacon of light

Solved Threads: 225

ShawnCplus ShawnCplus is offline

Offline

Code Monkey

Re: Delete function acts unexpectedly

May 5th, 2009

•

Originally Posted by JimD C++ Newb

Thank you for pointing out the error I didn't even see.

Everything seemed to work properly the way that I had it before, so I guess my question is...is it just good practice to close them in the reverse order you opened them, or does it really make a difference that just didn't happen to appear in this particular instance?

Thank you again

- Jim

It's not that it's "good practice." That's the right way to do it, it's like asking if you should put semicolons at the end of your line. It's how HTML/XML works.

<tagopen><innertag>blah blah</innertag></tagopen> = TagOpen CONTAINS innertag CONTAINS text

NOT

<tagopen><innertag>blah blah</tagopen></innertag> = TagOpen CONTAINS START innertag CONTAINS text, END TagOpen

Last edited by ShawnCplus; May 5th, 2009 at 12:02 pm.

GCS d- s+ a-->? C++(++++) UL+++ P+>+++ L+++ E--- W+++
N+ o K w++(---) O? !M- V PS+>++ PE+ Y+ PGP !t- 5? X- R tv+
b+>++ DI+ D G++>+++ e+ h+>++ r y+
PMs asking for help will not be answered, post on the forums. That's what they're there for.