 |  |  |  |  |  |  |  |
You could have done it better, but how?
Please support our Shell Scripting advertiser: Programming Forums - DaniWeb Sister Site
 |
•
•
Join Date: Nov 2008
Posts: 22
Reputation: 
Solved Threads: 0
Newbie Poster
Hi. I have created a script that works perfect but I am now told that I could have done it better, but how?
This is an example of how I did mine:
#!/bin/bash
#
function users
{
echo "1. Password file"
echo
echo "Enter num: "
read usernumber
if [ $usernumber -eq 1 ]
then
cat /etc/passwd
else if [ $usernumber -eq 2 ]
then
cat etc/passwd
fi
fi
I have been told that I shouldn't have done it using else if but what other ways are there of doing it?
Thanks
This is an example of how I did mine:
#!/bin/bash
#
function users
{
echo "1. Password file"
echo
echo "Enter num: "
read usernumber
if [ $usernumber -eq 1 ]
then
cat /etc/passwd
else if [ $usernumber -eq 2 ]
then
cat etc/passwd
fi
fi
I have been told that I shouldn't have done it using else if but what other ways are there of doing it?
Thanks
•
•
Join Date: Dec 2005
Posts: 5,850
Reputation: 
Solved Threads: 749
Well you could have used code tags.
•
•
Join Date: Sep 2008
Posts: 61
Reputation:
Solved Threads: 7
Junior Poster in Training
Hmm... Is that the whole script? I'm not seeing the "users" function called anywhere, or even a terminating "}" for the function 
-G
-G
|
Other Threads in the Shell Scripting Forum
- Previous Thread: Testing for date in files?
- Next Thread: sed -f clears the file
| Thread Tools | Search this Thread |
You need to join our community in order to build your list of favorite forums. You can visit the forum index for a listing of all forums.
Related Forum Features
Latest Shell Scripting Posts
- Today's Posts
- Unanswered Threads
