DaniWeb Forum Index > Software Development > C++

Dynamic Memory Question

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Oct 2008

Posts: 48

Reputation: atman is an unknown quantity at this point

Solved Threads: 0

atman

Offline

Light Poster

Dynamic Memory Question

May 23rd, 2009

Hello!
I'm new in C++, and I have a basic question:

When I have a function:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
void foo(str* s){
char* p;
p = new char[strlen(s)];
strcpy(p, s);
cout << s <<endl;
 
}
void foo(str* s){
char* p;
p = new char[strlen(s)];
strcpy(p, s);
cout << s <<endl;

}

This function will take the length of s and in bytes and will allocate that much space in memory for p.
I want to do the same but ask the user to enter a string and then dynamicly allocate memory for the entered string, but it wouldnt compile for some reason, and i'd get a segmentation error. I know I can print s right away, but i want to allocate memory dynamicly in this exersize.
Here is the code I have so far:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
int main(void){
 
	char* s;
	char* p;
	cout << "Please Enter a string: ";
	cin >> s;
	p = new char[strlen(s)];
	strcpy(p, s);
	cout << p <<endl;
	return 0;
}
int main(void){

	char* s;
	char* p;
	cout << "Please Enter a string: ";
	cin >> s;
	p = new char[strlen(s)];
	strcpy(p, s);
	cout << p <<endl;
	return 0;
}

Any help would be greatly appreciated.
Thank you!

Last edited by atman; May 23rd, 2009 at 7:05 pm.

•

Join Date: Jul 2008

Posts: 2,001

Reputation: ArkM has much to be proud of

Solved Threads: 343

ArkM

Offline

Postaholic

Re: Dynamic Memory Question

May 23rd, 2009

You forgot to allocate +1 byte for zero char terminating C-string:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
p = new char[strlen(s)+1];
p = new char[strlen(s)+1];

Now you have memory leak: you forgot to deallocate this memory:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
delete [] p;
delete [] p;

Well, it's evidently useless function...

The 2nd snippet:

Help with Code Tags

C++ Syntax (Toggle Plain Text)

char* s;
...
cin >> s;

Pointer variable s is not initialized, it points to nowhere, but you are trying to get a string in this undefined memory. The 2nd error: the same as in the 1st snippet.

It's C++ program, use C++ constructs (more robust and comfortable):

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
cout << "Please Enter a string: ";
string line;
getline(cin,line);
cout << line << endl;
cout << "Please Enter a string: ";
string line;
getline(cin,line);
cout << line << endl;

Feel the difference

•

Join Date: Aug 2007

Posts: 1,679

Reputation: vmanes is a splendid one to behold

Solved Threads: 193

vmanes

Offline

Posting Virtuoso

Re: Dynamic Memory Question

May 23rd, 2009

You cannot get input to pointer s without first allocating it some memory. What you're doing is attempting to store to whatever memory address s points to, which could be pretty random!

If you've not allocated the memory, you don't control it. If you don't control it, you should not be trying to modify it.

And, when you allocate memory to hold a copy of a string, you need to use strlen( source ) +1 as the size of the new array - you've got to allow for the NULL terminator character.

Everyone's gotta believe in something. I believe I'll have another drink.
~~~~~~~~~~~~~~~~~~
Looking for an exciting graduate degree? Robotics and Intelligent Autonomous Systems (RIAS) at SDSM&T See the program brochure here.