DaniWeb Forum Index > Software Development > C++

C++ RSS

Is my homework Correct :P

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Apr 2009

Posts: 149

Reputation: gretty is an unknown quantity at this point

Solved Threads: 7

gretty

Offline

Junior Poster

Is my homework Correct :P

Aug 8th, 2009

Hello

I have this task below & I need someone to tell me if I have done it correctly. The part where I am not sure is if I am correctly checking if the array is empty.

•

Write a function to find the maximum value in an array of ints a.

int findMax(int a[], int n)
// precondition : a[0..n-1] is an array of ints
// postcondition : returns the maximum value in array or
// INT_MIN if array is empty

Recall that INT_MIN is a predefined constant indicating the minimum value of an integer.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
int findMax(int a[], int n) {
	/// Homework 2 ///
 
	int max = 0;
 
	if (n >= 0) {                // does this check if the array is empty??
		for (int i=0; i<n; i++) {
			if (a[i] > max) { max = a[i]; }
		}
		return max;
	}
	else
		return INT_MIN;          // array is empty so return INT_MIN
}
int findMax(int a[], int n) {
	/// Homework 2 ///

	int max = 0;

	if (n >= 0) {                // does this check if the array is empty??
		for (int i=0; i<n; i++) {
			if (a[i] > max) { max = a[i]; }
		}
		return max;
	}
	else
		return INT_MIN;          // array is empty so return INT_MIN
}

•

Join Date: May 2007

Posts: 1,871

Reputation: twomers has a spectacular aura about

Solved Threads: 56

twomers

Offline

Posting Virtuoso

Re: Is my homework Correct :P

Aug 8th, 2009

Consider what happens if all the numbers in the array are negative. Then the if(a[i]>max) will never return true. There are two ways you can do this. Either set max to INT_MIN or set max to a[0] and loop from 1 to n then.

I blag!?
"Mr Kitty, you have to live in the attic now. Here, write a diary."
I am the Walrus!