DaniWeb Forum Index > Web Development > PHP

Updating XML nodes using SimpleXML adds extra node

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

•

Join Date: Apr 2008

Posts: 31

Reputation: Mapper99 is an unknown quantity at this point

Solved Threads: 0

Mapper99

Offline

Light Poster

Updating XML nodes using SimpleXML adds extra node

Aug 12th, 2009

I have a very simple script that basically searches an xml file for a node based on the id of another node. I then update the node I found with a new value. For some reason my code is not performing the update. It is actually creating another node within the existing node. Any idea why?

XML:

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
 
  <?xml version="1.0" encoding="UTF-8" ?> 
- <users>
- <user>
  <id>1</id> 
  <firstname>Bob</firstname> 
  <lastname>Marley</lastname> 
  </user>
- <user>
  <id>2</id> 
  <firstname>Bruce</firstname> 
  <lastname>Springsteen</lastname> 
  </user>
  </users>
  <?xml version="1.0" encoding="UTF-8" ?> 
- <users>
- <user>
  <id>1</id> 
  <firstname>Bob</firstname> 
  <lastname>Marley</lastname> 
  </user>
- <user>
  <id>2</id> 
  <firstname>Bruce</firstname> 
  <lastname>Springsteen</lastname> 
  </user>
  </users>

PHP Code:

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
 
<?php
 
$file = "officedata.xml";
 
$xml=simplexml_load_file($file);
 
foreach ($xml->xpath('//user[id="2"]/lastname') as $desc) {
echo "$desc\n";
$desc->lastname = "Penner"; 
}
 
file_put_contents($file, $xml->asXML()); 
 
?>
<?php

$file = "officedata.xml";

$xml=simplexml_load_file($file);

foreach ($xml->xpath('//user[id="2"]/lastname') as $desc) {
echo "$desc\n";
$desc->lastname = "Penner"; 
}

file_put_contents($file, $xml->asXML()); 

?>

The updated XML looks like this:

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
 
  <?xml version="1.0" encoding="UTF-8" ?> 
- <users>
- <user>
  <id>1</id> 
  <firstname>Bob</firstname> 
  <lastname>Marley</lastname> 
  </user>
- <user>
  <id>2</id> 
  <firstname>Bruce</firstname> 
- <lastname>
  Springsteen 
  <lastname>Penner</lastname> 
  </lastname>
  </user>
  </users>
  <?xml version="1.0" encoding="UTF-8" ?> 
- <users>
- <user>
  <id>1</id> 
  <firstname>Bob</firstname> 
  <lastname>Marley</lastname> 
  </user>
- <user>
  <id>2</id> 
  <firstname>Bruce</firstname> 
- <lastname>
  Springsteen 
  <lastname>Penner</lastname> 
  </lastname>
  </user>
  </users>

•

Join Date: Aug 2007

Posts: 807

Reputation: darkagn has a spectacular aura about

Solved Threads: 110

darkagn

Offline

Practically a Posting Shark

Re: Updating XML nodes using SimpleXML adds extra node

Aug 12th, 2009

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
$desc->lastname = "Penner";
$desc->lastname = "Penner";

I believe your problem lies with this line of code. If you echo $desc to screen I think you will find that it relates to the lastname tag, not the user tag, so it is inserting a child of the lastname tag which is not what you want. If you change that line to this:

Help with Code Tags

php Syntax (Toggle Plain Text)

$desc = "Penner";

I think that will be closer to what you are after.

There are no stupid questions, only those too stupid to ask for help.
echo is a web developer's best friend.

•

Join Date: Apr 2008

Posts: 31

Reputation: Mapper99 is an unknown quantity at this point

Solved Threads: 0

Mapper99

Offline

Light Poster

Re: Updating XML nodes using SimpleXML adds extra node

Aug 12th, 2009

Thanks for your reply. When I change that line, the XML data is not updated at all. I believe that the simpleXML syntax for updating a node needs to have a certain format. Perhaps I am just setting a regular PHP variable using this syntax?