 |  |  |  |  |  |  |  |
please debug the error
Please support our C advertiser: Programming Forums - DaniWeb Sister Site
 |
C Syntax (Toggle Plain Text)
i make that program to find the maximum value. please help
Last edited by John A; Sep 5th, 2009 at 1:51 am. Reason: added code tags
•
•
Join Date: Feb 2008
Posts: 1,634
Reputation: 
Solved Threads: 122
void max(...
has no return type (it's void) but you're trying to return integers. and yet, you have the function attempting to assign a value to a long integer. why long? change it to int, and change the return type of max to int.
has no return type (it's void) but you're trying to return integers. and yet, you have the function attempting to assign a value to a long integer. why long? change it to int, and change the return type of max to int.
Last edited by jephthah; Sep 3rd, 2009 at 3:40 pm.
#include<conio.h>
#include<stdio.h>
#include<stdlib.h>
max(int a,int b,int c);
void main ()
{
clrscr();
int a,b,c,max;
long z;
printf("input three numbers by giving space");
scanf("%d %d %d",&a,&b,&c);
max=max(int a, b, c);there it is giving expression syntax
printf("Max value is %d",max);
getch();
}
max(int a ,int b,int c )
{
if(a<b&&a<c)
return(a);
if(b<c&&b<a)
return(b);
return(c);
}
#include<stdio.h>
#include<stdlib.h>
max(int a,int b,int c);
void main ()
{
clrscr();
int a,b,c,max;
long z;
printf("input three numbers by giving space");
scanf("%d %d %d",&a,&b,&c);
max=max(int a, b, c);there it is giving expression syntax
printf("Max value is %d",max);
getch();
}
max(int a ,int b,int c )
{
if(a<b&&a<c)
return(a);
if(b<c&&b<a)
return(b);
return(c);
}
•
•
Join Date: Feb 2008
Posts: 1,634
Reputation:
Solved Threads: 122
the function, max, needs to be an int.
do not put 'int' in the arguments when you call the function.
do not put 'int' in the arguments when you call the function.
•
•
Join Date: Oct 2008
Posts: 2,667
Reputation:
Solved Threads: 476
furqankhyraj,
Why don't you go get a read,
1. announcement - How to post your problems?
2. Should I used void main() or int main()?
3. Non-Portable Headers Files - conio.h, graphics.h
4. C - Functions
Use code tag to post source code.
for example,
[code=c]
statements....
[/code]
Why don't you go get a read,
1. announcement - How to post your problems?
2. Should I used void main() or int main()?
3. Non-Portable Headers Files - conio.h, graphics.h
4. C - Functions
Use code tag to post source code.
for example,
[code=c]
statements....
[/code]
•
•
Join Date: Jul 2009
Posts: 201
Reputation:
Solved Threads: 35
Posting Whiz in Training
Besides all the other "evils" in your code that others have pointed out already, the logic of your max() function in your last post is incorrect. It appears to be returning the minimum value out of the three values passed in to the function.
You should consider yourself lucky that you're even getting people responding to your thread - you have made 10 posts and you still haven't figured out how to use code tags - although that is probably the least of your problems going by the poor quality of your code. You obviously need to study the core basics of C in more detail. And if you have, then you need to study harder.
You should consider yourself lucky that you're even getting people responding to your thread - you have made 10 posts and you still haven't figured out how to use code tags - although that is probably the least of your problems going by the poor quality of your code. You obviously need to study the core basics of C in more detail. And if you have, then you need to study harder.
Manic twiddler of bits
•
•
Join Date: Sep 2009
Posts: 76
Reputation:
Solved Threads: 2
Junior Poster in Training
•
•
•
•
Originally Posted by furqankhyraj 
#inclxude<conio.h> // shoulld be #include<conio.h> #include<stdio.h> #include<stdlib.h> max(int a,int b,int c); void main (void) { clrscr(); int a,b,c,max; long z; printf("input three numbers by giving space"); // avoid spaces between arguments of scanf scanf("%d %d %d",&a,&b,&c); z=max(a,b,c); printf("Max value is %lb",z); getch(); } // when you are returning values from function need to specify the //return type // here the return type should be int as you are returning integer //value. // int max(int a ,int b,int c ) void max(int a ,int b,int c ) { if(a>b&&a>c) return(a); if(b>c&&b>a) return(b); return(c); }
i make that program to find the maximum value. please help
|
Similar Threads
- Debug Error in facebook app offline access feature (ASP.NET)
- Debug Error Run-Time Check Failure #2 (C++)
- Outlook giving a debug error (Windows Software)
- How to debug error displayed by control in design mode. (ASP.NET)
- Debug error message (Viruses, Spyware and other Nasties)
- JIT debug error (Windows NT / 2000 / XP)
- "Run time error, do you wish to debug?" (Web Browsers)
Other Threads in the C Forum
- Previous Thread: Problem working with POSIX threads
- Next Thread: Helppppppppppppppp!
| Thread Tools | Search this Thread |
You need to join our community in order to build your list of favorite forums. You can visit the forum index for a listing of all forums.
Latest C Posts
- Today's Posts
- Unanswered Threads
Related Forum Features
#include * append array arrays asterisks bash binarysearch calculate changingto char character cm copyimagefile creafecopyofanytypeoffileinc createprocess() database dynamic execv feet fgets file floatingpointvalidation fork forloop framework function getlogicaldrivestrin givemetehcodez global grade gtkwinlinux hacking histogram ide include incrementoperators input intmain() iso kernel keyboard kilometer km license linked linkedlist linux list lists locate logical_drives looping loopinsideloop. lowest matrix meter microsoft mqqueue number oddnumber odf opensource openwebfoundation overwrite owf pdf performance pointer posix probleminc process program programming radix recursion recv recvblocked research reversing scripting segmentationfault sequential single socket socketprogramming standard strchr string systemcall testing threads turboc unix urboc user variable wab whythiscodecausesegmentationfault windowsapi
