Python

Python RSS

Problem with Python Loop

•

Join Date: Dec 2007

Posts: 2

Reputation: racshot65 is an unknown quantity at this point

Solved Threads: 0

racshot65

Offline

Newbie Poster

Problem with Python Loop

Sep 21st, 2009

Hello,

This is driving me crazy so here it goes.

I'm trying to create a program that finds the 1000th prime number. This is the code I started with to check if a number is prime:

 Help with Code Tags 
 Python Syntax (Toggle Plain Text) 
numberofprimesfound = 0
numbertotest = 303
divisor = 2
 
 
if numbertotest%divisor == 0:
  print numbertotest, 'Is not a prime (broke at stage 1)'
 
else:
   while divisor < numbertotest:
    divisor = divisor +1
    if numbertotest%divisor == 0:
     print numbertotest, 'Is not a prime (broke at stage 2)'
     numbertotest = numbertotest +2
     break
    elif numbertotest%divisor <> 0:
           print numbertotest, 'Is a prime'
           numbertotest = numbertotest +2
           numberofprimesfound = numberofprimesfound +1
           break
numberofprimesfound = 0
numbertotest = 303
divisor = 2


if numbertotest%divisor == 0:
  print numbertotest, 'Is not a prime (broke at stage 1)'
  
else:
   while divisor < numbertotest:
    divisor = divisor +1
    if numbertotest%divisor == 0:
     print numbertotest, 'Is not a prime (broke at stage 2)'
     numbertotest = numbertotest +2
     break
    elif numbertotest%divisor <> 0:
           print numbertotest, 'Is a prime'
           numbertotest = numbertotest +2
           numberofprimesfound = numberofprimesfound +1
           break

This works correctly to check if any number is a prime above 3.

However when I add a while loop to find the 1000th prime it all goes wrong.

 Help with Code Tags 
 Python Syntax (Toggle Plain Text) 
numberofprimesfound = 0
numbertotest = 5
divisor = 2
 
while numberofprimesfound < 1000:
 
 if numbertotest%divisor == 0:
  numbertotest = numbertotest +2
  divisor = 2
 
 else:
 
   while divisor < numbertotest:
    divisor = divisor +1
 
    if numbertotest%divisor == 0:
     numbertotest = numbertotest +2
     divisor = 2
     break
 
    elif numbertotest%divisor <> 0:
           numbertotest = numbertotest +2
           numberofprimesfound = numberofprimesfound +1
           divisor = 2
           break
 
print 'The', numberofprimesfound,'th prime is', numbertotest
numberofprimesfound = 0
numbertotest = 5
divisor = 2

while numberofprimesfound < 1000:

 if numbertotest%divisor == 0:
  numbertotest = numbertotest +2
  divisor = 2
 
 else:
    
   while divisor < numbertotest:
    divisor = divisor +1
    
    if numbertotest%divisor == 0:
     numbertotest = numbertotest +2
     divisor = 2
     break
    
    elif numbertotest%divisor <> 0:
           numbertotest = numbertotest +2
           numberofprimesfound = numberofprimesfound +1
           divisor = 2
           break

print 'The', numberofprimesfound,'th prime is', numbertotest

The loop reports the 1000th prime to be 3003 which obviously isnt right. But I cant figure out why when the prime check works fine it all breaks when I simply add a while loop.

Any ideas?

Thanks

•

Join Date: Oct 2006

Posts: 2,273

Reputation: sneekula has a spectacular aura about

Solved Threads: 175

sneekula

Offline

Nearly a Posting Maven

Re: Problem with Python Loop

Sep 21st, 2009

At first, I would adopt consistent indentations! Very important in Python. Most people use 4 spaces.

No one died when Clinton lied.

•

Join Date: Dec 2007

Posts: 2

Reputation: racshot65 is an unknown quantity at this point

Solved Threads: 0

racshot65

Offline

Newbie Poster

Re: Problem with Python Loop

Sep 21st, 2009

Done

 Help with Code Tags 
 Python Syntax (Toggle Plain Text) 
numberofprimesfound = 0
numbertotest = 5
divisor = 2
 
while numberofprimesfound < 1000:
 
    if numbertotest%divisor == 0:
        numbertotest = numbertotest +2
        divisor = 2
 
    else:
 
        while divisor < numbertotest:
            divisor = divisor +1
 
            if numbertotest%divisor == 0:
                numbertotest = numbertotest +2
                divisor = 2
                break
 
            elif numbertotest%divisor <> 0:
                numbertotest = numbertotest +2
                numberofprimesfound = numberofprimesfound +1
                divisor = 2
                break
 
print 'The', numberofprimesfound,'th prime is', numbertotest
numberofprimesfound = 0
numbertotest = 5
divisor = 2

while numberofprimesfound < 1000:

    if numbertotest%divisor == 0:
        numbertotest = numbertotest +2
        divisor = 2

    else:
    
        while divisor < numbertotest:
            divisor = divisor +1
    
            if numbertotest%divisor == 0:
                numbertotest = numbertotest +2
                divisor = 2
                break

            elif numbertotest%divisor <> 0:
                numbertotest = numbertotest +2
                numberofprimesfound = numberofprimesfound +1
                divisor = 2
                break

print 'The', numberofprimesfound,'th prime is', numbertotest

•

Join Date: Dec 2006

Posts: 1,008

Reputation: woooee is a jewel in the rough

Solved Threads: 285

woooee

Offline

Veteran Poster

Re: Problem with Python Loop

Sep 21st, 2009

Note that you add 2 to numbertotest before you break, so the prime would have been 3001 (don't know if that really is a prime).

 Help with Code Tags 
 Python Syntax (Toggle Plain Text) 
## assume numberofprimesfound = 999
while numberofprimesfound < 1000:
   .
   .
   .
   elif numbertotest%divisor <> 0:
           numbertotest = numbertotest +2
           numberofprimesfound = numberofprimesfound +1
           divisor = 2
           break
## assume numberofprimesfound = 999
while numberofprimesfound < 1000:
   .
   .
   .
   elif numbertotest%divisor <> 0:
           numbertotest = numbertotest +2
           numberofprimesfound = numberofprimesfound +1
           divisor = 2
           break

Linux counter #99383

•

Join Date: Jul 2008

Posts: 1,046

Reputation: jlm699 is a jewel in the rough

Solved Threads: 264

jlm699

Offline

Knows where his Towel is

Re: Problem with Python Loop

Sep 21st, 2009

Your method of finding primes is flawed. Try 25, 35 and 49. None of those numbers are prime and it says that they are. Fix your indentation and your algorithm and then try to loop it again. I suggest using a function.

1. Use Code Tags.
2. Homework? Show Effort.
3. Keep discussions on the forum: no PMs