DaniWeb Forum Index > Software Development > C++

C++ RSS

Number of Variables in Constructor

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Sep 2009

Posts: 4

Reputation: Vallnerik is an unknown quantity at this point

Solved Threads: 0

Vallnerik

Offline

Newbie Poster

Number of Variables in Constructor

Sep 24th, 2009

I have a question that pertains to any programming language but since C/C++ is my primary language I'll ask it here.

I'm designing a test program that will simulate the outcome of a 12 round fight between 2 boxers. Now my question is, is there a limit or number I should shoot for in regards to the number of member variables a class should have?

Since my objects are representing people, very specific types of people, I seem to have a large number of member variables. These represent everything from first and last name to strength, stamina, speed, agility etc.

The reason I ask this, is because my constructor is very large and I have like 40 variables in the constructor initialization list. I'm just wondered if this is a common occurrence in games or in other large applications? Or is my class too bloated?

I'm doing everything all my books have told me too do as far as breaking down the parts of a person into smaller logical parts, but none of the books I have read so far delve into what to do with classes that have this many members. I just wanted to know if I'm missing some fundamental concept I should be using to address the growing number of members my classes have.

Any help or opinions would be great!
Thx

•

Join Date: Oct 2006

Posts: 2,889

Reputation: niek_e has a reputation beyond repute

Solved Threads: 302

niek_e

Offline

Cenosillicaphobiac

Re: Number of Variables in Constructor

Sep 24th, 2009

•

Originally Posted by Vallnerik

The reason I ask this, is because my constructor is very large and I have like 40 variables in the constructor initialization list. I'm just wondered if this is a common occurrence in games or in other large applications? Or is my class too bloated?

40 members are a bit too much IMO. Have you considered using more then 1 class? For example:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
class Human {
public:
    Human::Human(std::string name, std::string last_name, int age); 
private:
    std::string name;
    std::string last_name;
    int age;
    //etc
};
 
class Skills {
public:
    Skills::Skills(int att, int defense) ; 
private:
    int attack;
    int defense;
    //etc
};
 
class Boxer {
public:
    Boxer(Human* hum, Skills* sk);
private:
    Human* human;
    Skills* skills 
};
class Human {
public:
    Human::Human(std::string name, std::string last_name, int age); 
private:
    std::string name;
    std::string last_name;
    int age;
    //etc
};

class Skills {
public:
    Skills::Skills(int att, int defense) ; 
private:
    int attack;
    int defense;
    //etc
};

class Boxer {
public:
    Boxer(Human* hum, Skills* sk);
private:
    Human* human;
    Skills* skills 
};

•

Join Date: Sep 2009

Posts: 4

Reputation: Vallnerik is an unknown quantity at this point

Solved Threads: 0

Vallnerik

Offline

Newbie Poster

Re: Number of Variables in Constructor

Sep 24th, 2009

niek_e

Thank You for your response.

yes, I am currently inheriting my specialized persons classes from a more general human class, but my skills class and my attributes class are still really large. And your response brings about another question for me, should my skills class and my attributes class be nested within the more specialized boxer class or should I just use pointers in the constructor to point to them as you did?

Thx again

•

Join Date: Sep 2009

Posts: 4

Reputation: Vallnerik is an unknown quantity at this point

Solved Threads: 0

Vallnerik

Offline

Newbie Poster

Re: Number of Variables in Constructor

Sep 24th, 2009

Ahh I see why I shouldn't nest them inside the CBoxer class, because if I ever wanted to add another specialized class like CKarateMaster, I would have to nest the attributes class and the stats class within each specialized class instead of just pointing to it in the constructor. Your way future proofs it from needless over-typing.

•

Join Date: Dec 2008

Posts: 1,282

Reputation: firstPerson is just really nice

Solved Threads: 158

firstPerson firstPerson is offline

Offline

Nearly a Posting Virtuoso

Re: Number of Variables in Constructor

Sep 24th, 2009

Also you might want to think about abstract classs.

Help with Code Tags

(Toggle Plain Text)

1) What word becomes shorter if you add a letter to it? 
      [ Solved by : niek_e, Paul Thompson, SgtMe]
2) What does this sequence  equal to :  (.5u - .5a)(.5u-.5b)(.5u-.5c) ...
      [*solved by : murtan]
3) What is the 123456789 prime numer?