Overloaded + operator not working correctly.
 

I am trying to use an overloaded + operator to find the total balance for two values. I am messing up with the way to set them up, or forgetting something. I am getting values such as -9.543e2433

The code I am using for the operator is

Account operator+(Account &right)

{

Account temp;

int temp2;

temp2 = (savings + right.getchecking());

temp.setTotalBalance(temp2);

return temp;

}

I've looked for examples to see if I did it wrong, but from what I have looked at, it should have worked, unless I am not noticing something.

Any tips or suggestions on how I could go about fixing it would help me greatly.

Re: Overloaded + operator not working correctly.
 

It looks like it should work. Use your compiler's debugger and set a break point on that return statement then when the program gets to that point you can inspect the value of all the variables. If you don't know how to do that then just put some cout statements to display the variable values.

Re: Overloaded + operator not working correctly.
 

I have cout statements to show the values for them and they are showing up correctly.

I am thinking it has to do with the way I am using it, I followed an example and I may have left something out.

cout << total.getTotalBalance() << endl;

That is how I am trying to use it to find the values.

-- Edit--

I am working on a way to try and fix it, not sure if it will work. If it does, I will post it to show how I fixed it. (not quite sure it will work)

Re: Overloaded + operator not working correctly.
 

Account operator+(Account &right)



should be



Account Account::operator+(const Account &right)

Re: Overloaded + operator not working correctly.
 

If I switch it over to the way you just posted, I get the following error:

error C2662: 'getchecking' : cannot convert 'this' pointer from 'const class Account' to 'class Account &'
Conversion loses qualifiers

That is when I use this code

        Account Account::operator+(const Account &right)

        {

                Account temp;

                int temp2;

                temp2 = (savings + right.getchecking());

                temp.setTotalBalance(temp2);

                return temp;



        }

--

And the way I was trying to fix it didn't work, so back to step one, looking for what could be doing it.

-- Edit--

Looking back at that, since you input the data after running the program, none of the values are constant, which is the reason for that error I believe.

Re: Overloaded + operator not working correctly.
 

Is Account Account::operator+(const Account & rhs);
defined in Account class or is it external to the Account class?

Re: Overloaded + operator not working correctly.
 

It is defined inside of the Account class.

Re: Overloaded + operator not working correctly.
 

does getchecking() change Account in any way?

Re: Overloaded + operator not working correctly.
 

getchecking() doesn't, but TotalBalance which is a member of Account does get changed when the two values are added.


I think I know the problem, but not sure how to fix it.

The variables for savings and checking are showing up, so those are fine. However, I don't think they are getting used inside of the + operator, so its throwing out a strange number.

I've tried a few different ways of combing them, such as

CustMain = Customers[0] + Customers[1];

[CustMain would be from Customer CustMain]

and I was going to use that with the

 cout << total.getTotalBalance << endl; 

since it is what was changed in the operator.

That doesn't work though.

--Edit--

I also tried using

 cout << CustMain.getTotalBalance << endl; 

, from an example I looked at, but that just brings up quite a few errors.

Re: Overloaded + operator not working correctly.
 

I think I can clear something up, are you overloading operator=(equals operator) ?
If you are not then set your operator+ to:

Account Account::operator+(Account & right);