Overloaded + operator not working correctly.

Please support our C++ advertiser: Intel Parallel Studio Home
Thread Solved

Join Date: Feb 2008
Posts: 12
Reputation: Jaycii is an unknown quantity at this point 
Solved Threads: 0
Jaycii Jaycii is offline Offline
Newbie Poster

Overloaded + operator not working correctly.

 
0
  #1
Feb 17th, 2008
I am trying to use an overloaded + operator to find the total balance for two values. I am messing up with the way to set them up, or forgetting something. I am getting values such as -9.543e2433

The code I am using for the operator is

  1. Account operator+(Account &right)
  2. {
  3. Account temp;
  4. int temp2;
  5. temp2 = (savings + right.getchecking());
  6. temp.setTotalBalance(temp2);
  7. return temp;
  8. }

I've looked for examples to see if I did it wrong, but from what I have looked at, it should have worked, unless I am not noticing something.

Any tips or suggestions on how I could go about fixing it would help me greatly.
Reply With Quote Quick reply to this message  
Join Date: Aug 2005
Posts: 15,348
Reputation: Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute 
Solved Threads: 1461
Team Colleague
Featured Poster
Ancient Dragon's Avatar
Ancient Dragon Ancient Dragon is offline Offline
Still Learning

Re: Overloaded + operator not working correctly.

 
0
  #2
Feb 17th, 2008
It looks like it should work. Use your compiler's debugger and set a break point on that return statement then when the program gets to that point you can inspect the value of all the variables. If you don't know how to do that then just put some cout statements to display the variable values.
Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.
Reply With Quote Quick reply to this message  
Join Date: Feb 2008
Posts: 12
Reputation: Jaycii is an unknown quantity at this point 
Solved Threads: 0
Jaycii Jaycii is offline Offline
Newbie Poster

Re: Overloaded + operator not working correctly.

 
0
  #3
Feb 17th, 2008
I have cout statements to show the values for them and they are showing up correctly.

I am thinking it has to do with the way I am using it, I followed an example and I may have left something out.
  1. cout << total.getTotalBalance() << endl;

That is how I am trying to use it to find the values.

-- Edit--

I am working on a way to try and fix it, not sure if it will work. If it does, I will post it to show how I fixed it. (not quite sure it will work)
Last edited by Jaycii; Feb 17th, 2008 at 8:04 pm.
Reply With Quote Quick reply to this message  
Join Date: Jan 2008
Posts: 347
Reputation: gerard4143 is on a distinguished road 
Solved Threads: 44
gerard4143's Avatar
gerard4143 gerard4143 is offline Offline
Posting Whiz

Re: Overloaded + operator not working correctly.

 
0
  #4
Feb 17th, 2008
  1. Account operator+(Account &right)
  2.  
  3. should be
  4.  
  5. Account Account::operator+(const Account &right)
Last edited by gerard4143; Feb 17th, 2008 at 8:07 pm.
Reply With Quote Quick reply to this message  
Join Date: Feb 2008
Posts: 12
Reputation: Jaycii is an unknown quantity at this point 
Solved Threads: 0
Jaycii Jaycii is offline Offline
Newbie Poster

Re: Overloaded + operator not working correctly.

 
0
  #5
Feb 17th, 2008
If I switch it over to the way you just posted, I get the following error:

error C2662: 'getchecking' : cannot convert 'this' pointer from 'const class Account' to 'class Account &'
Conversion loses qualifiers

That is when I use this code
  1. Account Account::operator+(const Account &right)
  2. {
  3. Account temp;
  4. int temp2;
  5. temp2 = (savings + right.getchecking());
  6. temp.setTotalBalance(temp2);
  7. return temp;
  8.  
  9. }

--

And the way I was trying to fix it didn't work, so back to step one, looking for what could be doing it.

-- Edit--

Looking back at that, since you input the data after running the program, none of the values are constant, which is the reason for that error I believe.
Last edited by Jaycii; Feb 17th, 2008 at 8:14 pm.
Reply With Quote Quick reply to this message  
Join Date: Jan 2008
Posts: 347
Reputation: gerard4143 is on a distinguished road 
Solved Threads: 44
gerard4143's Avatar
gerard4143 gerard4143 is offline Offline
Posting Whiz

Re: Overloaded + operator not working correctly.

 
0
  #6
Feb 17th, 2008
Is Account Account::operator+(const Account & rhs);
defined in Account class or is it external to the Account class?
Last edited by gerard4143; Feb 17th, 2008 at 8:20 pm.
Reply With Quote Quick reply to this message  
Join Date: Feb 2008
Posts: 12
Reputation: Jaycii is an unknown quantity at this point 
Solved Threads: 0
Jaycii Jaycii is offline Offline
Newbie Poster

Re: Overloaded + operator not working correctly.

 
0
  #7
Feb 17th, 2008
It is defined inside of the Account class.
Reply With Quote Quick reply to this message  
Join Date: Jan 2008
Posts: 347
Reputation: gerard4143 is on a distinguished road 
Solved Threads: 44
gerard4143's Avatar
gerard4143 gerard4143 is offline Offline
Posting Whiz

Re: Overloaded + operator not working correctly.

 
0
  #8
Feb 17th, 2008
Originally Posted by Jaycii View Post
If I switch it over to the way you just posted, I get the following error:

error C2662: 'getchecking' : cannot convert 'this' pointer from 'const class Account' to 'class Account &'
Conversion loses qualifiers

That is when I use this code
  1. Account Account::operator+(const Account &right)
  2. {
  3. Account temp;
  4. int temp2;
  5. temp2 = (savings + right.getchecking());
  6. temp.setTotalBalance(temp2);
  7. return temp;
  8.  
  9. }


--

And the way I was trying to fix it didn't work, so back to step one, looking for what could be doing it.

-- Edit--

Looking back at that, since you input the data after running the program, none of the values are constant, which is the reason for that error I believe.
does getchecking() change Account in any way?
Reply With Quote Quick reply to this message  
Join Date: Feb 2008
Posts: 12
Reputation: Jaycii is an unknown quantity at this point 
Solved Threads: 0
Jaycii Jaycii is offline Offline
Newbie Poster

Re: Overloaded + operator not working correctly.

 
0
  #9
Feb 17th, 2008
getchecking() doesn't, but TotalBalance which is a member of Account does get changed when the two values are added.


I think I know the problem, but not sure how to fix it.

The variables for savings and checking are showing up, so those are fine. However, I don't think they are getting used inside of the + operator, so its throwing out a strange number.

I've tried a few different ways of combing them, such as

  1. CustMain = Customers[0] + Customers[1];

[CustMain would be from Customer CustMain]

and I was going to use that with the
  1. cout << total.getTotalBalance << endl;
since it is what was changed in the operator.

That doesn't work though.

--Edit--

I also tried using
  1. cout << CustMain.getTotalBalance << endl;
, from an example I looked at, but that just brings up quite a few errors.
Last edited by Jaycii; Feb 17th, 2008 at 8:43 pm.
Reply With Quote Quick reply to this message  
Join Date: Jan 2008
Posts: 347
Reputation: gerard4143 is on a distinguished road 
Solved Threads: 44
gerard4143's Avatar
gerard4143 gerard4143 is offline Offline
Posting Whiz

Re: Overloaded + operator not working correctly.

 
0
  #10
Feb 17th, 2008
I think I can clear something up, are you overloading operator=(equals operator) ?
If you are not then set your operator+ to:

Account Account::operator+(Account & right);
Last edited by gerard4143; Feb 17th, 2008 at 9:00 pm.
Reply With Quote Quick reply to this message  
Reply

This thread has been marked solved.
Perhaps start a new thread instead?
Message:



Other Threads in the C++ Forum
Thread Tools Search this Thread



About Us | Contact Us | Advertise | DaniWeb | Acceptable Use Policy | RSS Feed

©2003 - 2009 DaniWeb® LLC