DaniWeb Forum Index > Software Development > C++

C++ RSS

beginners program; can't get min value

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Sep 2004

Posts: 8

Reputation: tj is an unknown quantity at this point

Solved Threads: 0

Offline

Newbie Poster

beginners program; can't get min value

Sep 23rd, 2004

Hello all....I can't seem to figure out why the min value won't display correctly. Could someone please critique my program with out actually giving me the code.

I am so happy that I finally got my loop to work! I've been working on this all evening. It is a great satisfaction when you get something to actually work!

Here is what I came up with:

# include <iostream>
using std::cout; //program uses cout
using std::cin; //program uses cin
using std::endl; //program uses endl

//function main begins program execution
int main ( )
{
int a; //number of values in set inputed by user
int b; //number inputed by user
int c; //counter
int max=0; //highest vaule
int min=0; //lowest value

//processing phase
//get input from user
cout << "Enter the number of values in the set: "; //prompt for input
cin >> a; //read number from user

for ( c=1; c <= a; c++ ) {

cout << "Enter a number: "; //prompt for input
cin >> b; //read number from user

if (b <= max)
min = b;

if (b > max)
max = b;
}

cout << "The maximum value is: " << max << " ";
cout << "The minimum value is: " << min << " " <<endl;

return 0; //indicates that program ended successfully

} //end function main

•

Join Date: Apr 2004

Posts: 4,335

Reputation: Dave Sinkula has a brilliant future

Solved Threads: 236

Dave Sinkula Dave Sinkula is offline

Offline

long time no c

Re: beginners program; can't get min value

Sep 23rd, 2004

Help with Code Tags

(Toggle Plain Text)

      if (b <= max)
          min = b;

Perhaps you should compare the current min.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
      int max=0;	//highest vaule
 int min=0; //lowest value
      int max=0;	//highest vaule
 int min=0; //lowest value

You would probably want to initialize both to the first element in the list or else set the max to the lowest int value (INT_MIN) and the min to the highest int value (INT_MAX).

"One of the methods used by statists to destroy capitalism consists in establishing controls that tie a given industry hand and foot, making it unable to solve its problems, then declaring that freedom has failed and stronger controls are necessary." --Ayn Rand

•

Join Date: Sep 2004

Posts: 8

Reputation: tj is an unknown quantity at this point

Solved Threads: 0

Offline

Newbie Poster

Re: beginners program; can't get min value

Sep 24th, 2004

That makes more sense than what I had down. Thank you!

I tried followed the program (after corrections) via paper and it seems to work but, when I run the program on the computer it is still not comming up with the correct results.

Here is the prog again with the corrections

# include <iostream>
using std::cout; //program uses cout
using std::cin; //program uses cin
using std::endl; //program uses endl

//function main begins program execution
int main ( )
{
int a; //number of values in set inputed by user
int b; //number inputed by user
int c; //counter
int max; //highest vaule
int min; //lowest value

//initialization phase
max = b;
min = b;

//processing phase
//get input from user
cout << "Enter the number of values in the set: "; //prompt for input
cin >> a; //read number from user

for ( c=1; c <= a; c++ ) {

cout << "Enter a number: "; //prompt for imput
cin >> b; //read number from user

if (b > max)
max = b;

if (b < min)
min = b;
}
cout << "The maximum value is: " << max << "\n";
cout << "The minimum value is: " << min << " " <<endl;

return 0; //indicates that program ended successfully

} //end function main

•

Join Date: Sep 2004

Posts: 1

Reputation: kevin85 is an unknown quantity at this point

Solved Threads: 0

kevin85

Offline

Newbie Poster

Re: beginners program; can't get min value

Sep 24th, 2004

Why don't you try out this instead?
# include <iostream>
using std::cout; //program uses cout
using std::cin; //program uses cin
using std::endl; //program uses endl

//function main begins program execution
int main ( )
{
int a; //number of values in set inputed by user
int b; //number inputed by user
int c; //counter
int max; //highest vaule
int min; //lowest value

//processing phase
//get input from user
cout << "Enter the number of values in the set: "; //prompt for input
cin >> a; //read number from user

// this number is used as the starting variable considered as max value
cout << "Enter a number: "; //prompt for imput
cin >> b; //read number from user

max=b;
min=b;

int d; // create a new variable

for ( c=1; c < a; c++ ) {

cout << "Enter another number: ";
cin >> d;

if(d > max) // if the num > max, then num is bigger
max = d;

else if (d < min) // if the second num < min, then num is smaller
min = d;
}

cout << "The maximum value is: " << max << "\n";
cout << "The minimum value is: " << min << " " <<endl;

return 0; //indicates that program ended successfully

} //end function main[/QUOTE]

•

Join Date: Apr 2004

Posts: 4,335

Reputation: Dave Sinkula has a brilliant future

Solved Threads: 236

Dave Sinkula Dave Sinkula is offline

Offline

long time no c

Re: beginners program; can't get min value

Sep 24th, 2004

•

Originally Posted by mtjuarez

I tried followed the program (after corrections) via paper and it seems to work but, when I run the program on the computer it is still not comming up with the correct results.

Let's try this "on paper".

You declare 5 integer variables, but none are initialized to any value -- so their values are completely random.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
# include <iostream>
     using std::cout;	//program uses cout
     using std::cin;		//program uses cin
     using std::endl;	//program uses endl
 
    //function main begins program execution
     int main ( )
     {
        int a;		//number of values in set inputed by user
        int b;		//number inputed by user
        int c;		//counter
        int max;	//highest vaule
 int min;	//lowest value
# include <iostream>
     using std::cout;	//program uses cout
     using std::cin;		//program uses cin
     using std::endl;	//program uses endl
     
    //function main begins program execution
     int main ( )
     {
        int a;		//number of values in set inputed by user
        int b;		//number inputed by user
        int c;		//counter
        int max;	//highest vaule
 int min;	//lowest value

You initialize max and min to the unitialized value of b. So your max and min values are still random values, but both are the same random value that b had when the program started.

Help with Code Tags

C++ Syntax (Toggle Plain Text)

//initialization phase
        max = b; 
        min = b;

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
//processing phase
        //get input from user
        cout << "Enter the number of values in the set: "; //prompt for input
 cin >> a;				 //read number from user
 
    for ( c=1; c <= a; c++ ) {
//processing phase
        //get input from user
        cout << "Enter the number of values in the set: "; //prompt for input
 cin >> a;				 //read number from user
   
    for ( c=1; c <= a; c++ ) {

Now you finally get a value for b.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
cout << "Enter a number: "; 	 //prompt for imput
 cin >> b;			 	 //read number from user
cout << "Enter a number: "; 	 //prompt for imput
 cin >> b;			 	 //read number from user

Then you are comparing the value entered for b with whatever random values min and max were when the program started. Maybe this will work, maybe not.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
if (b > max)
           max = b;
 
        if (b < min)
           min = b;
if (b > max)
           max = b;
     			
        if (b < min)
           min = b;

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
}  		
     cout << "The maximum value is: " << max << "\n";
     cout << "The minimum value is: " << min << " " <<endl;
 
 
     return 0;	//indicates that program ended successfully
 
 }	//end function main
}  		
     cout << "The maximum value is: " << max << "\n";
     cout << "The minimum value is: " << min << " " <<endl;
     	
     
     return 0;	//indicates that program ended successfully
     
 }	//end function main

Here is another way to do this.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <climits> // for INT_MIN, INT_MAX
  #include <iostream>
  using std::cout;
  using std::cin;
  using std::endl;
 
  int main()
  {
     int size;  // number of values in set inputed by user
     int value; // number inputed by user
     int i;	 // counter
     int high = INT_MIN;  //highest value
     int low  = INT_MAX;  //lowest value
 
     cout << "Enter the number of values in the set: ";
     cin  >> size;
 
     for ( i = 0; i < size; i++ )
     {
  	  cout << "Enter a number: ";
  	  cin  >> value;
 
  	  if(value > high)
  	  {
  		 high = value;
  	  }
  	  if(value < low)
  	  {
  		 low = value;
  	  }
     }
     cout << "The maximum value is: " << high << "\n";
     cout << "The minimum value is: " << low  << endl;
     return 0;
  }
 
  /* my output
  Enter the number of values in the set: 5
  Enter a number: -4
  Enter a number: 9
  Enter a number: 15
  Enter a number: 2
  Enter a number: -1
  The maximum value is: 15
  The minimum value is: -4
  */
#include <climits> // for INT_MIN, INT_MAX
  #include <iostream>
  using std::cout;
  using std::cin;
  using std::endl;
  
  int main()
  {
     int size;  // number of values in set inputed by user
     int value; // number inputed by user
     int i;	 // counter
     int high = INT_MIN;  //highest value
     int low  = INT_MAX;  //lowest value
  
     cout << "Enter the number of values in the set: ";
     cin  >> size;
  
     for ( i = 0; i < size; i++ )
     {
  	  cout << "Enter a number: ";
  	  cin  >> value;
  
  	  if(value > high)
  	  {
  		 high = value;
  	  }
  	  if(value < low)
  	  {
  		 low = value;
  	  }
     }
     cout << "The maximum value is: " << high << "\n";
     cout << "The minimum value is: " << low  << endl;
     return 0;
  }
  
  /* my output
  Enter the number of values in the set: 5
  Enter a number: -4
  Enter a number: 9
  Enter a number: 15
  Enter a number: 2
  Enter a number: -1
  The maximum value is: 15
  The minimum value is: -4
  */

•

Join Date: Sep 2004

Posts: 8

Reputation: tj is an unknown quantity at this point

Solved Threads: 0

Offline

Newbie Poster

Re: beginners program; can't get min value

Sep 24th, 2004

<climits> is a new header file for me. we have only used <iostream> so far. my instructor refers to a std library occasionally; is this part of my software (i'm using microsoft visual c++ 6.0 intro edition)? Is that where I pull up headers to use?

I am going to keep playing with statements and headers and see what kind of monster I can create....lol

Thanks for your help guys!
PS
Out of curiosity...how long did it take for yall to learn C++? Did you learn it from a class or on your own?

•

Join Date: Apr 2004

Posts: 4,335

Reputation: Dave Sinkula has a brilliant future

Solved Threads: 236

Dave Sinkula Dave Sinkula is offline

Offline

long time no c

Re: beginners program; can't get min value

Sep 24th, 2004

•

Originally Posted by mtjuarez

<climits> is a new header file for me. we have only used <iostream> so far. my instructor refers to a std library occasionally; is this part of my software

Like <iostream>, <climits> is part of the standard library. Others are listed here (click on the paws if you get the "Limited Access Notice" page).

•

Originally Posted by mtjuarez