Python RSS Python RSS

need some help implementing a "continue or quit" prompt

Please support our Python advertiser: Programming Forums - DaniWeb Sister Site
Thread Solved
1 2

•
•
Join Date: Jan 2008
Posts: 17
Reputation: sigkill9 is an unknown quantity at this point 
Solved Threads: 0
sigkill9 sigkill9 is offline Offline
Newbie Poster

need some help implementing a "continue or quit" prompt

 
0
  #1
Mar 16th, 2008
I've been working on this script all weekend and am almost done with it accept for one last detail; implementing a "process another number?" prompt after a user input is processed.

The script works like this: First, the user enters a number to test (to find the two prime numbers that make up that number). Next the program finds the numbers, outputs them, then quits.

What I want to do is create a prompt after the number has been processed that asks the user if they want to try another number or quit. I tried doing this but it isnt working rite... As it is now, after the user enters yes to continue the script simply exits instead of asking the user for another number.

Here is that output:
This program finds two prime numbers that add up to any even number you enter.

Enter an even integer larger than 2: 6
========================================
Found two prime numbers that sum to 6 !
6 = 3 + 3
========================================

Would you like to try another number (yes or no)? y
>>>

Could someone please show me what i'm doing wrong and how to get it working rite?

Heres my code:
Python Syntax (Toggle Plain Text) 
  1. import math
  2. def is_prime(p):
  3.     if p == 2:
  4.         return True
  5.     else:
  6.         return prime_test(p)
  7. def is_even(n):
  8.     return n % 2 == 0
  9. def prime_test(p):
  10.     stop = int(math.ceil(math.sqrt(p))) + 1
  11.     if p % 2 == 0:
  12.         return False
  13.     else:
  14.         for i in range(3, stop, 2):
  15.             if p % i == 0:
  16.                 return False
  17.         return True # is a prime
  18. def validated_input(moredata):
  19.     while moredata[0] == "y" or moredata[0] == "Y":
  20.         input = raw_input("\nEnter an even integer larger than 2: ")
  21.         try:
  22.             n = int(input)
  23.         except ValueError:
  24.             print "*** ERROR: %s is not an integer." % input
  25.         for x in range(2, int(math.ceil(math.sqrt(n))) + 2):
  26.             if n % x == 0:
  27.                 break
  28.             if x == int(math.ceil(math.sqrt(n))) + 1:
  29.                 print "*** ERROR: %s is already prime." % input
  30.         if is_even(n):
  31.             if n > 2:
  32.                 return n
  33.             else:
  34.                 print "*** ERROR: %s is not larger than 2." % n
  35.         else:
  36.             print "*** ERROR: %s is not even." % n
  37.         return None
  38. def main():
  39.     print "This program finds two prime numbers that add up to any even number you enter."
  40.     moredata = "y"
  41.     n = validated_input(moredata)
  42.     if n:
  43.         for p in xrange(2, int(math.ceil(math.sqrt(n))) + 2):
  44.             if is_prime(p) and is_prime(n - p):
  45.                 print "="*40,"\nFound two prime numbers that sum to",n,"!"
  46.                 print n, '= %d + %d' % (p, n - p),"\n","="*40
  47.     moredata = raw_input("\nWould you like to try another number (yes or no)? ")
  48. if __name__ == '__main__':
  49.     main()
Reply With Quote Quick reply to this message  
•
•
Join Date: Oct 2004
Posts: 4,052
Reputation: vegaseat is just really nice vegaseat is just really nice vegaseat is just really nice vegaseat is just really nice vegaseat is just really nice 
Solved Threads: 935
Moderator
vegaseat's Avatar
vegaseat vegaseat is online now Online
DaniWeb's Hypocrite

Re: need some help implementing a "continue or quit" prompt

 
0
  #2
Mar 16th, 2008
Move your while loop for more data into function main(). Once you return from validated_input() it will pop out of the loop there.
May 'the Google' be with you!
Reply With Quote Quick reply to this message  
•
•
Join Date: Jan 2008
Posts: 17
Reputation: sigkill9 is an unknown quantity at this point 
Solved Threads: 0
sigkill9 sigkill9 is offline Offline
Newbie Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #3
Mar 17th, 2008
Thanks man, that helped, but theres one more small bug I need help with.

When you enter the numbers 4, 10, 16, 22, 26, (probably more) it prints out 2 findings instead of just one. Weirdness... I dont know why it's doing this, does anyone know why?

Heres the output to show you what i'm talking about. 14 worked fine, but...:

Enter an even integer larger than 2: 14
========================================
Found two prime numbers that sum to 14 !
14 = 3 + 11
========================================

Enter an even integer larger than 2: 16
========================================
Found two prime numbers that sum to 16 !
16 = 3 + 13
========================================
========================================
Found two prime numbers that sum to 16 !
16 = 5 + 11
========================================

Enter an even integer larger than 2: 22
========================================
Found two prime numbers that sum to 22 !
22 = 3 + 19
========================================
========================================
Found two prime numbers that sum to 22 !
22 = 5 + 17
========================================

It happens on some numbers, but other even numbers output only one finding... strange huh?


Heres the code as it is now:
Python Syntax (Toggle Plain Text) 
  1. import math
  2. def is_prime(p):
  3.     if p == 2:
  4.         return True
  5.     else:
  6.         return prime_test(p)
  7. def is_even(n):
  8.     return n % 2 == 0
  9. def prime_test(p):
  10.     stop = int(math.ceil(math.sqrt(p))) + 1
  11.     if p % 2 == 0:
  12.         return False
  13.     else:
  14.         for i in range(3, stop, 2):
  15.             if p % i == 0:
  16.                 return False
  17.         return True # is a prime
  18. def validated_input(moredata):
  19.         input = raw_input("\nEnter an even integer larger than 2: ")
  20.         try:
  21.             n = int(input)
  22.         except ValueError:
  23.             print "*** ERROR: %s is not an integer." % input
  24.         for x in range(2, int(math.ceil(math.sqrt(n))) + 2):
  25.             if n % x == 0:
  26.                 break
  27.             if x == int(math.ceil(math.sqrt(n))) + 1:
  28.                 print "*** ERROR: %s is already prime." % input
  29.         if is_even(n):
  30.             if n > 2:
  31.                 return n
  32.             else:
  33.                 print "*** ERROR: %s is not larger than 2." % n
  34.         else:
  35.             print "*** ERROR: %s is not even." % n
  36.         return None
  37. def main():
  38.     print "This program finds two prime numbers that add up to any even number you enter."
  39.     moredata = "y"
  40.     while moredata[0] == "y" or moredata[0] == "Y":
  41.         n = validated_input(moredata)
  42.         if n:
  43.             for p in range(2, int(math.ceil(math.sqrt(n))) + 2):
  44.                 if is_prime(p) and is_prime(n - p):
  45.                     print "="*40,"\nFound two prime numbers that sum to",n,"!"
  46.                     print n, '= %d + %d' % (p, n - p),"\n","="*40
  47.         moredata = str(raw_input("\nWould you like to try another number (yes or no)? "))
  48.  
  49.  
  50. if __name__ == '__main__':
  51.     main()
Reply With Quote Quick reply to this message  
•
•
Join Date: Jul 2006
Posts: 608
Reputation: jrcagle is on a distinguished road 
Solved Threads: 150
jrcagle jrcagle is offline Offline
Practically a Master Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #4
Mar 18th, 2008
Two different outputs on 4 are strange, yes. What two outputs are you getting?

Jeff
Reply With Quote Quick reply to this message  
•
•
Join Date: Jan 2008
Posts: 17
Reputation: sigkill9 is an unknown quantity at this point 
Solved Threads: 0
sigkill9 sigkill9 is offline Offline
Newbie Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #5
Mar 18th, 2008
The only two possible; 3+1, and 2+2
Reply With Quote Quick reply to this message  
•
•
Join Date: Aug 2005
Posts: 138
Reputation: a1eio is an unknown quantity at this point 
Solved Threads: 21
a1eio's Avatar
a1eio a1eio is offline Offline
Junior Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #6
Mar 18th, 2008
Hi,

i might be missing something, but from what i understand your program, gets an int from the user, validates it, then it enters a for loop and checks each number (p) of the loops range, to see if its prime and if the user's number minus p, is prime. If it is then it prints the results, and carries on till the end of the loop. If you only want one result for each number then break after the first result:
python Syntax (Toggle Plain Text) 
  1. if is_prime(p) and is_prime(n - p):
  2.     print "="*40,"\nFound two prime numbers that sum to",n,"!"
  3.     print n, '= %d + %d' % (p, n - p),"\n","="*40
  4.     break
However i get the feeling i'm missing some important thing about prime numbers... the solution seems too simple hehehe
Reply With Quote Quick reply to this message  
•
•
Join Date: Jan 2008
Posts: 17
Reputation: sigkill9 is an unknown quantity at this point 
Solved Threads: 0
sigkill9 sigkill9 is offline Offline
Newbie Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #7
Mar 18th, 2008
That is the down and dirty "bandaid" fix, it works. But there is another underlying issue that is causing the multiple results.
Reply With Quote Quick reply to this message  
•
•
Join Date: Jul 2006
Posts: 608
Reputation: jrcagle is on a distinguished road 
Solved Threads: 150
jrcagle jrcagle is offline Offline
Practically a Master Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #8
Mar 18th, 2008
The reason I said "strange" is that 3+1 is a false positive, since 1 is not prime.

as a1eio pointed out, you will get all possible answers with your algorithm, which is certainly mathematically interesting! (Except for the false positive issue)

Jeff
Reply With Quote Quick reply to this message  
•
•
Join Date: Jan 2008
Posts: 17
Reputation: sigkill9 is an unknown quantity at this point 
Solved Threads: 0
sigkill9 sigkill9 is offline Offline
Newbie Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #9
Mar 19th, 2008
Should I get a nobel prize? Or is it not quite that profound... lol.

I'm sure there are many other examples out there that do what mine does, I couldn't be the only one.

I'd like to fix the false positive issue, but its finals week so it will have to wait till the weekend.

In the meantime, could someone offer a solution?
Reply With Quote Quick reply to this message  
•
•
Join Date: Aug 2005
Posts: 138
Reputation: a1eio is an unknown quantity at this point 
Solved Threads: 21
a1eio's Avatar
a1eio a1eio is offline Offline
Junior Poster

Re: need some help implementing a "continue or quit" prompt

 
0
  #10
Mar 19th, 2008
there's nothing wrong with your program from what i can see, apart from it printing false positives, everything else is doing as it should, you have a loop that will find all possible values... unless you leave it after the first result.
Reply With Quote Quick reply to this message  
Reply
1 2

Quick Reply to Thread
This thread has been marked solved.
Perhaps start a new thread instead?
•
•
•
•
•
•
•
•
Message:
•
•
•
•



Other Threads in the Python Forum
Thread Tools Search this Thread



alarm assignment avogadro beginner bluetooth character cmd code customdialog cx-freeze data decimals dictionary directory dynamic error examples exe file float font format function generator gnu graphics gui halp homework http ideas import input itunes java leftmouse line linux list lists logging loop maze module mouse mysqldb number numbers output parsing path port prime programming projects push py2exe pygame pyglet pyqt python queue random recursion schedule screensaverloopinactive script scrolledtext slicenotation sqlite ssh stdout string strings sudokusolver table terminal text thread threading time tkinter tlapse tuple tutorial ubuntu unicode urllib urllib2 variable variables ventrilo verify vigenere web webservice wikipedia windows wxpython xlib
About Us | Contact Us | Advertise | DaniWeb | Acceptable Use Policy | RSS Feed

©2003 - 2009 DaniWeb® LLC