DaniWeb Forum Index > Software Development > C++

C++ RSS

bubble sort

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Apr 2008

Posts: 27

Reputation: Lotus_2011 is an unknown quantity at this point

Solved Threads: 0

Lotus_2011 Lotus_2011 is offline

Offline

Light Poster

bubble sort

May 18th, 2008

Hi,
Can anyone help me in this code bubble sort in c++,,,
this is my code.......

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
void main()
{
	int A[5]={7,2,10,15,3};
	int i,j,swap;
	for(j=0;j<5;j++)
	{
		for(i=0;i<5;i++)
		{
			if(A[i]>A[i+1])
			{
				swap=A[i];
				A[i]=A[i+1];
				A[i+1]=swap;
			}
		}
 
	}
	for(i=0;i<5;i++)
		cout<<A[i]<<endl;
 
}
void main()
{
	int A[5]={7,2,10,15,3};
	int i,j,swap;
	for(j=0;j<5;j++)
	{
		for(i=0;i<5;i++)
		{
			if(A[i]>A[i+1])
			{
				swap=A[i];
				A[i]=A[i+1];
				A[i+1]=swap;
			}
		}
		
	}
	for(i=0;i<5;i++)
		cout<<A[i]<<endl;
		
}

•

Join Date: Dec 2005

Posts: 5,850

Reputation: Salem has a reputation beyond repute

Solved Threads: 749

Salem

Offline

Void main'ers are DOOMed

Re: bubble sort

May 18th, 2008

So what's wrong with it?
- no results
- all the numbers the same?
- it isn't sorting at all?
- sorts in the wrong order?
- it doesn't compile (hint, void main is wrong to begin with).

Show some analysis of the problem as well, don't just dump the code, say "it doesn't work" and expect people to do the rest of the work (and guess what you really wanted).

•

Join Date: Apr 2007

Posts: 14

Reputation: scarface3288 is an unknown quantity at this point

Solved Threads: 1

scarface3288 scarface3288 is offline

Offline

Newbie Poster

Re: bubble sort

May 18th, 2008

is it outputting
2
7
10
3
15
I bet it is, you wonder what might be the problem now huh?

Writing out in words what your doing goes a long way

Help with Code Tags

(Toggle Plain Text)

for(j=0;j<5;j++)
{
	for(i=0;i<5;i++)
	{
		if(A[i]>A[i+1])
		{
			swap=A[i];
			A[i]=A[i+1];
			A[i+1]=swap;
		}
	}
}

to me this means:

start at address 0 of the A[i] interger array
if A[0] (which is 7 ) is greater than A[1](2) switch positions--true
then next start at A[1] (which is now 7) if A[1] greater than A[2] switch --false so it moves on
----
The problem occurs here if A[3] (15) greater than A[4] (3) switch. -- so that leaves you with the output above, the swap function you have is correct but it should not be in that conditional statement. Think harder.

Last edited by scarface3288; May 18th, 2008 at 3:41 am.

•

Join Date: Apr 2008

Posts: 296

Reputation: tesuji is on a distinguished road

Solved Threads: 42

tesuji

Offline

Posting Whiz in Training

Re: bubble sort

May 18th, 2008

http://en.wikipedia.org/wiki/Bubble_sort shows CORRECT bubble-sort algorithm.

•

Join Date: Apr 2008

Posts: 27

Reputation: Lotus_2011 is an unknown quantity at this point

Solved Threads: 0

Lotus_2011 Lotus_2011 is offline

Offline

Light Poster

Re: bubble sort

May 18th, 2008

-hi ,sorry for my way in explaning my problem.
-So I knew my default in my code ,
Its the second for loop
it should be for(i=0;i<4;i++),As i compare between A[i]&A[i+1],
-Another thing this is bubble sort