DaniWeb Forum Index > Web Development > PHP

very simple login script (checking 2 variables before writing cookie)

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

Thread Solved

•

Join Date: Oct 2006

Posts: 198

Reputation: MaxMumford is an unknown quantity at this point

Solved Threads: 1

MaxMumford MaxMumford is offline

Offline

Junior Poster

very simple login script (checking 2 variables before writing cookie)

Jun 26th, 2008

Hi all,

I have just put together a simple log in script from various tutorials on the web and at the moment it is only checking the username entered by the user against what is in my database.
I cant find any infromation about any kind of AND function or any other check the password as well as the username so thats what i need help with

here is what i have already:

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
<?php
// Connects to your Database
mysql_connect("", "", "") or die(mysql_error());
mysql_select_db("") or die(mysql_error());;
 
$uname = $_POST['uname'];
$pword = $_POST['pword'];
//gets username and password from uname and pword fields on previous page
 
$result = mysql_query("SELECT * FROM logins WHERE uname='$uname'");
 
if($row = mysql_fetch_array($result))
  {
  setcookie("loggedin", "$uname", time()+3600);
  echo "logged in as: ";
  echo $row['uname'];
  echo "<br />and cookie written.";
  echo "<br />";
  echo 'click <a href="cookie.php">here</a> to view cookie information.<br/><a href="login.php">Back to login page.</a>';
  }
else
{
echo "wrong login information";
}
?>
<?php
// Connects to your Database
mysql_connect("", "", "") or die(mysql_error());
mysql_select_db("") or die(mysql_error());;

$uname = $_POST['uname'];
$pword = $_POST['pword'];
//gets username and password from uname and pword fields on previous page

$result = mysql_query("SELECT * FROM logins WHERE uname='$uname'");

if($row = mysql_fetch_array($result))
  {
  setcookie("loggedin", "$uname", time()+3600);
  echo "logged in as: ";
  echo $row['uname'];
  echo "<br />and cookie written.";
  echo "<br />";
  echo 'click <a href="cookie.php">here</a> to view cookie information.<br/><a href="login.php">Back to login page.</a>';
  }
else
{
echo "wrong login information";
}
?>

Thanks guyyys

Max

Ill solve somebody's thread someday! xD

•

Join Date: Jun 2007

Posts: 1,227

Reputation: kkeith29 has a spectacular aura about

Solved Threads: 167

kkeith29

Offline

Nearly a Posting Virtuoso

Re: very simple login script (checking 2 variables before writing cookie)

Jun 26th, 2008

make sure sanatize your inputs to protect against sql injection.

as for the login, just change your query to:

Help with Code Tags

PHP Syntax (Toggle Plain Text)

SELECT * FROM logins WHERE uname='$uname' AND password='$pword'

also, a better way to do a login script is to see the number of results returned from the query.

ex.

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
//run query here
if (mysql_num_rows($result) == 1) {
  //then log the person in
}
else {
  //they have invalid credentials
}
//run query here
if (mysql_num_rows($result) == 1) {
  //then log the person in
}
else {
  //they have invalid credentials
}

Last edited by kkeith29; Jun 26th, 2008 at 11:50 pm.

•

Join Date: Aug 2007

Posts: 561

Reputation: ryan_vietnow is an unknown quantity at this point

Solved Threads: 71

ryan_vietnow ryan_vietnow is offline

Offline

Posting Pro

Re: very simple login script (checking 2 variables before writing cookie)

Jun 26th, 2008

you can change your query like this to validate a username with its password.

(let us say pword is your password table in db...)

replace this:

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
$result = mysql_query("SELECT * FROM logins WHERE uname='$uname'");
$result = mysql_query("SELECT * FROM logins WHERE uname='$uname'");

with something like this:

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
$result = mysql_query("SELECT * FROM logins WHERE uname='$uname' and pword='$pword'");
$result = mysql_query("SELECT * FROM logins WHERE uname='$uname' and pword='$pword'");

http://www.ryantetek.com/

•

Join Date: Aug 2007

Posts: 561

Reputation: ryan_vietnow is an unknown quantity at this point

Solved Threads: 71

ryan_vietnow ryan_vietnow is offline

Offline

Posting Pro

Re: very simple login script (checking 2 variables before writing cookie)

Jun 26th, 2008

Ahh! keith is faster than me

http://www.ryantetek.com/

•

Join Date: Oct 2006

Posts: 198

Reputation: MaxMumford is an unknown quantity at this point

Solved Threads: 1

MaxMumford MaxMumford is offline

Offline

Junior Poster

Re: very simple login script (checking 2 variables before writing cookie)

Jun 27th, 2008

ha xD Thanks guys

i swear i tried that

oh wells thanks for the help guys. and ill def. include the protection against mysql injection

now just to find out what it actually is.....

Thanks again.

Ill solve somebody's thread someday! xD

•

Join Date: May 2007

Posts: 14

Reputation: Spaiz is an unknown quantity at this point

Solved Threads: 0

Spaiz

Offline

Newbie Poster

Re: very simple login script (checking 2 variables before writing cookie)

Jun 29th, 2008

May I ask related question in here?
I was just reading around, found this thread and remembered that I always wanted to know if it's possible to query database only once, at first visit, to confirm login/pwd is correct.

Basicaly, is there a way to let user browse protected area without checking the database on every page view? (saving id in cookies is not a way

)

•

Join Date: Jun 2007

Posts: 1,227

Reputation: kkeith29 has a spectacular aura about

Solved Threads: 167

kkeith29

Offline

Nearly a Posting Virtuoso

Re: very simple login script (checking 2 variables before writing cookie)

Jun 29th, 2008

yes, use sessions.

•

Join Date: May 2007

Posts: 14

Reputation: Spaiz is an unknown quantity at this point

Solved Threads: 0

Spaiz

Offline

Newbie Poster

Re: very simple login script (checking 2 variables before writing cookie)

Jun 29th, 2008

Well, yes, sessions, but is there way to save user identification for long time? (except session in database/files/cookies)

Maybe some new clever way? I know the ordinary one's.

•

Join Date: Nov 2007

Posts: 3,744

Reputation: nav33n is a jewel in the rough

Solved Threads: 330

nav33n

Offline

Senior Poster

Re: very simple login script (checking 2 variables before writing cookie)

Jun 29th, 2008

•

Originally Posted by Spaiz

Well, yes, sessions, but is there way to save user identification for long time? (except session in database/files/cookies)

Maybe some new clever way? I know the ordinary one's.

I don't think so..

Ignorance is definitely not bliss!

*PM asking for help will be ignored*

•

Join Date: Aug 2007

Posts: 561

Reputation: ryan_vietnow is an unknown quantity at this point

Solved Threads: 71

ryan_vietnow ryan_vietnow is offline

Offline

Posting Pro

Re: very simple login script (checking 2 variables before writing cookie)

#10

Jun 29th, 2008

•

Originally Posted by Spaiz

Well, yes, sessions, but is there way to save user identification for long time? (except session in database/files/cookies)

Maybe some new clever way? I know the ordinary one's.

Try to store the ipaddress of the user and date into a new table then have a timeline for how many days/months etc. on how the id will be saved in that ipadd by subtracting current date from the stored date login...Just my idea...

http://www.ryantetek.com/