odd even numbers

Please support our C++ advertiser: Intel Parallel Studio Home
Thread Solved

Join Date: Aug 2008
Posts: 17
Reputation: bonnie1702 is on a distinguished road 
Solved Threads: 0
bonnie1702 bonnie1702 is offline Offline
Newbie Poster

odd even numbers

 
1
  #1
Aug 30th, 2008
Hi there!
I am just starting out in c++ and so far, its going ok. I have a small problem in a simple program that is frustrating me, so I am hoping someone will point me in the right direction of where I've gone wrong.
The program basically prompts the user to input two integer values, then outputs all the odd numbers between these two integer values (and their squares), and also outputs all the even numbers between the two inputted values, along with the sum of these even numbers.
I have the program working sufficiently, so long as the first value entered by the user is smaller than the second value entered. Thats the small problem I've encountered; it should not make a difference between the size of the values entered. I think i need to change the condition in the for loop, but I've tried various conditions without success
Here is the program:

#include <iostream>
#include <conio.h>
#include <iomanip>

using namespace std;

int main()
{
    int a,b,a1,b2,square; //declaring variables
    int sum = 0;
    cout << "Enter two integers: " << endl;  //user inputs two integers
    cin >> a >> b;
    cout << "The numbers entered are: " << endl;  //displays the integers listed
    cout << "1. " << a << endl;
    cout << "2. " << b << endl;        
    a1 = a;
    b2 = b;
    //for odd numbers
    cout << "The odd numbers between " << a << " and " << b << 
           ", along with their squares are:" << endl;
    for (a++;a < b;a++)
    
    {
          if ((a%2) !=0)
          {
               cout << setw(4) << a;
               square = a * a;  //formula for finding the square of an integer
               cout << " = " << square;
          } //end if
    } //end for
    cout << endl << endl;
    
    //for even numbers
    cout << "The even numbers between " << a1 << " and " << b2 << 
          " are:" << endl;
    for (a1++;a1 < b2;a1++)
    {
       if((a1%2) == 0) 
       { 
           cout << setw(4) << a1; 
           sum += a1;  //formula for finding the sum of the even integers
       } //end if    
    } //end for
    cout << endl; 
    cout << "The total sum of all the even numbers is: " << sum;
    cout << endl << endl;
    getch();
    return 0;
}//end main
Reply With Quote Quick reply to this message  
Join Date: Aug 2005
Posts: 15,445
Reputation: Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute 
Solved Threads: 1475
Team Colleague
Featured Poster
Ancient Dragon's Avatar
Ancient Dragon Ancient Dragon is online now Online
Still Learning

Re: odd even numbers

 
0
  #2
Aug 30th, 2008
After the cin statement if a < b then just swap them so that you don't have to code for that condition.
Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.
Reply With Quote Quick reply to this message  
Join Date: Jul 2008
Posts: 320
Reputation: cikara21 is an unknown quantity at this point 
Solved Threads: 63
cikara21's Avatar
cikara21 cikara21 is offline Offline
Posting Whiz

Re: odd even numbers

 
0
  #3
Aug 30th, 2008
  1. //--
Last edited by cikara21; Aug 30th, 2008 at 2:50 am.
.:-cikara21-:.
Reply With Quote Quick reply to this message  
Join Date: Aug 2005
Posts: 15,445
Reputation: Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute Ancient Dragon has a reputation beyond repute 
Solved Threads: 1475
Team Colleague
Featured Poster
Ancient Dragon's Avatar
Ancient Dragon Ancient Dragon is online now Online
Still Learning

Re: odd even numbers

 
0
  #4
Aug 30th, 2008
cikara21: Huh? Is that supposed to mean something?
Don't PM me with questions -- you might get a nasty PM in response. If you have a question then post it in one of the forums.
Reply With Quote Quick reply to this message  
Join Date: Aug 2008
Posts: 6
Reputation: entei is an unknown quantity at this point 
Solved Threads: 1
entei entei is offline Offline
Newbie Poster

Re: odd even numbers

 
0
  #5
Aug 30th, 2008
In both your 'for' loops your condition needs 'a' to be smaller than 'b', so before your 'for' loop but after your call for user input 'cin', you need a condition which checks the values entered, and then ensures that a is smaller than b

for example
//check to ensure that a is smaller than b
if(a > b)
{
	int temp = a;
	a = b;
	b = temp;
}
your code should now work fine even if a is greater than b
Reply With Quote Quick reply to this message  
Join Date: Aug 2008
Posts: 17
Reputation: bonnie1702 is on a distinguished road 
Solved Threads: 0
bonnie1702 bonnie1702 is offline Offline
Newbie Poster

Re: odd even numbers

 
0
  #6
Sep 23rd, 2008
Hi all,

Just want to say thanks for your help, sorry it took so long to get back. I got the program working just fine.

Thanks again
n.m
Reply With Quote Quick reply to this message  
Reply

This thread has been marked solved.
Perhaps start a new thread instead?
Message:


Thread Tools Search this Thread



About Us | Contact Us | Advertise | DaniWeb | Acceptable Use Policy | RSS Feed

©2003 - 2009 DaniWeb® LLC