Shell Scripting

Shell Scripting RSS

cant get shell script to work

•

Join Date: Dec 2007

Posts: 17

Reputation: yair7190 is an unknown quantity at this point

Solved Threads: 0

yair7190

Offline

Newbie Poster

cant get shell script to work

Sep 8th, 2008

hi everyone,

im trying to write a shell script that calculates memory usage of several processes (i basically run bash several times). here's the script:

 Help with Code Tags 
 bash Syntax (Toggle Plain Text) 
#!/usr/bin/bash
memUsage=`ps -ef | grep bash| awk '{sum+= $2}'`
echo $memUsage
 
 
if  $memUsage>130000000000000 ; then
        echo "mem usage exceeded"
     else
        echo "mem usage normall"
fi
exit 0
#!/usr/bin/bash
memUsage=`ps -ef | grep bash| awk '{sum+= $2}'`
echo $memUsage


if  $memUsage>130000000000000 ; then
        echo "mem usage exceeded"
     else
        echo "mem usage normall"
fi
exit 0

first of all, echo doesn't print the value of memUsage.
second of all, no matter what i enter after ">" (1, 130 or 13000000000), it always echos "mem usage exceeded" and exits.

can someone please tall what im doing wrong before i'll lose it?
thank you

Last edited by cscgal; Sep 8th, 2008 at 3:38 pm. Reason: Added code tags

•

Join Date: Feb 2006

Posts: 2,357

Reputation: masijade has much to be proud of

Solved Threads: 252

masijade

Offline

Nearly a Posting Maven

Re: cant get shell script to work

Sep 8th, 2008

First of all, you should use

 Help with Code Tags 
 Shell Scripting Syntax (Toggle Plain Text) 
ps -ef | grep bash | grep -v grep
ps -ef | grep bash | grep -v grep

otherwise you sometimes get the process for "grep bash" as well.

Also, "$2" in a ps -ef command is the ProcessId, not the memory usage. The memory usage is not printed at all in ps -ef. You need to use the o option combined with "SZ" to get the memory size (but be aware that that is the "virtual" memory size, not necessarily the amount of memory currently in use by that process).

Java Programmer and Sun Systems Administrator

----------------------------------------------

Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it.
--Brian Kernighan

•

Join Date: Dec 2007

Posts: 17

Reputation: yair7190 is an unknown quantity at this point

Solved Threads: 0

yair7190

Offline

Newbie Poster

Re: cant get shell script to work

Sep 8th, 2008

you're wright, i ignored that since my goal was to make the script work (regardless if its a PID, MEM, etc ).

still, i dont get why echo doesn't print the value of memUsage and why the if statement doesn't work.
any help appreciated

•

Join Date: Feb 2006

Posts: 2,357

Reputation: masijade has much to be proud of

Solved Threads: 252

masijade

Offline

Nearly a Posting Maven

Re: cant get shell script to work

Sep 8th, 2008

because you're awk statement doesn't produce anything. It sums, but does not print.

Edit: And I don't really know if it sums correctly. It's been ages since I've done anything with awk, so I'd have to look it up in order to be able to give you the correct syntax, and, truth be told, I don't really feel like it, right now. ;-)

Last edited by masijade; Sep 8th, 2008 at 8:56 am.

•

Join Date: Sep 2008

Posts: 61

Reputation: Gromit is an unknown quantity at this point

Solved Threads: 7

Gromit

Offline

Junior Poster in Training

Re: cant get shell script to work

Sep 8th, 2008

Try this!

ps -C bash -o pid=,size | awk '{SUM += $2} END {print SUM}'
The problem is that your awk statement doesn't have a "print" command. You have to tell it what to print.

I also took some liberties in my example, and used some built in functions of PS rather than piping it through grep

The output of that ps statement is the pid and memory usage (in KB, so the final answer is also in KB)

Hope this helps!
-G

Last edited by Gromit; Sep 8th, 2008 at 1:58 pm.

•

Join Date: Sep 2008

Posts: 61

Reputation: Gromit is an unknown quantity at this point

Solved Threads: 7

Gromit

Offline

Junior Poster in Training

Re: cant get shell script to work

Sep 8th, 2008

I poked at your original script and made some syntax changes to your "if" statement. I think it does what you want now. I think you have to use brackets when doing a comparison like this:

 Help with Code Tags 
 Shell Scripting Syntax (Toggle Plain Text) 
$ cat daniweb.sh 
#!/usr/bin/bash
memUsage=$(ps -C bash -o pid=,size|awk '{SUM += $2} END {print SUM}')
 
echo "total usage is: $memUsage"
 
if [ "$memUsage" -gt 65536 ]; then
echo "mem usage exceeded"
else
echo "mem usage normal"
fi
exit 0
$ cat daniweb.sh 
#!/usr/bin/bash
memUsage=$(ps -C bash -o pid=,size|awk '{SUM += $2} END {print SUM}')

echo "total usage is: $memUsage"

if [ "$memUsage" -gt 65536 ]; then
echo "mem usage exceeded"
else
echo "mem usage normal"
fi
exit 0

I played with different numbers in the if statement, and it seems to do the job.

Hope this helps!
-G

•

Join Date: Dec 2007

Posts: 17

Reputation: yair7190 is an unknown quantity at this point

Solved Threads: 0

yair7190

Offline

Newbie Poster

Re: cant get shell script to work

Sep 8th, 2008

thanks a lot for replaying.

thank you Gromit, your last post made me realize my mistakes.

until next time...
hope i wont be back here to soon

•

Join Date: Apr 2006

Posts: 148

Reputation: ghostdog74 is on a distinguished road

Solved Threads: 40

ghostdog74 ghostdog74 is offline

Offline

Junior Poster

Re: cant get shell script to work

Sep 15th, 2008

•

Originally Posted by Gromit

I poked at your original script and made some syntax changes to your "if" statement. I think it does what you want now. I think you have to use brackets when doing a comparison like this:
Help with Code Tags

Shell Scripting Syntax (Toggle Plain Text)
$ cat daniweb.sh 
#!/usr/bin/bash
memUsage=$(ps -C bash -o pid=,size|awk '{SUM += $2} END {print SUM}')
 
echo "total usage is: $memUsage"
 
if [ "$memUsage" -gt 65536 ]; then
echo "mem usage exceeded"
else
echo "mem usage normal"
fi
exit 0
$ cat daniweb.sh #!/usr/bin/bash memUsage=$(ps -C bash -o pid=,size|awk '{SUM += $2} END {print SUM}') echo "total usage is: $memUsage" if [ "$memUsage" -gt 65536 ]; then echo "mem usage exceeded" else echo "mem usage normal" fi exit 0
I played with different numbers in the if statement, and it seems to do the job.

Hope this helps!
-G

you can do everything in awk

 Help with Code Tags 
 Shell Scripting Syntax (Toggle Plain Text) 
ps -C bash -o size= | awk '{sum+=$1}END{ print (sum>65535 ? "exceeded":"not exceeded") }'
ps -C bash -o size= | awk '{sum+=$1}END{ print (sum>65535 ? "exceeded":"not exceeded") }'