DaniWeb Forum Index > Web Development > PHP

Simple upload script not working

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

•

Join Date: Oct 2008

Posts: 8

Reputation: twmprys is an unknown quantity at this point

Solved Threads: 0

twmprys

Offline

Newbie Poster

Simple upload script not working

Oct 13th, 2008

Sorry to ask such a stupid question, but can't understand why this simple instruction to upload a file (passed from an html form) isn't working:

move_uploaded_file($_FILES['pic']['tmp_name'], 'files/pic.jpg');

Last edited by twmprys; Oct 13th, 2008 at 11:22 am.

•

Join Date: Jul 2004

Posts: 234

Reputation: PoA is an unknown quantity at this point

Solved Threads: 8

PoA

Offline

Posting Whiz in Training

Re: Simple upload script not working

Oct 13th, 2008

Post your codes in code tag. Have you tried chmod 777 on destination folder?

•

Join Date: Oct 2008

Posts: 8

Reputation: twmprys is an unknown quantity at this point

Solved Threads: 0

twmprys

Offline

Newbie Poster

Re: Simple upload script not working

Oct 13th, 2008

Hello, thanks so much for responding. The permissions are all OK.

Here is the hmtl form(slightly truncated - with the old data from the table called up with php echos):

<form action="news2.php" enctype="multipart/form-data" method="post">
<input type=hidden name="id" VALUE='<?php echo $row['id'] ?>'><input type="hidden" name="MAX_FILE_SIZE" value="350000"><tr>
<?php echo "<img src='files/news1.jpg'>"; ?><br /><input type="hidden" name="MAX_FILE_SIZE" value="10000" />Choose picture: <input name="news1" type="file" /><?php echo $row['section1'] ?></textarea></td>

</table><p><input name="upload" type="submit" value="Upload changes">

Which is passed on to a new page:

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
<?php
$section1=$_POST['section1'];
$section2=$_POST['section2'];
$section3=$_POST['section3'];
$section4=$_POST['section4'];
$target_path = "files/";
$target_path = $target_path . basename( $_FILES['news1']['name']); 
move_uploaded_file($_FILES['news1']['tmp_name'], 'files/news1.jpg');
$con = mysql_connect("localhost","user","pass"); 
if (!$con) 
{ 
die('Can't connect: ' . mysql_error()); 
} 
mysql_select_db("database", $con);
$query = "UPDATE news SET section1='$section1', section2='$section2', section3='$section3', section4='$section4' WHERE id='$id'";
$result = mysql_query($query);
header ( 'Location: http://www.website.com/newsc.php' );
// close connection
mysql_close();
?>
<?php
$section1=$_POST['section1'];
$section2=$_POST['section2'];
$section3=$_POST['section3'];
$section4=$_POST['section4'];
$target_path = "files/";
$target_path = $target_path . basename( $_FILES['news1']['name']); 
move_uploaded_file($_FILES['news1']['tmp_name'], 'files/news1.jpg');
$con = mysql_connect("localhost","user","pass"); 
if (!$con) 
{ 
die('Can't connect: ' . mysql_error()); 
} 
mysql_select_db("database", $con);
$query = "UPDATE news SET section1='$section1', section2='$section2', section3='$section3', section4='$section4' WHERE id='$id'";
$result = mysql_query($query);
header ( 'Location: http://www.website.com/newsc.php' );
// close connection
mysql_close();
?>

Last edited by cscgal; Oct 13th, 2008 at 4:08 pm. Reason: Added code tags

•

Join Date: Jul 2004

Posts: 234

Reputation: PoA is an unknown quantity at this point

Solved Threads: 8

PoA

Offline

Posting Whiz in Training

Re: Simple upload script not working

Oct 13th, 2008

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
move_uploaded_file($_FILES['news1']['tmp_name'], 'files/news1.jpg');
move_uploaded_file($_FILES['news1']['tmp_name'], 'files/news1.jpg');

Replace files/news1.jpg with the path + image name. You need to use the full path. E.g.,

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
move_uploaded_file($_FILES['news1']['tmp_name'], '/home/<your_username>/htdocs/files/news1.jpg');
move_uploaded_file($_FILES['news1']['tmp_name'], '/home/<your_username>/htdocs/files/news1.jpg');