DaniWeb Forum Index > Software Development > C++

find the error

Please support our C++ advertiser: Intel Parallel Studio Home

•

Join Date: Feb 2008

Posts: 55

Reputation: afg_91320 is an unknown quantity at this point

Solved Threads: 0

afg_91320

Offline

Junior Poster in Training

find the error

Nov 18th, 2008

i cant seem to find what is wrong with this piece of code:
looks good to me-but my hw says it has an error in the code.

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
struct TwoVals
{
      int a = 5;
      int b = 10;
};
 
int main()
{
     TwoVals varray[1];
 
     varray.a[0] =1;
     return0;
}
struct TwoVals
{
      int a = 5;
      int b = 10;
};

int main()
{
     TwoVals varray[1];

     varray.a[0] =1;
     return0;
}

Last edited by afg_91320; Nov 18th, 2008 at 2:00 pm.

•

Join Date: Sep 2004

Posts: 7,805

Reputation: Narue has a reputation beyond repute

Solved Threads: 747

Narue

Offline

Code Goddess

Re: find the error

Nov 18th, 2008

>my hw says it has an error in the code
I count four errors. Since you mention homework, is this a homework question that you should be doing instead of trying to get other people to answer?

I'm here to prove you wrong.

•

Join Date: Feb 2008

Posts: 55

Reputation: afg_91320 is an unknown quantity at this point

Solved Threads: 0

afg_91320

Offline

Junior Poster in Training

Re: find the error

Nov 18th, 2008

well i did try

i think its missing:

#include <iostream>
using namespace std;

but i dont see any other errors

•

Join Date: Mar 2008

Posts: 370

Reputation: NinjaLink is an unknown quantity at this point

Solved Threads: 0

NinjaLink

Offline

Posting Whiz

Re: find the error

Nov 18th, 2008

system("PAUSE");
return 0;

Last edited by NinjaLink; Nov 18th, 2008 at 2:48 pm.

•

Join Date: Sep 2004

Posts: 7,805

Reputation: Narue has a reputation beyond repute

Solved Threads: 747

Narue

Offline

Code Goddess

Re: find the error

Nov 18th, 2008

•

Originally Posted by afg_91320

well i did try

i think its missing:

#include <iostream>
using namespace std;

but i dont see any other errors

•

Originally Posted by NinjaLink

system("PAUSE");
return 0;

That's just...wow. Okay afg, try compiling the code and see what your compiler thinks is wrong. You don't use anything from the iostream header or in namespace std, so including <iostream> and a using directive won't make a difference.

While NinjaLink probably fixed one of the errors by accident, you should still refrain from following his advice verbatim as it would only add more confusion to the mix by requiring a different header and opening you up to portability concerns.

And as a show of good faith, I'll point out two of the errors (which are actually caused by the same mistake):

Help with Code Tags

(Toggle Plain Text)

struct TwoVals
{
      int a = 5;
      int b = 10;
};

You can't initialize structure members directly like that unless they meet certain requirements such as being static and const. The correct way is to set up a constructor with suitable defaults:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
struct TwoVals {
  int a;
  int b;
 
  TwoVals ( int init_a = 5, int init_b = 10 )
    : a ( init_a ), b ( init_b )
  {}
};
struct TwoVals {
  int a;
  int b;

  TwoVals ( int init_a = 5, int init_b = 10 )
    : a ( init_a ), b ( init_b )
  {}
};

I'm here to prove you wrong.

•

Join Date: Oct 2008

Posts: 23

Reputation: stonerain is an unknown quantity at this point

Solved Threads: 2

stonerain

Offline

Newbie Poster

Re: find the error

Nov 18th, 2008

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
struct TwoVals
{
      int a;
      int b;
};
 
int main()
{
    TwoVals varray[ 1 ];
 
     varray[ 0 ].a = 1;   
}
struct TwoVals
{
      int a;
      int b;
};

int main()
{
    TwoVals varray[ 1 ];

     varray[ 0 ].a = 1;   
}

Or you can do as Narue said.

•

Join Date: Sep 2004

Posts: 7,805

Reputation: Narue has a reputation beyond repute

Solved Threads: 747

Narue

Offline

Code Goddess

Re: find the error

Nov 18th, 2008

stonerain, it's generally considered bad form to do people's homework for them. You'll notice that I went out of my way to encourage the OP to participate in answering the question, and you've ruined all of that work. Thanks.

I'm here to prove you wrong.