DaniWeb Forum Index > Software Development > C++

C++ RSS

Array Question

•

Join Date: Oct 2008

Posts: 18

Reputation: SQ89 is an unknown quantity at this point

Solved Threads: 0

SQ89

Offline

Newbie Poster

Array Question

Dec 3rd, 2008

I have an Array A[N]={1,2,3,4,5,6};
and I want to split it to 2 arrays of size N/2
such that B = 1, 2, 3 and C = 4, 5, 6
here is my program but there is something wrong with array C
Can you help me with it ?

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream.h>
 
void print(int X[], int newsize);
void main ()
{
	int const N=6;
	int A[N]={1,2,3,4,5,6};
	int C[N/2],B[N/2];
 
	for(int i =0;i<N;i++)
	{
 
		if(i>N/2)
		{
			int k=0;
			C[k]=A[i];
		k++;
		}
	else 
		B[i]=A[i];
	}
	print(B,N);
	cout<<endl;
	print(C,N);
}
void print(int X[],int size)
{
	int newsize;
	newsize=size/2;
	for(int i=0;i<newsize;i++)
		cout<<X[i]<<"\t";
}
#include <iostream.h>

void print(int X[], int newsize);
void main ()
{
	int const N=6;
	int A[N]={1,2,3,4,5,6};
	int C[N/2],B[N/2];

	for(int i =0;i<N;i++)
	{
		
		if(i>N/2)
		{
			int k=0;
			C[k]=A[i];
		k++;
		}
	else 
		B[i]=A[i];
	}
	print(B,N);
	cout<<endl;
	print(C,N);
}
void print(int X[],int size)
{
	int newsize;
	newsize=size/2;
	for(int i=0;i<newsize;i++)
		cout<<X[i]<<"\t";
}

•

Join Date: Jun 2008

Posts: 182

Reputation: mrboolf will become famous soon enough

Solved Threads: 18

mrboolf

Offline

Junior Poster

Re: Array Question

Dec 3rd, 2008

Some general considerations first:

1 - main must return an int, so it's int main() and not void main() . I think your compiler should have issued a warning at least. Here's an explanation of why.
2 - you use deprecated <iostream.h> instead of <iostream> . To this also your compiler should have issued a warning. Take a look at this before changing it.

Coming to the "real" errors:
1 - instead of if(i>N/2) it should be if(i>=N/2) and
2 - You initialize k to 0 every time you enter the if block, basically rewriting only the first position of the C array. Take k declaration out of the loop, like this:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
	int k=0;
	for(int i =0;i<N;i++) {
		if(i>=N/2) {
			C[k]=A[i];
			k++;
		}
		else 
			B[i]=A[i];
	}
	int k=0;
	for(int i =0;i<N;i++) {
		if(i>=N/2) {
			C[k]=A[i];
			k++;
		}
		else 
			B[i]=A[i];
	}