Originally Posted by Yiuca

You'll learn more from trial & error when playing around with code yourself, having someone else write it for you won't strengthen your ability.

I've given you the necessary code for you to be able to correct your own code. I've told you that you can't initialize a variable in a class, instead you need to use the constructor. which should be declared public & be the same name of the class without a return type specified. (eg class Badguy constructor would be "public: Badguy();" without ")

I've also displayed multiple ways of accessing private members of other classes to which all it requires from you now, is to use the code I shown you to try stuff out & learn from it, to which you will then be able to apply it to your own needs much better than if someone re-writes your actual program for you.

Last but not least, Google is your friend, need more examples... Google up tutorials on classes & friend classes/friend functions.

Originally Posted by tomtetlaw

Would this work:

Help with Code Tags

cpp Syntax (Toggle Plain Text)

 
class Badguy {
  private:
    int attributes [] = {int health, int defense, char name};
  public:
    badguy();
    int ret_val(){return attributes;};    
};
 
class Player {
  private:
    int attributes[] = {char name, int attack};
  public:
    player();
    int ret_val(){return attributes;};
    int attack() {
 
    }      
};
 
Badguy::badguy()::attributes(){health, defense, name};
Player::Player()::attributes(){name, attack};

class Badguy { private: int attributes [] = {int health, int defense, char name}; public: badguy(); int ret_val(){return attributes;}; }; class Player { private: int attributes[] = {char name, int attack}; public: player(); int ret_val(){return attributes;}; int attack() { } }; Badguy::badguy()::attributes(){health, defense, name}; Player::Player()::attributes(){name, attack};

Originally Posted by Yiuca

Have you tried compiling it & seeing for yourself? The short answer would be no & there are quite a few reasons why & since it's late & I'm tired I'll go through it quickly...

Elements of an array are the same type as the array, that is an int array only holds ints & they don't have different names, in the case of

int attributes [] = {int health, int defense, char name};

it's an invalid definition of an array & don't forget you can't initialize in a class anyway, I'd honestly vouch for taking the easier route & getting rid of attributes... Just declare

int health, defence;
string name;

instead or something similar.

You almost got the constructor call right, badguy(); is case sensetive to the class name, that is

Help with Code Tags

cpp Syntax (Toggle Plain Text)

class BadGuy
{
public:
Badguy();
}

class BadGuy { public: Badguy(); }

is different than

Help with Code Tags

cpp Syntax (Toggle Plain Text)

class BadGuy
{
public:
BaDGuY();
}

class BadGuy { public: BaDGuY(); }

to which both are invalid... On line 4: BadGuy(); would be correct however!

Help with Code Tags

cpp Syntax (Toggle Plain Text)

Badguy::badguy()::attributes(){health, defense, name};
Player::Player()::attributes(){name, attack};

Badguy::badguy()::attributes(){health, defense, name}; Player::Player()::attributes(){name, attack};

Style is, Class::Constructor():Variable(Value){};
Notice that after Constructor there is only 1 colon, the :: is a scope operator, which isn't what is wanted. Inside the blocks you can also do initialization... Example

Badguy::Badguy():health(100){};

is the same as

Badguy::Badguy(){health = 100;};

Both of those initialize health to 100.
Assume you declare int health, defence; in the Badguy class then an initializer like so would work...

Badguy::Badguy(){health = 100; defence = 100;};

Both health & defence in the class would then be 100. Try compiling the code yourself to see if it works.