DaniWeb Forum Index > Software Development > C++

Programming a fighting game?

Please support our C++ advertiser: Programming Forums - DaniWeb Sister Site

Thread Solved

•

Join Date: Dec 2008

Posts: 5

Reputation: gamerprog is an unknown quantity at this point

Solved Threads: 0

gamerprog

Offline

Newbie Poster

Programming a fighting game?

Dec 25th, 2008

I'm programming this RPG, and I can't get past the first battle. I can't figure out how to get the computer to break the loop when then enemy's health (enhp) is less than 1. I tried using an if statement, but then it didn't loop at all. Could you guys help me out?

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
 
#include <iostream>
#include <string>
using namespace std;
int main (void)
{
int num, random_integer, hp= 100, enhp= 50;
while (hp >=1 or enhp >=1)
{
{srand((unsigned)time(0));
for(int index=0; index<20; index++)
{random_integer = (rand()%10)+1;
hp = hp-random_integer;
if (hp>=1)
{cout<<"The enemy does "<<random_integer<<" damage, leaving you with "<<hp<<" health.";
cout<<"\n1)Attack!\n 2)I've had enough- run away!";
cin>>num;}
if(num ==1)
{srand((unsigned)time(0));
for(int index=0; index<20; index++)
{random_integer = (rand()%10)+1;}
enhp = enhp-random_integer;
cout<<"You have done "<<random_integer<<" damage." ;}
else
cout<<"You have fled";
}
system("PAUSE");
return 0;
}
}
}
#include <iostream>
#include <string>
using namespace std;
int main (void)
{
int num, random_integer, hp= 100, enhp= 50;
while (hp >=1 or enhp >=1)
{
{srand((unsigned)time(0));
for(int index=0; index<20; index++)
{random_integer = (rand()%10)+1;
hp = hp-random_integer;
if (hp>=1)
{cout<<"The enemy does "<<random_integer<<" damage, leaving you with "<<hp<<" health.";
cout<<"\n1)Attack!\n 2)I've had enough- run away!";
cin>>num;}
if(num ==1)
{srand((unsigned)time(0));
for(int index=0; index<20; index++)
{random_integer = (rand()%10)+1;}
enhp = enhp-random_integer;
cout<<"You have done "<<random_integer<<" damage." ;}
else
cout<<"You have fled";
}
system("PAUSE");
return 0;
}
}
}

•

Join Date: Jul 2008

Posts: 338

Reputation: cikara21 is an unknown quantity at this point

Solved Threads: 66

cikara21

Offline

Posting Whiz

Re: Programming a fighting game?

Dec 25th, 2008

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
//...
if (enhp < 1)
    break;
 
enhp = enhp-random_integer;
//...
//...
if (enhp < 1)
    break;

enhp = enhp-random_integer;
//...

$.:-cikara21-:.$

•

Join Date: May 2008

Posts: 640

Reputation: Murtan is a jewel in the rough

Solved Threads: 104

Murtan

Offline

Practically a Master Poster

Re: Programming a fighting game?

Dec 25th, 2008

Did you mean to loop until both were dead, or until one was dead?

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
while (hp >=1 or enhp >=1)
while (hp >=1 or enhp >=1)

Reads (in english) "While the player health is at least one or the enemy health is at least one, keep fighting"

I think you wanted to stop if either one died:

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
while (hp >=1 and enhp >=1)
while (hp >=1 and enhp >=1)

Reads (in english) "While the player health is at least one AND the enemy health is at least one, keep fighting"

So this loop will stop when either one is dead.

(But the break would work too.)

Last edited by Murtan; Dec 25th, 2008 at 7:11 pm.

•

Join Date: Dec 2008

Posts: 5

Reputation: gamerprog is an unknown quantity at this point

Solved Threads: 0

gamerprog

Offline

Newbie Poster

Re: Programming a fighting game?

Dec 29th, 2008

thanks, your posts have been very helpful. Unfortunately, I've noticed another problem. My else that lets the player exit the battle only works in the initialization. Do you know why that might be the case?

•

Join Date: May 2008

Posts: 640

Reputation: Murtan is a jewel in the rough

Solved Threads: 104

Murtan

Offline

Practically a Master Poster

Re: Programming a fighting game?

Dec 29th, 2008

Comments on the original code (that's all I have to look at):

You're really only supposed to call srand() once per run you don't have to call it everytime you want a random number.

In the original code, the 'I want to quit' option prints "You have fled" but it is still inside the for loop so it keeps fighting.

The outer while loop that we spent the time talking about is actually never tested. When the for loop terminates, the main() returns before the while gets a chance to be tested.

If your code has changed significantly, please re-post it.

Please use language specific code tags:
[code=c++]
//your code here
[/code]

•

Join Date: Dec 2008

Posts: 5

Reputation: gamerprog is an unknown quantity at this point

Solved Threads: 0

gamerprog

Offline

Newbie Poster

Re: Programming a fighting game?

Dec 29th, 2008

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <string>
using namespace std;
int main (void)
{
int num, random_integer, hp= 100, enhp= 50;
while (hp >=1 and enhp >=1)
{srand((unsigned)time(0));
for(int index=5; index<10; index++)
{random_integer = (rand()%10)+1;
hp = hp-random_integer;
if (hp>=1) //remember, multiline if statements require brackets to function
{cout<<"\nThe enemy does "<<random_integer<<" damage, leaving you with "<<hp<<" health.";
cout<<"\n1)Attack!\n 2)I've had enough- run away!";
cin>>num;}
else
{cout<<"You have died, better luck next time,";
system("Pause");
return 0;}
{if(num ==1)
{srand((unsigned)time(0));
for(int index=10; index<20; index++)
{random_integer = (rand()%10)+1;}
enhp = enhp-random_integer;
{if(enhp< 1)               //Victory condition. Breaks loop after enemy death
{cout<<"The masked man falls to the ground, defeated.";
break;}}
cout<<"You have done "<<random_integer<<" damage." ;}
else
{cout<<"You have fled"; break;}}}}}}
cout<<"Terrified, you run through the streets. Where is you father? If anybody'll know what to do, it'll be him.";
system("PAUSE");
return 0;
}
#include <iostream>
#include <string>
using namespace std;
int main (void)
{
int num, random_integer, hp= 100, enhp= 50;
while (hp >=1 and enhp >=1)
{srand((unsigned)time(0));
for(int index=5; index<10; index++)
{random_integer = (rand()%10)+1;
hp = hp-random_integer;
if (hp>=1) //remember, multiline if statements require brackets to function
{cout<<"\nThe enemy does "<<random_integer<<" damage, leaving you with "<<hp<<" health.";
cout<<"\n1)Attack!\n 2)I've had enough- run away!";
cin>>num;}
else
{cout<<"You have died, better luck next time,";
system("Pause");
return 0;}
{if(num ==1)
{srand((unsigned)time(0));
for(int index=10; index<20; index++)
{random_integer = (rand()%10)+1;}
enhp = enhp-random_integer;
{if(enhp< 1)               //Victory condition. Breaks loop after enemy death
{cout<<"The masked man falls to the ground, defeated.";
break;}}
cout<<"You have done "<<random_integer<<" damage." ;}
else
{cout<<"You have fled"; break;}}}}}}
cout<<"Terrified, you run through the streets. Where is you father? If anybody'll know what to do, it'll be him.";
system("PAUSE");
return 0;
}

This code won't work. All I did was copy and paste it from the larger file, and it said that it expected a declaration before the curly brace on line 30.

•

Join Date: Apr 2008

Posts: 671

Reputation: Freaky_Chris is a jewel in the rough

Solved Threads: 113

Freaky_Chris Freaky_Chris is offline

Offline

Practically a Master Poster

Re: Programming a fighting game?

Dec 29th, 2008

You're still calling srand() more than once.

Also try indenting your code and you might see your problem! Or at least stand a chance, thats too painful to try and read tbh.

Chris

Last edited by Freaky_Chris; Dec 29th, 2008 at 1:14 pm.

Knowledge is power -- But experience is everything

•

Join Date: May 2008

Posts: 640

Reputation: Murtan is a jewel in the rough

Solved Threads: 104

Murtan

Offline

Practically a Master Poster

Re: Programming a fighting game?

Dec 29th, 2008

Ok...I will do this once, feel free to re-format afterwards, but here is your code. I put each brace '{' or '}' on its own line and then begged my editor to try to make it look better.

(I made no other changes, even though it needed them.)

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <string>
using namespace std;
int main (void)
{
    int num, random_integer, hp= 100, enhp= 50;
    while (hp >=1 and enhp >=1)
    {
        srand((unsigned)time(0));
        for(int index=5; index<10; index++)
        {
            random_integer = (rand()%10)+1;
            hp = hp-random_integer;
            if (hp>=1) //remember, multiline if statements require brackets to function
            {
                cout<<"\nThe enemy does "<<random_integer<<" damage, leaving you with "<<hp<<" health.";
                cout<<"\n1)Attack!\n 2)I've had enough- run away!";
                cin>>num;
            }
            else
            {
                cout<<"You have died, better luck next time,";
                system("Pause");
                return 0;
            }
            {
                if(num ==1)
                {
                    srand((unsigned)time(0));
                    for(int index=10; index<20; index++)
                    {
                        random_integer = (rand()%10)+1;
                    }
                    enhp = enhp-random_integer;
                    {
                        if(enhp< 1)               //Victory condition. Breaks loop after enemy death
                        {
                            cout<<"The masked man falls to the ground, defeated.";
                            break;
                        }
                    }
                    cout<<"You have done "<<random_integer<<" damage." ;
                }
                else
                {
                    cout<<"You have fled"; break;
                }
            }
        }
    }
}
}
cout<<"Terrified, you run through the streets. Where is you father? If anybody'll know what to do, it'll be him.";
system("PAUSE");
return 0;
}
#include <iostream>
#include <string>
using namespace std;
int main (void)
{
    int num, random_integer, hp= 100, enhp= 50;
    while (hp >=1 and enhp >=1)
    {
        srand((unsigned)time(0));
        for(int index=5; index<10; index++)
        {
            random_integer = (rand()%10)+1;
            hp = hp-random_integer;
            if (hp>=1) //remember, multiline if statements require brackets to function
            {
                cout<<"\nThe enemy does "<<random_integer<<" damage, leaving you with "<<hp<<" health.";
                cout<<"\n1)Attack!\n 2)I've had enough- run away!";
                cin>>num;
            }
            else
            {
                cout<<"You have died, better luck next time,";
                system("Pause");
                return 0;
            }
            {
                if(num ==1)
                {
                    srand((unsigned)time(0));
                    for(int index=10; index<20; index++)
                    {
                        random_integer = (rand()%10)+1;
                    }
                    enhp = enhp-random_integer;
                    {
                        if(enhp< 1)               //Victory condition. Breaks loop after enemy death
                        {
                            cout<<"The masked man falls to the ground, defeated.";
                            break;
                        }
                    }
                    cout<<"You have done "<<random_integer<<" damage." ;
                }
                else
                {
                    cout<<"You have fled"; break;
                }
            }
        }
    }
}
}
cout<<"Terrified, you run through the streets. Where is you father? If anybody'll know what to do, it'll be him.";
system("PAUSE");
return 0;
}

As noted by the previous poster, you're still calling srand() from multiple locations and from within a loop.

I would put one call to srand() between line 6 and line 7 and then get rid of the rest.

Line 7 should read while (hp >=1 && enhp >=1)
You don't need the for loop that starts on line 10 above, the while loop on line 7 will keep you looping until someone is dead.

If you get rid of the srand() on line 29, you can replace the for loop on lines 30-33 with the one call on line 32.

You appear to have too many closing braces '}'

Try that and see what you have.

•

Join Date: Dec 2008

Posts: 5

Reputation: gamerprog is an unknown quantity at this point

Solved Threads: 0

gamerprog

Offline

Newbie Poster

Re: Programming a fighting game?

Dec 30th, 2008

I have made the suggested changes in code, and now the only error that shows up is "expected primary expression before else on the final else." Additionally I apologize for my cluttered code, I sometimes forget that I'm the only one on earth who likes reading it.

 Help with Code Tags 
 c++ Syntax (Toggle Plain Text) 
{if(num ==1)
 
      {random_integer = (rand()%10)+1;}
      enhp = enhp-random_integer;
      {
      if (enhp < 1) //Victory condition. Breaks loop after enemy death
      {
      cout<<"The masked man falls to the ground, defeated.";
      break;
      }
      else
      cout<<"You have done "<<random_integer<<" damage." ;
      }
      else
      {
      cout<<"You have fled"; 
      break;
      }
{if(num ==1)
      
      {random_integer = (rand()%10)+1;}
      enhp = enhp-random_integer;
      {
      if (enhp < 1) //Victory condition. Breaks loop after enemy death
      {
      cout<<"The masked man falls to the ground, defeated.";
      break;
      }
      else
      cout<<"You have done "<<random_integer<<" damage." ;
      }
      else
      {
      cout<<"You have fled"; 
      break;
      }