VB.NET

VB.NET RSS

vb.net 08 Show all visited websites

Please support our VB.NET advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Mar 2008

Posts: 44

Reputation: smelf1 is an unknown quantity at this point

Solved Threads: 0

smelf1

Offline

Light Poster

Re: vb.net 08 Show all visited websites

#11

Jan 8th, 2009

right changed a bit so i can now get the urls to populate in a combobox.

 Help with Code Tags 
 VB.NET Syntax (Toggle Plain Text) 
Imports System
Imports Microsoft.Win32
Imports System.Windows.Forms
 
Public Class Form1
 
    Public Function PopulateUrlList() As List(Of String)
        Dim regKey As String = "Software\Microsoft\Internet Explorer\TypedURLs"
        Dim subKey As RegistryKey = Registry.CurrentUser.OpenSubKey(regKey)
        Dim url As String
        Dim urlList As New List(Of String)()
        Dim counter As Integer = 1
        While True
            Dim sValName As String = "url" + counter.ToString()
            url = DirectCast(subKey.GetValue(sValName), String)
            If DirectCast(url, Object) Is Nothing Then
                Exit While
            End If
            urlList.Add(url)
            ComboBox1.Items.Add(url)
            counter += 1
        End While
        Return urlList
    End Function
 
    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        Call PopulateUrlList()
    End Sub
End Class
Imports System
Imports Microsoft.Win32
Imports System.Windows.Forms

Public Class Form1

    Public Function PopulateUrlList() As List(Of String)
        Dim regKey As String = "Software\Microsoft\Internet Explorer\TypedURLs"
        Dim subKey As RegistryKey = Registry.CurrentUser.OpenSubKey(regKey)
        Dim url As String
        Dim urlList As New List(Of String)()
        Dim counter As Integer = 1
        While True
            Dim sValName As String = "url" + counter.ToString()
            url = DirectCast(subKey.GetValue(sValName), String)
            If DirectCast(url, Object) Is Nothing Then
                Exit While
            End If
            urlList.Add(url)
            ComboBox1.Items.Add(url)
            counter += 1
        End While
        Return urlList
    End Function

    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        Call PopulateUrlList()
    End Sub
End Class

Is that code okay or would there be a better way to find viewed websites?

•

Join Date: Dec 2004

Posts: 2,413

Reputation: Comatose is a jewel in the rough

Solved Threads: 211

Comatose

Offline

Taboo Programmer

Re: vb.net 08 Show all visited websites

#12

Jan 8th, 2009

That code is fantastic. The only thing that I would mention about it... is that you are using the function to work with your form. On a small scale project, this is fine (and I've seen it used on large scale projects too), but keep in mind that this defeats the entire purpose of a function. Why even use a function... why not put all that code in the Button1_Click Event? The function is meant to be used to GET the list of URL's.... actually displaying them to the user is a different process... a different concept. So getting the data, and showing the data should not be combined.

 Help with Code Tags 
 vb.net Syntax (Toggle Plain Text) 
Imports System
Imports Microsoft.Win32
Imports System.Windows.Forms
 
Public Class Form1
 
    Public Function PopulateUrlList() As List(Of String)
        Dim regKey As String = "Software\Microsoft\Internet Explorer\TypedURLs"
        Dim subKey As RegistryKey = Registry.CurrentUser.OpenSubKey(regKey)
        Dim url As String
        Dim urlList As New List(Of String)()
        Dim counter As Integer = 1
        While True
            Dim sValName As String = "url" + counter.ToString()
            url = DirectCast(subKey.GetValue(sValName), String)
            If DirectCast(url, Object) Is Nothing Then
                Exit While
            End If
            urlList.Add(url)
            counter += 1
        End While
        Return urlList
    End Function
 
 Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
     dim urls as new List(of string)()
     dim I as integer
     urls =  PopulateUrlList()
 
     for  I = 0 to urls.count -1 ' maybe i = 1 to urls.count
            ComboBox1.Items.Add(url)          
     next I
    End Sub
End Class
Imports System
Imports Microsoft.Win32
Imports System.Windows.Forms

Public Class Form1

    Public Function PopulateUrlList() As List(Of String)
        Dim regKey As String = "Software\Microsoft\Internet Explorer\TypedURLs"
        Dim subKey As RegistryKey = Registry.CurrentUser.OpenSubKey(regKey)
        Dim url As String
        Dim urlList As New List(Of String)()
        Dim counter As Integer = 1
        While True
            Dim sValName As String = "url" + counter.ToString()
            url = DirectCast(subKey.GetValue(sValName), String)
            If DirectCast(url, Object) Is Nothing Then
                Exit While
            End If
            urlList.Add(url)
            counter += 1
        End While
        Return urlList
    End Function

 Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
     dim urls as new List(of string)()
     dim I as integer
     urls =  PopulateUrlList()

     for  I = 0 to urls.count -1 ' maybe i = 1 to urls.count
            ComboBox1.Items.Add(url)          
     next I
    End Sub
End Class

•

Join Date: Mar 2008

Posts: 44

Reputation: smelf1 is an unknown quantity at this point

Solved Threads: 0

smelf1

Offline

Light Poster

Re: vb.net 08 Show all visited websites

#13

Jan 8th, 2009

i am only using it in a small program, but if i try your code i get (collection) a load of times in the combo box. Also it says
ComboBox1.Items.Add(urls)
url is not defined so i assume it meant to be urls

•

Join Date: Jul 2007

Posts: 276

Reputation: rapture has a spectacular aura about

Solved Threads: 37

rapture

Offline

Posting Whiz in Training

Re: vb.net 08 Show all visited websites

#14

Jan 8th, 2009

•

Originally Posted by smelf1

i am only using it in a small program, but if i try your code i get (collection) a load of times in the combo box. Also it says
ComboBox1.Items.Add(urls)
url is not defined so i assume it meant to be urls

correct, he used url in the first part and urls in the second, it should probably be

 Help with Code Tags 
 VB.NET Syntax (Toggle Plain Text) 
            ComboBox1.Items.Add(urls)
            ComboBox1.Items.Add(urls)

•

Join Date: Mar 2008

Posts: 44

Reputation: smelf1 is an unknown quantity at this point

Solved Threads: 0

smelf1

Offline

Light Poster

Re: vb.net 08 Show all visited websites

#15

Jan 8th, 2009

ah yeah i changed it to urls before hand and thats when i get (collection) numerous times in the combo box.

•

Join Date: Jul 2007

Posts: 276

Reputation: rapture has a spectacular aura about

Solved Threads: 37

rapture

Offline

Posting Whiz in Training

Re: vb.net 08 Show all visited websites

#16

Jan 8th, 2009

I'm not 10% of the programmer these other guys are, but what I do at this point is insert a breakpoint and step through the code to see where the disconnect is.

•

Join Date: Dec 2004

Posts: 2,413

Reputation: Comatose is a jewel in the rough

Solved Threads: 211

Comatose

Offline

Taboo Programmer

Re: vb.net 08 Show all visited websites

#17

Jan 8th, 2009

No No, It was faulty code

 Help with Code Tags 
 vb.net Syntax (Toggle Plain Text) 
dim urls as new List(of string)()
dim I as integer
urls =  PopulateUrlList()
 
for  I = 0 to urls.count -1 ' maybe i = 1 to urls.count
     ComboBox1.Items.Add(urls(i))   ' // oops!
next I
dim urls as new List(of string)()
dim I as integer
urls =  PopulateUrlList()

for  I = 0 to urls.count -1 ' maybe i = 1 to urls.count
     ComboBox1.Items.Add(urls(i))   ' // oops!
next I

Last edited by Comatose; Jan 8th, 2009 at 1:52 pm.

•

Join Date: Mar 2008

Posts: 44

Reputation: smelf1 is an unknown quantity at this point

Solved Threads: 0

smelf1

Offline

Light Poster

Re: vb.net 08 Show all visited websites

#18

Jan 9th, 2009

cool thats sorted it comatose.

Thanks alot.

•

Join Date: Jun 2009

Posts: 4

Reputation: Micheal_2009 is an unknown quantity at this point

Solved Threads: 1

Micheal_2009 Micheal_2009 is offline

Offline

Newbie Poster

Re: vb.net 08 Show all visited websites

#19

Jun 18th, 2009

•

Originally Posted by Comatose

What's interesting here, is that both methods are pretty great..... but neither one of them gets the typed URL's of a browser other than IE. What about getting the history of Firefox.... Opera.... Chrome?

I know and If you were making your own IE then that would work because the Webbrowser control is basicly IE.