DaniWeb Forum Index > Web Development > PHP

if and else statement problem

Please support our PHP advertiser: PostgreSQL or MySQL? Compare and contrast the two most popular open source databases

Thread Solved

•

Join Date: Feb 2008

Posts: 52

Reputation: Scottmandoo is an unknown quantity at this point

Solved Threads: 0

Scottmandoo Scottmandoo is offline

Offline

Junior Poster in Training

if and else statement problem

Feb 3rd, 2009

in the following piece of code the else part of my if/else statements doent seem to work it just adds nothing, thanks.

btw genre is a dropbox (and yes i have added the values) and genre2 is a text box, same with the filehost and filehost2.

 Help with Code Tags 
 php Syntax (Toggle Plain Text) 
$name      = $_POST['song'];
$artist    = $_POST['artist'];
$genre     = $_POST['genre'];
$genre2    = $_POST['genre2'];
$filehost  = $_POST['filehost'];
$filehost2 = $_POST['filehost2'];
$link      = $_POST['link'];
 
if($genre="other")
{$genre=$genre2;} 
else{$genre=$genre;}
 
if($filehost="other")
{$filehost=$filehost;} 
else{$filehost=$filehost;}
 
 
	$con = mysql_connect('localhost',$username,$password);
	@mysql_select_db($database) or die( "Unable to select database");
	$sql = "INSERT INTO `songs` VALUES ('','$name','$artist','$genre','$filehost','$link')";
	$query = mysql_query($sql) or die('Error: ' . mysql_error());
$name      = $_POST['song'];
$artist    = $_POST['artist'];
$genre     = $_POST['genre'];
$genre2    = $_POST['genre2'];
$filehost  = $_POST['filehost'];
$filehost2 = $_POST['filehost2'];
$link      = $_POST['link'];

if($genre="other")
{$genre=$genre2;} 
else{$genre=$genre;}

if($filehost="other")
{$filehost=$filehost;} 
else{$filehost=$filehost;}


	$con = mysql_connect('localhost',$username,$password);
	@mysql_select_db($database) or die( "Unable to select database");
	$sql = "INSERT INTO `songs` VALUES ('','$name','$artist','$genre','$filehost','$link')";
	$query = mysql_query($sql) or die('Error: ' . mysql_error());

My Sites: SlickTunes and Loved By Design

•

Join Date: May 2008

Posts: 110

Reputation: antwan1986 is an unknown quantity at this point

Solved Threads: 8

antwan1986 antwan1986 is offline

Offline

Junior Poster

Re: if and else statement problem

Feb 3rd, 2009

Hi there,

I think the problem is the syntax in those conditional statements. In PHP, one equals sign sets a variable, but in this case you're wanting to compare two variables. This is done by two equals sign and your code should be like this:

 Help with Code Tags 
 PHP Syntax (Toggle Plain Text) 
if ($genre == "other") {
  $genre = $genre2;
} else {
  $genre = $genre;
}
 
if ($filehost == "other") {
  $filehost = $filehost2;
} else {
  $filehost = $filehost;
}
if ($genre == "other") {
  $genre = $genre2;
} else {
  $genre = $genre;
}

if ($filehost == "other") {
  $filehost = $filehost2;
} else {
  $filehost = $filehost;
}

Last edited by antwan1986; Feb 3rd, 2009 at 8:55 am.

"Beneath this mask there is more than flesh. Beneath this mask there is an idea, Mr. Creedy, and ideas are bulletproof." - V

•

Join Date: Jan 2009

Posts: 1,388

Reputation: almostbob has a spectacular aura about

Solved Threads: 168

almostbob

Online

Nearly a Posting Virtuoso

Re: if and else statement problem

Feb 3rd, 2009

both else statements are redundant
else
blue = blue

Failure is not an option It's included free, you don't have to do anything to get it
If at first you dont succeed, join the club
Of course its always in the last place you look, you dont keep looking after you find it

Please mark solved problems, solved