DaniWeb Forum Index > Software Development > C++

C++ RSS

Error with constructors(with params) of class objects inside other class

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: Jan 2008

Posts: 45

Reputation: Icebone1000 is an unknown quantity at this point

Solved Threads: 0

Icebone1000 Icebone1000 is offline

Offline

Light Poster

Error with constructors(with params) of class objects inside other class

Mar 24th, 2009

How I can do it?
I want a constructor of a object to have parameters, this object is inside other class..the compiler say the class dont have proper default constructors..(error C2512)

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
...
class Game{
 
private:
	Player P1;
	Player P2;
 
 
public:
	 Game(void);//constructor
...
...
class Game{

private:
	Player P1;
	Player P2;


public:
	 Game(void);//constructor
...

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
class Player{
private:
	int x;//player x/y position
	int y;
 
 
public:
	 Player(int _x, int _y);//constructor
	~Player(void);//destructor
 
 
};
...
Player::Player(int _x, int _y){
 
	x = _x;
	y = _y;
 
}
class Player{
private:
	int x;//player x/y position
	int y;


public:
	 Player(int _x, int _y);//constructor
	~Player(void);//destructor


};
...
Player::Player(int _x, int _y){

	x = _x;
	y = _y;

}

**EDIT**
Also, if I do that:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
class Game{
 
private:
	Player P1(10, 210);
	Player P2(310, 210);
...
class Game{

private:
	Player P1(10, 210);
	Player P2(310, 210);
...

I get "C2059: syntax error : 'constant' "

Last edited by Icebone1000; Mar 24th, 2009 at 4:30 pm.

•

Join Date: Mar 2009

Posts: 310

Reputation: NicAx64 will become famous soon enough

Solved Threads: 18

NicAx64

Offline

Posting Whiz

Re: Error with constructors(with params) of class objects inside other class

Mar 24th, 2009

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
 
#include "stdafx.h"
 
class Player{
private:
	int x;//player x/y position
	int y;
 
 
public:
	 Player(int _x, int _y);//constructor
	~Player(void);//destructor
 
 
};
 
 
Player::Player(int _x, int _y){
 
	x = _x;
	y = _y;
 
}
int main(int argc, char* argv[])
{
	printf("Hello World!\n");
 
	Player p1(10,20);
	Player p2(310,210);
 
	return 0;
}
#include "stdafx.h"

class Player{
private:
	int x;//player x/y position
	int y;


public:
	 Player(int _x, int _y);//constructor
	~Player(void);//destructor


};


Player::Player(int _x, int _y){

	x = _x;
	y = _y;

}
int main(int argc, char* argv[])
{
	printf("Hello World!\n");

	Player p1(10,20);
	Player p2(310,210);
	
	return 0;
}

I just try this sample program and it compiles without a problem.
and I just google your error. Probally you are not the only one who
get a error like this. well first search is MSDN page that contain details about this error.

it says torken error.

so sounds like it's little bit complicated to see this without looking at other source codes and dependencies.

anyway a one pice of advice , to avoid unnecessary problems always use a standard. Don't use _ starting variables. They are reserved to use internally inside the C++ compiler itself. Try it again with removing _ starting variable names.

If you need to learn about how to name your variables properly google "coding standards C++"

* you can use _ characters on variables but don't start with it.

Last edited by NicAx64; Mar 24th, 2009 at 4:49 pm. Reason: I have mentioned to remove _ contain variable names , but it should be corrected to remove _ starting variable names

Nothing like a kernel pannic !

•

Join Date: Jan 2008

Posts: 45

Reputation: Icebone1000 is an unknown quantity at this point

Solved Threads: 0

Icebone1000 Icebone1000 is offline

Offline

Light Poster

Re: Error with constructors(with params) of class objects inside other class

Mar 24th, 2009

But my Player object is inside other class ( I though that was the problem) I also using .h and .cpp files to each class...
Im attaching my files to .rar file..
It was compiling OK until I put the params on the Player constructor..
Thanks for the tips

Last edited by Icebone1000; Mar 24th, 2009 at 4:59 pm.

Attached Files

codeIceBone.zip (2.2 KB, 1 views)

•

Join Date: Mar 2009

Posts: 310

Reputation: NicAx64 will become famous soon enough

Solved Threads: 18

NicAx64

Offline

Posting Whiz

Re: Error with constructors(with params) of class objects inside other class

Mar 24th, 2009

and for your first question (C2512) , just google that error and
you will find the answer. I can't post duplicate here. It's violation of member rules.

the problem is think that , if you call

Help with Code Tags

C++ Syntax (Toggle Plain Text)

Player p;

inside main , it will looking for the default constructor and calls it.
when you overload it there is no default constructor ( there is a reason for this rule think why ? ).

Nothing like a kernel pannic !

•

Join Date: Mar 2009

Posts: 310

Reputation: NicAx64 will become famous soon enough

Solved Threads: 18

NicAx64

Offline

Posting Whiz

Re: Error with constructors(with params) of class objects inside other class

Mar 24th, 2009

•

It was compiling OK until I put the params on the Player constructor..

If you overload the default constructor then the compiler no longer put a default constructor ( this is not just a rule there is a reason for this think why ? )
So you can't say

Help with Code Tags

C++ Syntax (Toggle Plain Text)

Player p ;

Nothing like a kernel pannic !

•

Join Date: Mar 2009

Posts: 310

Reputation: NicAx64 will become famous soon enough

Solved Threads: 18

NicAx64

Offline

Posting Whiz

Re: Error with constructors(with params) of class objects inside other class

Mar 25th, 2009

IDEA:
if you want to write
[code]
Player p ;
[code]
like that you should define the default values for your overloaded constructor .Like this

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
class Player{
private:
	int x;//player x/y position
	int y;
 
 
public:
	 Player(int _x=0, int _y=0);//constructor
	~Player(void);//destructor
 
 
};
class Player{
private:
	int x;//player x/y position
	int y;


public:
	 Player(int _x=0, int _y=0);//constructor
	~Player(void);//destructor


};