DaniWeb Forum Index > Software Development > C

Linked list

Please support our C advertiser: Programming Forums - DaniWeb Sister Site

•

Join Date: Mar 2009

Posts: 6

Reputation: sat4ever0606 is an unknown quantity at this point

Solved Threads: 0

sat4ever0606 sat4ever0606 is offline

Offline

Newbie Poster

Linked list

Mar 28th, 2009

For inserting a node at the beginning y the foll code wont work?

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
struct node
{
int data;
struct node *-next;
}*head,*run,*ptr;
typedef struct node n;
void create()
{
if(head==NULL)
{
head=n*(malloc(sizeof(n));
}
else
{
ptr=n*(malloc(sizeof(n));
ptr=head;
scanf("%d",&ptr->data);
head=ptr->data;
ptr=ptr->next;
}
struct node
{
int data;
struct node *-next;
}*head,*run,*ptr;
typedef struct node n;
void create()
{
if(head==NULL)
{
head=n*(malloc(sizeof(n));
}
else
{
ptr=n*(malloc(sizeof(n));
ptr=head;
scanf("%d",&ptr->data);
head=ptr->data;
ptr=ptr->next;
}

•

Join Date: Jan 2009

Posts: 476

Reputation: csurfer is just really nice

Solved Threads: 76

csurfer

Offline

Posting Pro in Training

Re: Linked list

Mar 28th, 2009

•

Originally Posted by sat4ever0606

For inserting a node at the beginning y the foll code wont work?
Help with Code Tags

C Syntax (Toggle Plain Text)
struct node
{
int data;
struct node *-next;
}*head,*run,*ptr;
struct node { int data; struct node *-next; }*head,*run,*ptr;

Hey i think you missed out on the erreneous "-" sign behind next in

Help with Code Tags

c Syntax (Toggle Plain Text)

struct node *-next;

It should be

Help with Code Tags

c Syntax (Toggle Plain Text)

struct node * next;

And also the malloc is not used like this:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
head=n*(malloc(sizeof(n));
head=n*(malloc(sizeof(n));

it should be as this:

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
head=(n*)malloc(sizeof(n));
head=(n*)malloc(sizeof(n));

Last edited by csurfer; Mar 28th, 2009 at 1:44 pm.

I Surf in "C"....

•

Join Date: Jul 2008

Posts: 2,001

Reputation: ArkM has much to be proud of

Solved Threads: 343

ArkM

Offline

Postaholic

Re: Linked list

Mar 28th, 2009

This code does not wont work, you can't compile this code (feel the difference

Help with Code Tags

c Syntax (Toggle Plain Text)

struct node *-next; /* Why minus sign? */

Help with Code Tags

c Syntax (Toggle Plain Text)

typedef struct node n;

Well, you declare n as an alias of struct node type. Why?

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
void create() {
    ...
}
void create() {
    ...
}

These function works with declared elsewhere global variables. Why?

 Help with Code Tags 
 c Syntax (Toggle Plain Text) 
ptr=n*(malloc(sizeof(n));
ptr=head;
ptr=n*(malloc(sizeof(n));
ptr=head;

Let's forget for a minute that n is a structure type, not a number. The 1st statement allocates memory and saves a pointer to the new object in ptr pointer variable. The next statement overwrites this value immediately. Why?

And so on...
It seems you must reread your C textbook right now...

•

Join Date: Mar 2009

Posts: 6

Reputation: sat4ever0606 is an unknown quantity at this point

Solved Threads: 0

sat4ever0606 sat4ever0606 is offline

Offline

Newbie Poster

Re: Linked list

Mar 30th, 2009

fine tat was a typing mistake... ma doubt is hw 2 proceed..
first i mus allocate memory 4 creating the list right ???
so i did tat..
then the next time head is not null so i must traverse 2 d next node right so i gave such a declaration!!

•

Join Date: Apr 2006

Posts: 357

Reputation: death_oclock will become famous soon enough

Solved Threads: 37

death_oclock death_oclock is offline

Offline

Posting Whiz

Re: Linked list

Apr 1st, 2009

Lets just take a look at this code:

 Help with Code Tags 
 C Syntax (Toggle Plain Text) 
ptr=n*(malloc(sizeof(n));
ptr=head;
scanf("%d",&ptr->data);
head=ptr->data;
ptr=ptr->next;
ptr=n*(malloc(sizeof(n));
ptr=head;
scanf("%d",&ptr->data);
head=ptr->data;
ptr=ptr->next;

You don't need line 1 because you just set it to point to a space of memory that has already been allocated ( head=n*(malloc(sizeof(n)); ). Lines 2 and 3 look alright to me. Line 4 doesn't work (I sure hope that doesn't compile) because head is a pointer (to a struct node) and you are trying to assign to it a plain old integer. Since ptr and head point to the same thing, line 3 takes care of what you want. Line 5 may seem to make sense, but it actually does nothing. At the end of this function call, ptr will be deleted. A few final notes: the first time you call this function, it will only allocate memory, not load any data. And you seem to be missing a closing } for the function.