DaniWeb Forum Index > Software Development > C++

C++ RSS

Strange (extra) data in buffer after ifstream::read()

Please support our C++ advertiser: Intel Parallel Studio Home

Thread Solved

•

Join Date: May 2008

Posts: 374

Reputation: Clockowl is on a distinguished road

Solved Threads: 27

Clockowl

Offline

Posting Whiz

Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

Hey guys,

I've this code:

 Help with Code Tags 
 cpp Syntax (Toggle Plain Text) 
#include <iostream>
#include <fstream>
#include <sstream>
#include <string>
using namespace std;
 
bool load_file(const string &filepath, string &dest){
    ifstream file;
    file.open(filepath.c_str(), ios::binary);
    if(!file.good()){
        cerr << "Fatal error while opening file." << endl;
        return false;
    }
 
    //get filesize in bytes from ifstream
        //seek end, get pointer, rewind
    file.seekg(0, ios_base::end);
    size_t file_size = file.tellg();
    file.seekg(0, ios_base::beg);
    if(!file.good()){
        cerr << "Fatal error while getting filesize." << endl;
        return false;
    }
 
    //read file in string from ifstream
        //allocate array, read file in array, set string to array
    char *file_content = new char [file_size+1];
    file.read(file_content, file_size);
    cout << file_content;
    dest = file_content;
 
    //clean up
        //close file, free array
    file.close();
    delete[] file_content;
 
    return true;
}
 
 
int main(){
    string file_content;
    load_file("main.cpp", file_content);
    //cout << file_content;
 
    return 0;
}
#include <iostream>
#include <fstream>
#include <sstream>
#include <string>
using namespace std;

bool load_file(const string &filepath, string &dest){
    ifstream file;
    file.open(filepath.c_str(), ios::binary);
    if(!file.good()){
        cerr << "Fatal error while opening file." << endl;
        return false;
    }

    //get filesize in bytes from ifstream
        //seek end, get pointer, rewind
    file.seekg(0, ios_base::end);
    size_t file_size = file.tellg();
    file.seekg(0, ios_base::beg);
    if(!file.good()){
        cerr << "Fatal error while getting filesize." << endl;
        return false;
    }

    //read file in string from ifstream
        //allocate array, read file in array, set string to array
    char *file_content = new char [file_size+1];
    file.read(file_content, file_size);
    cout << file_content;
    dest = file_content;

    //clean up
        //close file, free array
    file.close();
    delete[] file_content;

    return true;
}


int main(){
    string file_content;
    load_file("main.cpp", file_content);
    //cout << file_content;

    return 0;
}

And it should read itself, but the output is slightly different:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
#include <iostream>
#include <fstream>
#include <sstream>
#include <string>
using namespace std;
 
bool load_file(const string &filepath, string &dest){
    ifstream file;
    file.open(filepath.c_str(), ios::binary);
    if(!file.good()){
        cerr << "Fatal error while opening file." << endl;
        return false;
    }
 
    //get filesize in bytes from ifstream
        //seek end, get pointer, rewind
    file.seekg(0, ios_base::end);
    size_t file_size = file.tellg();
    file.seekg(0, ios_base::beg);
    if(!file.good()){
        cerr << "Fatal error while getting filesize." << endl;
        return false;
    }
 
    //read file in string from ifstream
        //allocate array, read file in array, set string to array
    char *file_content = new char [file_size+1];
    file.read(file_content, file_size);
    cout << file_content;
    dest = file_content;
 
    //clean up
        //close file, free array
    file.close();
    delete[] file_content;
 
    return true;
}
 
 
int main(){
    string file_content;
    load_file("main.cpp", file_content);
    //cout << file_content;
 
 
    return 0;
}
 
L▬
#include <iostream>
#include <fstream>
#include <sstream>
#include <string>
using namespace std;

bool load_file(const string &filepath, string &dest){
    ifstream file;
    file.open(filepath.c_str(), ios::binary);
    if(!file.good()){
        cerr << "Fatal error while opening file." << endl;
        return false;
    }

    //get filesize in bytes from ifstream
        //seek end, get pointer, rewind
    file.seekg(0, ios_base::end);
    size_t file_size = file.tellg();
    file.seekg(0, ios_base::beg);
    if(!file.good()){
        cerr << "Fatal error while getting filesize." << endl;
        return false;
    }

    //read file in string from ifstream
        //allocate array, read file in array, set string to array
    char *file_content = new char [file_size+1];
    file.read(file_content, file_size);
    cout << file_content;
    dest = file_content;

    //clean up
        //close file, free array
    file.close();
    delete[] file_content;

    return true;
}


int main(){
    string file_content;
    load_file("main.cpp", file_content);
    //cout << file_content;


    return 0;
}

L▬

See those last couple of bytes? I have no clue where they came from, you do?

Thanks in advance,
Nick

Last edited by Clockowl; Apr 14th, 2009 at 10:45 am.

•

Join Date: Sep 2008

Posts: 90

Reputation: unbeatable0 is an unknown quantity at this point

Solved Threads: 12

unbeatable0 unbeatable0 is offline

Offline

Junior Poster in Training

Re: Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

That's weird - it works perfect for me.

•

Join Date: May 2008

Posts: 374

Reputation: Clockowl is on a distinguished road

Solved Threads: 27

Clockowl

Offline

Posting Whiz

Re: Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

It's a memory error (from the looks of it), presumably reading over EOF or forgetting the terminating null byte in the char array. If it's working for you, try adjusting the file it's reading a bit (add a comment or something).

But, I don't see where I'm doing something wrong, hahaha.

•

Join Date: Oct 2006

Posts: 2,848

Reputation: niek_e has a reputation beyond repute

Solved Threads: 299

niek_e

Online

Roasting Maven

Re: Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

One thing I spot is this:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
char *file_content = new char [file_size+1];
file.read(file_content, file_size);
char *file_content = new char [file_size+1];
file.read(file_content, file_size);

Why do you make your array one byte to big? That byte will never get a value. So when you display it, it just dumps out whatever value is on that memory address represented as a char.

Also: Why do this so difficult? If you just want to print out everything in the file use something like:

 Help with Code Tags 
 C++ Syntax (Toggle Plain Text) 
ifstream infile("filename.bla");
string str;
while (getline(infile,str)){
    cout << str << "\n";
}
ifstream infile("filename.bla");
string str;
while (getline(infile,str)){
    cout << str << "\n";
}

Last edited by niek_e; Apr 14th, 2009 at 10:55 am.

•

Join Date: May 2008

Posts: 374

Reputation: Clockowl is on a distinguished road

Solved Threads: 27

Clockowl

Offline

Posting Whiz

Re: Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

Doesn't new set the allocated memory to 0, like C's calloc() ?

Last edited by Clockowl; Apr 14th, 2009 at 10:56 am.

•

Join Date: Oct 2006

Posts: 2,848

Reputation: niek_e has a reputation beyond repute

Solved Threads: 299

niek_e

Online

Roasting Maven

Re: Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

I meant: why use char *file_content = new char [file_size+1]; instead of char *file_content = new char [file_size];
I also edited my previous post to include a small snippet and a question.

•

Join Date: May 2008

Posts: 374

Reputation: Clockowl is on a distinguished road

Solved Threads: 27

Clockowl

Offline

Posting Whiz

Re: Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

I don't want to output the whole file, I want to have the whole file in memory.

And, I used that so I can use the char array as a null-terminated string. That was the point... The file is not guaranteed to end in a null byte, is it?

Say the file is 200 bytes, I need to allocate 201 bytes, 200 for the file, 1 for the terminating null byte.

Last edited by Clockowl; Apr 14th, 2009 at 11:06 am.

•

Join Date: May 2008

Posts: 374

Reputation: Clockowl is on a distinguished road

Solved Threads: 27

Clockowl

Offline

Posting Whiz

Re: Strange (extra) data in buffer after ifstream::read()

Apr 14th, 2009

Meh, it's simply the null byte. new doesn't set the whole array to 0 like calloc() does. Thanks.

Working code:

 Help with Code Tags 
 cpp Syntax (Toggle Plain Text) 
#include <iostream>
#include <fstream>
#include <sstream>
#include <string>
 
/* load_file(filepath, destination)
 
   -Returns whether it succeed or not. True meaning succeeded.
   -Takes a path and writes to a std::string, completely memory safe.
*/
 
bool load_file(const char *filepath, std::string &dest){
    using namespace std;
 
    ifstream file;
    file.open(filepath, ios::binary);
    if(!file.good()){
        cerr << "Fatal error while opening file." << endl;
        return false;
    }
 
    //get filesize in bytes from ifstream
        //seek end, get pointer, rewind
    file.seekg(0, ios_base::end);
    size_t file_size = file.tellg();
    file.seekg(0, ios_base::beg);
    if(!file.good()){
        cerr << "Fatal error while getting filesize." << endl;
        return false;
    }
 
    //read file in string from ifstream
        //allocate array, read file in array, set the term. null byte, set string to array
    char *file_content = new char [file_size+1];
    file.read(file_content, file_size);
    file_content[file_size] = '\0';
    dest = file_content;
 
    //clean up
        //close file, free array
    file.close();
    delete[] file_content;
 
    return true;
}
 
 
int main(){
    using namespace std;
 
    string file_content;
    load_file("main.cpp", file_content);
    cout << file_content;
 
    return 0;
}
#include <iostream>
#include <fstream>
#include <sstream>
#include <string>

/* load_file(filepath, destination)

   -Returns whether it succeed or not. True meaning succeeded.
   -Takes a path and writes to a std::string, completely memory safe.
*/

bool load_file(const char *filepath, std::string &dest){
    using namespace std;

    ifstream file;
    file.open(filepath, ios::binary);
    if(!file.good()){
        cerr << "Fatal error while opening file." << endl;
        return false;
    }

    //get filesize in bytes from ifstream
        //seek end, get pointer, rewind
    file.seekg(0, ios_base::end);
    size_t file_size = file.tellg();
    file.seekg(0, ios_base::beg);
    if(!file.good()){
        cerr << "Fatal error while getting filesize." << endl;
        return false;
    }

    //read file in string from ifstream
        //allocate array, read file in array, set the term. null byte, set string to array
    char *file_content = new char [file_size+1];
    file.read(file_content, file_size);
    file_content[file_size] = '\0';
    dest = file_content;

    //clean up
        //close file, free array
    file.close();
    delete[] file_content;

    return true;
}


int main(){
    using namespace std;

    string file_content;
    load_file("main.cpp", file_content);
    cout << file_content;

    return 0;
}