Java

Java RSS

null pointer exception error while finding longest word in line

•

Join Date: Jun 2009

Posts: 99

Reputation: akulkarni is an unknown quantity at this point

Solved Threads: 4

akulkarni

Offline

Junior Poster in Training

null pointer exception error while finding longest word in line

Jul 2nd, 2009

i am getting run time error as provided in title
my code is

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
class maxstring
{
public static void main(String args[]) 
{
String s1="nikhil is a good boy";
int d;int x=0;
d=s1.length();
String[] s2=new String[d];
char ch;
for(int i=0;i<=d-1;i++)
{
ch=s1.charAt(i);
if(ch==' ')
{
s2[x]=s1.substring(x,i-1);
x=i+1;
}
}
String max=s2[0];
for(int i=0;i<=d-1;i++)
{
if(s2[i].compareTo(max)>0)
max=new String(s2[i]);
}
System.out.println(max);
}
}
class maxstring
{
public static void main(String args[]) 
{
String s1="nikhil is a good boy";
int d;int x=0;
d=s1.length();
String[] s2=new String[d];
char ch;
for(int i=0;i<=d-1;i++)
{
ch=s1.charAt(i);
if(ch==' ')
{
s2[x]=s1.substring(x,i-1);
x=i+1;
}
}
String max=s2[0];
for(int i=0;i<=d-1;i++)
{
if(s2[i].compareTo(max)>0)
max=new String(s2[i]);
}
System.out.println(max);
}
}

Last edited by Tekmaven; Jul 2nd, 2009 at 9:06 pm. Reason: Code Tags

•

Join Date: Sep 2008

Posts: 53

Reputation: di2daer is an unknown quantity at this point

Solved Threads: 12

di2daer

Offline

Junior Poster in Training

Re: null pointer exception error while finding longest word in line

Jul 2nd, 2009

Hi,
when you create your array you give it the length of all the characters in the string you're analyzing, but you're not initiaing it, so it contains only null (s2[0] = null, s2[1] = null etc) since string is an object. In the last for-loop you're calling method compareTo() for a null object. You can add a null check in the if statement to avoid this problem (if(s2[i] != null && the rest)

---------------------------
333 - halfway to hell

•

Join Date: Feb 2006

Posts: 2,326

Reputation: masijade has much to be proud of

Solved Threads: 248

masijade

Offline

Nearly a Posting Maven

Re: null pointer exception error while finding longest word in line

Jul 2nd, 2009

Where are you "getting" it? The exception provides a line number, you know.

Also, why do for(int i=0;i<=d-1;i++) when you can do for(int i=0;i<d;i++).

I believe, however, that you problem is here

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
String[] s2=new String[d];
String[] s2=new String[d];

Doing that creates an array of reference variables that must point to a String, however, initially all the elements contain a null pointer. You need to make sure that every element actually contains a reference to a String or the line if(s2[i].compareTo(max)>0) will cause an NPE on any element where you have not explicitly initiated a String reference.

You can probably solve it by changing ....

Edit:

Scratch that, I'm not sure what you're trying to do with that "logic" so I'll simply second that "add a null check".

Last edited by masijade; Jul 2nd, 2009 at 3:49 pm.

Java Programmer and Sun Systems Administrator

----------------------------------------------

Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it.
--Brian Kernighan

•

Join Date: Jun 2009

Posts: 99

Reputation: akulkarni is an unknown quantity at this point

Solved Threads: 4

akulkarni

Offline

Junior Poster in Training

Re: null pointer exception error while finding longest word in line

Jul 2nd, 2009

[code]
i am trying to create an array of strings with String [] s2=new String[25]
i will store every word in that array my line is "nikhil is a good boy"(s1) i am using substring to separate those words removing the spaces and put it into s2 array i want s2[0]=nikhil
s2[1]=is s2[2]=a s2[3]=good s[4]=boy i wish to print the longest word in the string s1
please help

•

Join Date: Jun 2009

Posts: 99

Reputation: akulkarni is an unknown quantity at this point

Solved Threads: 4

akulkarni

Offline

Junior Poster in Training

Re: null pointer exception error while finding longest word in line

Jul 2nd, 2009

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
 i commented the tocompare part and changed max=new s2...line in it to max=s2 but same error.It is not printing the words separately remooving spaces. i got the program with stringtokenizer but i want to create it on my own
 i commented the tocompare part and changed max=new s2...line in it to max=s2 but same error.It is not printing the words separately remooving spaces. i got the program with stringtokenizer but i want to create it on my own

•

Join Date: Oct 2008

Posts: 2,552

Reputation: adatapost has much to be proud of

Solved Threads: 451

adatapost

Offline

Posting Maven

Re: null pointer exception error while finding longest word in line

Jul 3rd, 2009

akulkarni,

14th post and you don't know, how to and where to use code tag?
Read this How to use code tags.

Try to include a complete description of your problem at your first post of this thread.

What masijade said:

•

Scratch that, I'm not sure what you're trying to do with that "logic" so I'll simply second that "add a null check".

Here is my suggestion :
Use split() method of String class.

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
    String s1="nikhil is a good boy";
   String []p=s1.split(" ");
    String s1="nikhil is a good boy";
   String []p=s1.split(" ");

Failure is not fatal, but failure to change might be. - John Wooden

•

Join Date: Feb 2006

Posts: 2,326

Reputation: masijade has much to be proud of

Solved Threads: 248

masijade

Offline

Nearly a Posting Maven

Re: null pointer exception error while finding longest word in line

Jul 3rd, 2009

•

Originally Posted by akulkarni

[code]
i am trying to create an array of strings with String [] s2=new String[25]
i will store every word in that array my line is "nikhil is a good boy"(s1) i am using substring to separate those words removing the spaces and put it into s2 array i want s2[0]=nikhil
s2[1]=is s2[2]=a s2[3]=good s[4]=boy i wish to print the longest word in the string s1
please help

Okay, so let's go through a bit of what you are actually doing.

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
class maxstring {
    public static void main(String args[])  {
        String s1="nikhil is a good boy";
        int d;int x=0;
        d=s1.length();
        /* With this next statement you now have the following array
         * 0 --> null
         * 1 --> null
         * 2 --> null
         * ...
         * 17 --> null
         * 18 --> null
         * 19 --> null
         */
        String[] s2=new String[d];
        char ch;
        for(int i=0;i<=d-1;i++) {
            ch=s1.charAt(i);
            if(ch==' ') {
                s2[x]=s1.substring(x,i-1);
                x=i+1;  // x is 0,7,10,12,17
            }
        }
        /* all elements, other than the following are still null
         * 0 --> nikhil
         * 7 --> is
         * 10 --> a
         * 12 --> good
         * 17 --> boy
         */
        String max=s2[0];
        /* in the following loop all elements except those listed above
         * will throw an NPE, since those elements are null.
         */
        for(int i=0;i<=d-1;i++) {
            /* This statement compares the Strings alphabetically
             * I thought you wanted the longest String?  Shouldn't you
             * be comparing their "length()"s?
             */
            if(s2[i].compareTo(max)>0)
                max=new String(s2[i]);
        }
        System.out.println(max);
    }
}
class maxstring {
    public static void main(String args[])  {
        String s1="nikhil is a good boy";
        int d;int x=0;
        d=s1.length();
        /* With this next statement you now have the following array
         * 0 --> null
         * 1 --> null
         * 2 --> null
         * ...
         * 17 --> null
         * 18 --> null
         * 19 --> null
         */
        String[] s2=new String[d];
        char ch;
        for(int i=0;i<=d-1;i++) {
            ch=s1.charAt(i);
            if(ch==' ') {
                s2[x]=s1.substring(x,i-1);
                x=i+1;  // x is 0,7,10,12,17
            }
        }
        /* all elements, other than the following are still null
         * 0 --> nikhil
         * 7 --> is
         * 10 --> a
         * 12 --> good
         * 17 --> boy
         */
        String max=s2[0];
        /* in the following loop all elements except those listed above
         * will throw an NPE, since those elements are null.
         */
        for(int i=0;i<=d-1;i++) {
            /* This statement compares the Strings alphabetically
             * I thought you wanted the longest String?  Shouldn't you
             * be comparing their "length()"s?
             */
            if(s2[i].compareTo(max)>0)
                max=new String(s2[i]);
        }
        System.out.println(max);
    }
}

A split() will give you an array of Strings, but that is not exactly "doing it yourself" as you said you wanted to. If you really want to parse the String yourself to create an array of Strings, then either use an ArrayList or handle your index better, or simply add the null check (which is the least effecient variant), or simply get the lengths of the Strings as you "find" them and compare them to the longest up to that point.

Last edited by masijade; Jul 3rd, 2009 at 3:30 am.

•

Join Date: Jun 2009

Posts: 99

Reputation: akulkarni is an unknown quantity at this point

Solved Threads: 4

akulkarni

Offline

Junior Poster in Training

Re: null pointer exception error while finding longest word in line

Jul 4th, 2009

 Help with Code Tags 
 Java Syntax (Toggle Plain Text) 
 
 
Dear Masijade
i tried with finding length and then comparing but found it impossible. can u help me about that.Also how do i do the Null check .thanks for your explaination i will give more time to think over it cause right now i am not able to visualise that NPE error falling short of grasping the concept.

Dear Masijade
i tried with finding length and then comparing but found it impossible. can u help me about that.Also how do i do the Null check .thanks for your explaination i will give more time to think over it cause right now i am not able to visualise that NPE error falling short of grasping the concept.